-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[ES|QL] Fix ES|QL columns reset race during active fetch #263947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bartoval
merged 3 commits into
elastic:main
from
bartoval:discover-esql-columns-reset-race
Apr 22, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -152,12 +152,13 @@ export const buildEsqlFetchSubscribe = ({ | |
|
|
||
| const { viewMode } = getCurrentTab().appState; | ||
| const changeViewMode = viewMode !== getValidViewMode({ viewMode, isEsqlMode: true }); | ||
|
|
||
| // If the index pattern hasn't changed, but the available columns have changed | ||
| // due to transformational commands, mark the associated profile state fields to reset | ||
| if (!indexPatternChanged && allColumnsChanged) { | ||
| internalState.dispatch( | ||
| injectCurrentTab(internalStateActions.setProfileStateFieldsToReset)({ | ||
| // This reset comes from the current fetch, so keep the same resetId. | ||
| // Otherwise the snapshot taken at fetch start looks stale when cleanup runs. | ||
| injectCurrentTab(internalStateActions.setProfileStateFieldsToResetWithoutResetId)({ | ||
|
Comment on lines
+159
to
+161
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I went down the rabbit hole on this and funny enough, it seems like this is likely dead code anyway (other than the bug 🙃). Not certain yet so these changes are good for now until we investigate, but opened a separate issue for it here: #264870. |
||
| fieldsToReset: ['columns'], | ||
| }) | ||
| ); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better a new action that represents a semantic exception than a flag on the previous action.