[Lens as code] Fix format visibility for last_value non-numeric dimensions#263810
Merged
andrimal merged 7 commits intoelastic:mainfrom Apr 20, 2026
Merged
Conversation
andrimal
added
Team:Visualizations
andrimal
commented
Apr 17, 2026
Comment on lines
+340
to
+341
| // Failing: See https://github.com/elastic/kibana/issues/253327 | ||
| test.skip('should list all field names and document as a whole in prioritized order', async () => { |
Contributor
Author
There was a problem hiding this comment.
Until this slow test issue is fixed #253327, lets only skip the problematic test and not the whole suite.
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
markov00
approved these changes
Apr 20, 2026
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Changes looks good to me
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 9.4 https://github.com/elastic/kibana/actions/runs/24667135059 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 20, 2026
…ensions (elastic#263810) ## Summary Fix elastic#263793 This PR aligns inline Lens dimension editor formatting for API-created charts with UI behavior by skipping `format` display when `last_value` uses a non-numeric field https://github.com/user-attachments/assets/beaaec55-5300-4a62-9170-ff7cd7d6d610 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 8ddda6a)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 20, 2026
…ic dimensions (#263810) (#264395) # Backport This will backport the following commits from `main` to `9.4`: - [[Lens as code] Fix format visibility for `last_value` non-numeric dimensions (#263810)](#263810) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Andreana Malama","email":"andreana.malama@elastic.co"},"sourceCommit":{"committedDate":"2026-04-20T12:43:07Z","message":"[Lens as code] Fix format visibility for `last_value` non-numeric dimensions (#263810)\n\n## Summary\n\nFix #263793 \n\nThis PR aligns inline Lens dimension editor formatting for API-created\ncharts with UI behavior by skipping `format` display when `last_value`\nuses a non-numeric field\n\n\nhttps://github.com/user-attachments/assets/beaaec55-5300-4a62-9170-ff7cd7d6d610\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"8ddda6adeb498970ad637e4adb4042116eb14014","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport:version","v9.4.0","v9.5.0"],"title":"[Lens as code] Fix format visibility for `last_value` non-numeric dimensions","number":263810,"url":"https://github.com/elastic/kibana/pull/263810","mergeCommit":{"message":"[Lens as code] Fix format visibility for `last_value` non-numeric dimensions (#263810)\n\n## Summary\n\nFix #263793 \n\nThis PR aligns inline Lens dimension editor formatting for API-created\ncharts with UI behavior by skipping `format` display when `last_value`\nuses a non-numeric field\n\n\nhttps://github.com/user-attachments/assets/beaaec55-5300-4a62-9170-ff7cd7d6d610\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"8ddda6adeb498970ad637e4adb4042116eb14014"}},"sourceBranch":"main","suggestedTargetBranches":["9.4"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/263810","number":263810,"mergeCommit":{"message":"[Lens as code] Fix format visibility for `last_value` non-numeric dimensions (#263810)\n\n## Summary\n\nFix #263793 \n\nThis PR aligns inline Lens dimension editor formatting for API-created\ncharts with UI behavior by skipping `format` display when `last_value`\nuses a non-numeric field\n\n\nhttps://github.com/user-attachments/assets/beaaec55-5300-4a62-9170-ff7cd7d6d610\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"8ddda6adeb498970ad637e4adb4042116eb14014"}}]}] BACKPORT--> Co-authored-by: Andreana Malama <andreana.malama@elastic.co>
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Apr 20, 2026
The lens entry bundle was 72-83B over its 86,000B page-load limit after rebasing this branch on main. Nothing in this PR's scope (kbn-unified-chart-section-viewer + one Discover test spec) can reach lens's bundle — a codebase-wide grep shows zero imports of @kbn/unified-chart-section-viewer from x-pack/platform/plugins/shared/lens, and a local dist build's stats.json contains no matching module paths. Cumulative drift from recent Lens-as-code commits that merged into main (e.g., elastic#262871, elastic#264134, elastic#261581, elastic#264147, elastic#263810) pushed the entry bundle just over the line. Raising the limit here is the documented path when no in-PR contribution is found. Limit set via `node scripts/build_kibana_platform_plugins --focus lens --update-limits`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #263793
This PR aligns inline Lens dimension editor formatting for API-created charts with UI behavior by skipping
formatdisplay whenlast_valueuses a non-numeric fieldafter.fix.mp4
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesbackport:*labels.