Skip to content

[6.5] Feat: add self-snapping of canvas elements (#26092) #26367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monfera merged 1 commit into from
Nov 28, 2018
Merged

[6.5] Feat: add self-snapping of canvas elements (#26092) #26367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions x-pack/plugins/canvas/public/lib/aeroelastic/layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,10 +661,18 @@ const alignmentGuides = (shapes, guidedShapes, draggedShape) => {
if (d.type === 'annotation') continue; // fixme avoid this by not letting annotations get in here
// key points of the dragged shape bounding box
for (let j = 0; j < shapes.length; j++) {
const s = shapes[j];
if (d.id === s.id) continue; // don't self-constrain; todo in the future, self-constrain to the original location
if (s.type === 'annotation') continue; // fixme avoid this by not letting annotations get in here
if (s.parent) continue; // for now, don't snap to grouped elements fixme could snap, but make sure transform is gloabl
const referenceShape = shapes[j];
if (referenceShape.type === 'annotation') continue; // fixme avoid this by not letting annotations get in here
if (referenceShape.parent) continue; // for now, don't snap to grouped elements fixme could snap, but make sure transform is gloabl
const s =
d.id === referenceShape.id
? {
...d,
localTransformMatrix: d.baselineLocalTransformMatrix || d.localTransformMatrix,
a: d.baseAB ? d.baseAB[0] : d.a,
b: d.baseAB ? d.baseAB[1] : d.b,
}
: referenceShape;
// key points of the stationery shape
for (let k = -1; k < 2; k++) {
for (let l = -1; l < 2; l++) {
Expand Down