Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
2837ca9
[Metrics][Discover] Preserve dimension picker options across filtered…
justinkambic Apr 15, 2026
66bf52a
Merge branch 'main' of github.com:elastic/kibana into 263309/fix-dime…
justinkambic Apr 16, 2026
1866465
fix: correct stale useFetchMetricsData docstring
justinkambic Apr 16, 2026
607e3cc
refactor: move accumulator reset out of render body
justinkambic Apr 16, 2026
6269aa2
fix: reset accumulator on any data-context change
justinkambic Apr 16, 2026
fad8608
test: cover accumulator plumbing in useFetchMetricsData
justinkambic Apr 16, 2026
2466682
Merge branch 'main' of github.com:elastic/kibana into 263309/fix-dime…
justinkambic Apr 16, 2026
c0302d3
fix: guard accumulator ref write against aborted fetches
justinkambic Apr 16, 2026
8c3dd8e
refactor: extract accumulator into useAccumulatedDimensions
justinkambic Apr 16, 2026
051ebf4
Merge branch 'main' of github.com:elastic/kibana into 263309/fix-dime…
justinkambic Apr 16, 2026
51a6297
Move dimension sort out of mergeDimensions
justinkambic Apr 17, 2026
1eb2379
revert: remove dimension accumulator
justinkambic Apr 17, 2026
290aaf1
feat(picker): surface selected dimensions even when not in applicable…
justinkambic Apr 17, 2026
8715b03
Merge branch 'main' of github.com:elastic/kibana into 263309/fix-dime…
justinkambic Apr 17, 2026
491456a
feat(picker): optimistically filter options by current selection
justinkambic Apr 17, 2026
77dd029
Merge branch 'main' of github.com:elastic/kibana into 263309/fix-dime…
justinkambic Apr 17, 2026
8aa797e
chore: strip planning references from picker comments
justinkambic Apr 17, 2026
d8167d5
refactor(picker): extract applicable-dimensions helper
justinkambic Apr 17, 2026
82dbfe6
refactor(picker): address reviewer cleanups
justinkambic Apr 17, 2026
1c4465d
Merge branch 'main' into 263309/fix-dimension-picker
lucaslopezf Apr 20, 2026
1fc97b7
Merge branch 'main' into 263309/fix-dimension-picker
justinkambic Apr 20, 2026
a45b223
Merge branch 'main' of github.com:elastic/kibana into 263309/fix-dime…
justinkambic Apr 20, 2026
71a8779
refactor(dimensions-selector): extract business logic into custom hook
justinkambic Apr 20, 2026
2c0e3ae
Merge branch '263309/fix-dimension-picker' of github.com:justinkambic…
justinkambic Apr 20, 2026
add6a5a
Merge branch 'main' of github.com:elastic/kibana into 263309/fix-dime…
justinkambic Apr 20, 2026
374723a
chore(limits): bump lens page-load bundle limit
justinkambic Apr 20, 2026
c2680f6
refactor(dimensions-selector): carry Dimension on option, extract bui…
justinkambic Apr 21, 2026
618e8d9
refactor(dimensions-selector): extract button/tooltip/footer as compo…
justinkambic Apr 21, 2026
191f189
test(dimensions-selector): add unit tests for useDimensionsSelector
justinkambic Apr 21, 2026
ba65225
Merge branch 'main' of github.com:elastic/kibana into 263309/fix-dime…
justinkambic Apr 21, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ import { getEsqlQuery } from '../utils/get_esql_query';

/**
* Fetches METRICS_INFO when in Metrics Experience (non-transformational ES|QL, chart visible).
* When selectedDimensionNames has more than one item, refetches with a WHERE filter so only
* metrics that have at least one of those dimensions are returned.
* When selectedDimensionNames is non-empty, refetches with a WHERE filter so only
* metrics that have all of the selected dimensions are returned.
* Returns loading state, error, and parsed metrics info for the grid.
*/
export function useFetchMetricsData({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export const MetricsExperienceGrid = ({

const { toggleActions, leftSideActions, rightSideActions } = useToolbarActions({
allDimensions,
metricItems,
renderToggleActions,
onDimensionsChange: onToolbarDimensionsChange,
isLoading: isDiscoverLoading,
Expand Down
Loading
Loading