[EDR Workflows] Remove flaky skipped tests covered elsewhere#263585
Merged
szwarckonrad merged 4 commits intoMay 8, 2026
Conversation
…y unit tests (closes elastic#175791)
szwarckonrad
added
release_note:skip
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes skipped flaky integration tests that are already covered by unit tests or were testing external system behavior rather than our code.
#175791 — metadata transforms stats tests
The
describe.skip('get metadata transforms')suite was testing that ourMETADATA_TRANSFORMS_STATUS_INTERNAL_ROUTEAPI correctly returns transform stats in started/stopped states. The flakiness was a race condition — the previous test stops both transforms then restarts them, but the restart hadn't fully completed before the next test asserted STARTED state (expected 1 to sort of equal 2).The route handler is a pure pass-through: it calls
esClient.transform.getTransformStats()and returns the result. The meaningful coverage (authz check, correct ES call, response forwarding) is already provided by unit tests inmetadata.test.ts. The integration tests were only validating that Elasticsearch transform state transitions work — not our responsibility.Removed: 3 skipped tests + unused imports/variables.
Closes #175791