[Security Solution] Turns on feature flag for deprecated prebuilt rules workflow#263560
Merged
dplumlee merged 14 commits intoelastic:mainfrom Apr 22, 2026
Merged
Conversation
dplumlee
added
release_note:skip
dplumlee
changed the title
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
nikitaindik
reviewed
Apr 21, 2026
nikitaindik
reviewed
Apr 21, 2026
nikitaindik
reviewed
Apr 21, 2026
nikitaindik
reviewed
Apr 21, 2026
nikitaindik
reviewed
Apr 21, 2026
Contributor
nikitaindik
left a comment
nikitaindik
left a comment
There was a problem hiding this comment.
Hey, @dplumlee! I reviewed and left a few comments. Please take a look.
dplumlee
force-pushed
the
deprecated-rules-feature-flag-on
branch
from
f743f59 to
2e3450a
Compare
nikitaindik
reviewed
Apr 22, 2026
| values={{ | ||
| docsLink: ( | ||
| <EuiLink | ||
| href="https://www.elastic.co/docs/solutions/security/detect-and-alert/manage-detection-rules#deprecated-prebuilt-rules" |
Contributor
There was a problem hiding this comment.
nit: We can use an existing manageDetectionRules doc link here. Here's an example: https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation/components/step_rule_actions/translations.tsx#L30-L37
Contributor
|
nit: Callout buttons look slightly different – colors, padding and margin |
nikitaindik
approved these changes
Apr 22, 2026
Contributor
There was a problem hiding this comment.
Thanks for the fixes, Davis! I re-reviewed, re-tested and left a couple of minor comments for you to consider. Approving in advance.
Side note: I tested on 9.4.0-beta.1 package by building it from source and adding this to the config:
xpack.fleet.developer:
bundledPackageLocation: /Users/nondemic/Work/detection-rules/dist/bundled
disableRegistryVersionCheck: true
xpack.securitySolution.prebuiltRulesPackageVersion: 9.4.0-beta.1
I haven't tested on a real package, since it's not yet in the EPR.
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
cc @dplumlee |
Contributor
|
Starting backport for target branches: 9.4 https://github.com/elastic/kibana/actions/runs/24801949169 |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 22, 2026
…lt rules workflow (#263560) (#265154) # Backport This will backport the following commits from `main` to `9.4`: - [[Security Solution] Turns on feature flag for deprecated prebuilt rules workflow (#263560)](#263560) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-04-22T20:49:37Z","message":"[Security Solution] Turns on feature flag for deprecated prebuilt rules workflow (#263560)\n\n## Summary\n\nTurns on the `prebuiltRulesDeprecationUIEnabled` feature flag\nimplemented in this PR: https://github.com/elastic/kibana/pull/259673\n\nAlso makes some small UI fixes that were brought up during acceptance\ntesting:\n\n- Adds different language to the duplicate and delete modal informing\nthe user of the deletion\n - Adds padding to the tooltips in the duplication confirm modal\n - Adds link to docs in callout components\n\n### Screenshots\n\n\n\n<img width=\"1051\" height=\"468\" alt=\"Screenshot 2026-04-16 at 12 33\n29 PM\"\nsrc=\"https://github.com/user-attachments/assets/468d970d-9009-40ef-99d9-c693e46c3e1a\"\n/>\n\n\n<img width=\"1744\" height=\"321\" alt=\"Screenshot 2026-04-20 at 4 47 45 PM\"\nsrc=\"https://github.com/user-attachments/assets/db580301-edb8-44b5-851c-197aab366c81\"\n/>","sha":"65cf4f24f67642678bf71fe528fd17d11e2a1ee9","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.4.0","v9.5.0"],"title":"[Security Solution] Turns on feature flag for deprecated prebuilt rules workflow","number":263560,"url":"https://github.com/elastic/kibana/pull/263560","mergeCommit":{"message":"[Security Solution] Turns on feature flag for deprecated prebuilt rules workflow (#263560)\n\n## Summary\n\nTurns on the `prebuiltRulesDeprecationUIEnabled` feature flag\nimplemented in this PR: https://github.com/elastic/kibana/pull/259673\n\nAlso makes some small UI fixes that were brought up during acceptance\ntesting:\n\n- Adds different language to the duplicate and delete modal informing\nthe user of the deletion\n - Adds padding to the tooltips in the duplication confirm modal\n - Adds link to docs in callout components\n\n### Screenshots\n\n\n\n<img width=\"1051\" height=\"468\" alt=\"Screenshot 2026-04-16 at 12 33\n29 PM\"\nsrc=\"https://github.com/user-attachments/assets/468d970d-9009-40ef-99d9-c693e46c3e1a\"\n/>\n\n\n<img width=\"1744\" height=\"321\" alt=\"Screenshot 2026-04-20 at 4 47 45 PM\"\nsrc=\"https://github.com/user-attachments/assets/db580301-edb8-44b5-851c-197aab366c81\"\n/>","sha":"65cf4f24f67642678bf71fe528fd17d11e2a1ee9"}},"sourceBranch":"main","suggestedTargetBranches":["9.4"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/263560","number":263560,"mergeCommit":{"message":"[Security Solution] Turns on feature flag for deprecated prebuilt rules workflow (#263560)\n\n## Summary\n\nTurns on the `prebuiltRulesDeprecationUIEnabled` feature flag\nimplemented in this PR: https://github.com/elastic/kibana/pull/259673\n\nAlso makes some small UI fixes that were brought up during acceptance\ntesting:\n\n- Adds different language to the duplicate and delete modal informing\nthe user of the deletion\n - Adds padding to the tooltips in the duplication confirm modal\n - Adds link to docs in callout components\n\n### Screenshots\n\n\n\n<img width=\"1051\" height=\"468\" alt=\"Screenshot 2026-04-16 at 12 33\n29 PM\"\nsrc=\"https://github.com/user-attachments/assets/468d970d-9009-40ef-99d9-c693e46c3e1a\"\n/>\n\n\n<img width=\"1744\" height=\"321\" alt=\"Screenshot 2026-04-20 at 4 47 45 PM\"\nsrc=\"https://github.com/user-attachments/assets/db580301-edb8-44b5-851c-197aab366c81\"\n/>","sha":"65cf4f24f67642678bf71fe528fd17d11e2a1ee9"}}]}] BACKPORT--> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
smith
pushed a commit
to smith/kibana
that referenced
this pull request
Apr 23, 2026
…es workflow (elastic#263560) ## Summary Turns on the `prebuiltRulesDeprecationUIEnabled` feature flag implemented in this PR: elastic#259673 Also makes some small UI fixes that were brought up during acceptance testing: - Adds different language to the duplicate and delete modal informing the user of the deletion - Adds padding to the tooltips in the duplication confirm modal - Adds link to docs in callout components ### Screenshots <img width="1051" height="468" alt="Screenshot 2026-04-16 at 12 33 29 PM" src="https://github.com/user-attachments/assets/468d970d-9009-40ef-99d9-c693e46c3e1a" /> <img width="1744" height="321" alt="Screenshot 2026-04-20 at 4 47 45 PM" src="https://github.com/user-attachments/assets/db580301-edb8-44b5-851c-197aab366c81" />
hop-dev
added a commit
to opauloh/kibana
that referenced
this pull request
Apr 24, 2026
Rebase conflict in df35c46 caused this flag to be reverted to false; restoring to true as set by elastic#263560. Made-with: Cursor
rbrtj
pushed a commit
to walterra/kibana
that referenced
this pull request
Apr 27, 2026
…es workflow (elastic#263560) ## Summary Turns on the `prebuiltRulesDeprecationUIEnabled` feature flag implemented in this PR: elastic#259673 Also makes some small UI fixes that were brought up during acceptance testing: - Adds different language to the duplicate and delete modal informing the user of the deletion - Adds padding to the tooltips in the duplication confirm modal - Adds link to docs in callout components ### Screenshots <img width="1051" height="468" alt="Screenshot 2026-04-16 at 12 33 29 PM" src="https://github.com/user-attachments/assets/468d970d-9009-40ef-99d9-c693e46c3e1a" /> <img width="1744" height="321" alt="Screenshot 2026-04-20 at 4 47 45 PM" src="https://github.com/user-attachments/assets/db580301-edb8-44b5-851c-197aab366c81" />
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Apr 27, 2026
…es workflow (elastic#263560) ## Summary Turns on the `prebuiltRulesDeprecationUIEnabled` feature flag implemented in this PR: elastic#259673 Also makes some small UI fixes that were brought up during acceptance testing: - Adds different language to the duplicate and delete modal informing the user of the deletion - Adds padding to the tooltips in the duplication confirm modal - Adds link to docs in callout components ### Screenshots <img width="1051" height="468" alt="Screenshot 2026-04-16 at 12 33 29 PM" src="https://github.com/user-attachments/assets/468d970d-9009-40ef-99d9-c693e46c3e1a" /> <img width="1744" height="321" alt="Screenshot 2026-04-20 at 4 47 45 PM" src="https://github.com/user-attachments/assets/db580301-edb8-44b5-851c-197aab366c81" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns on the
prebuiltRulesDeprecationUIEnabledfeature flag implemented in this PR: #259673Also makes some small UI fixes that were brought up during acceptance testing:
Screenshots