[Lens] Fix timefield hydration for API generated charts#263481
Closed
markov00 wants to merge 9 commits intoelastic:mainfrom
Closed
[Lens] Fix timefield hydration for API generated charts#263481markov00 wants to merge 9 commits intoelastic:mainfrom
markov00 wants to merge 9 commits intoelastic:mainfrom
Conversation
markov00
added
bug
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
Catch flakiness early (recommended)Recommended before merge: run the flaky test runner against this PR to catch flakiness early. Trigger a run with the Flaky Test Runner UI or post this comment on the PR: This check is experimental. Share your feedback in the #appex-qa channel. Posted via Macroscope — Flaky Test Runner nudge |
Contributor
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
|
Contributor
Author
|
replaced by #264134 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API generated charts currently doesn't contain information if a XY chart is actually a time based chart or a categorical chart.
We have left this information to be computed/decided at runtime (as it's currently done when you create a chart from the Lens UI).
But information about the current timeField is required:
This PR fixes this problem (better then the predecessor PR) by hydrating the state at the time of the deserialization.
This can't be done in a later stage (like after the data is received) because we need the timeField information to add the proper DSL filter on top of the ESQL query.
For ESQL folks, I've just extracted the getESQLTimeField into its own file, so it can be easily reused without the need to touch the DataViews as it was initially used.
In our hydration we also need to add the correct
meta.typeto the column specified at the API level. Because column name and timeField can differ, I've temporarly implemented a function that uses thegetQuerySummaryto get actual column names associated with possible bucketing aggregations (TBUCKET, BUCKET, DATE_TRUNC) and we use this to match the actual column name described by the API user and associate the proper meta.type.The previous
ensureESQLTimeFieldOnAdHocDataViewswas replaced with thehydrateESQLTimeFields.A set of scout tests are in place to evaluate eventual regressions.
fix #262425
fix #262181