Add aria-hidden to decorative EuiIcon components in ES|QL files#262744
Merged
Add aria-hidden to decorative EuiIcon components in ES|QL files#262744
aria-hidden to decorative EuiIcon components in ES|QL files#262744Conversation
6 tasks
…ssibility
Add aria-hidden={true} to decorative EuiIcon components in three files
to fix @elastic/eui/icon-accessibility-rules ESLint violations.
Closes #224193
Agent-Logs-Url: https://github.com/elastic/kibana/sessions/4ca05fec-2984-4c7f-aa15-068c83fb9d20
Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix @elastic/eui/icon-accessibility-rules lint violations in @elastic/kibana-esql
Add Apr 13, 2026
aria-hidden to decorative EuiIcon components in ES|QL files
Contributor
|
/ci |
stratoula
approved these changes
Apr 13, 2026
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @alexwizp @Copilot |
alexwizp
added
backport:version
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
alexwizp
added
release_note:skip
alexwizp
approved these changes
Apr 13, 2026
Contributor
|
@elasticmachine run docs-build |
alexwizp
deleted the
copilot/fix-eslint-violations-icon-accessibility-rules
branch
Contributor
|
Starting backport for target branches: 9.3, 9.4 https://github.com/elastic/kibana/actions/runs/24346928222 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 13, 2026
…lastic#262744) Closes: elastic#262712 Fixes 3 `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/kibana-esql` files. All three icons are decorative (adjacent text already conveys meaning), so `aria-hidden={true}` is the correct fix. - **`errors_warnings_popover.tsx`** — error/warning icon next to "Line N" text - **`column_header_renderer.tsx`** — plus icon next to "Add a field…" label - **`data_grid.tsx`** — Discover app icon inside "Open in Discover" link Closes elastic#224193 > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `ci-stats.kibana.dev` > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/yarn_install_scripts.js run ldd 0.8.2` (dns block) > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap` (dns block) > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap --no-validate s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1 t } } { printf &elastic#34;%s%s&elastic#34;, sep, --compressed /ldd get --global t ldd s/li��` (dns block) > - `clients3.google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��` (dns block) > - `detectportal.firefox.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��` (dns block) > - `google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��` (dns block) > - `googlechromelabs.github.io` > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js k/_temp/ghcca-node/node/bin/git ldd b/li��` (dns block) > - `iojs.org` > - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/elastic/kibana/settings/copilot/coding_agent) (admins only) > > </details> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> (cherry picked from commit cc0eea1)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 13, 2026
…lastic#262744) Closes: elastic#262712 Fixes 3 `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/kibana-esql` files. All three icons are decorative (adjacent text already conveys meaning), so `aria-hidden={true}` is the correct fix. - **`errors_warnings_popover.tsx`** — error/warning icon next to "Line N" text - **`column_header_renderer.tsx`** — plus icon next to "Add a field…" label - **`data_grid.tsx`** — Discover app icon inside "Open in Discover" link Closes elastic#224193 > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `ci-stats.kibana.dev` > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/yarn_install_scripts.js run ldd 0.8.2` (dns block) > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap` (dns block) > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap --no-validate s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1 t } } { printf &elastic#34;%s%s&elastic#34;, sep, --compressed /ldd get --global t ldd s/li��` (dns block) > - `clients3.google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��` (dns block) > - `detectportal.firefox.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��` (dns block) > - `google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��` (dns block) > - `googlechromelabs.github.io` > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js k/_temp/ghcca-node/node/bin/git ldd b/li��` (dns block) > - `iojs.org` > - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/elastic/kibana/settings/copilot/coding_agent) (admins only) > > </details> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> (cherry picked from commit cc0eea1)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Apr 13, 2026
…lastic#262744) Closes: elastic#262712 Fixes 3 `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/kibana-esql` files. All three icons are decorative (adjacent text already conveys meaning), so `aria-hidden={true}` is the correct fix. - **`errors_warnings_popover.tsx`** — error/warning icon next to "Line N" text - **`column_header_renderer.tsx`** — plus icon next to "Add a field…" label - **`data_grid.tsx`** — Discover app icon inside "Open in Discover" link Closes elastic#224193 > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `ci-stats.kibana.dev` > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/yarn_install_scripts.js run ldd 0.8.2` (dns block) > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap` (dns block) > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap --no-validate s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1 t } } { printf &elastic#34;%s%s&elastic#34;, sep, --compressed /ldd get --global t ldd s/li��` (dns block) > - `clients3.google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��` (dns block) > - `detectportal.firefox.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��` (dns block) > - `google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��` (dns block) > - `googlechromelabs.github.io` > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js k/_temp/ghcca-node/node/bin/git ldd b/li��` (dns block) > - `iojs.org` > - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/elastic/kibana/settings/copilot/coding_agent) (admins only) > > </details> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Apr 13, 2026
…iles (#262744) (#262782) # Backport This will backport the following commits from `main` to `9.4`: - [Add `aria-hidden` to decorative `EuiIcon` components in ES|QL files (#262744)](#262744) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-04-13T13:48:13Z","message":"Add `aria-hidden` to decorative `EuiIcon` components in ES|QL files (#262744)\n\nCloses: https://github.com/elastic/kibana/issues/262712\n\nFixes 3 `@elastic/eui/icon-accessibility-rules` lint violations across\n`@elastic/kibana-esql` files. All three icons are decorative (adjacent\ntext already conveys meaning), so `aria-hidden={true}` is the correct\nfix.\n\n- **`errors_warnings_popover.tsx`** — error/warning icon next to \"Line\nN\" text\n- **`column_header_renderer.tsx`** — plus icon next to \"Add a field…\"\nlabel\n- **`data_grid.tsx`** — Discover app icon inside \"Open in Discover\" link\n\nCloses #224193\n\n> [!WARNING]\n>\n> <details>\n> <summary>Firewall rules blocked me from connecting to one or more\naddresses (expand for details)</summary>\n>\n> #### I tried to connect to the following addresses, but was blocked by\nfirewall rules:\n>\n> - `ci-stats.kibana.dev`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\nscripts/yarn_install_scripts.js run ldd 0.8.2` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap --no-validate s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1 t }\n }\n{ printf "%s%s", sep, --compressed /ldd get --global t ldd\ns/li\u0004\u0018` (dns block)\n> - `clients3.google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `detectportal.firefox.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `googlechromelabs.github.io`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js\nk/_temp/ghcca-node/node/bin/git ldd b/li\u0004\u0018` (dns block)\n> - `iojs.org`\n> - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s\nREDACTED -o -` (dns block)\n>\n> If you need me to access, download, or install something from one of\nthese locations, you can either:\n>\n> - Configure [Actions setup\nsteps](https://gh.io/copilot/actions-setup-steps) to set up my\nenvironment, which run before the firewall is enabled\n> - Add the appropriate URLs or hosts to the custom allowlist in this\nrepository's [Copilot coding agent\nsettings](https://github.com/elastic/kibana/settings/copilot/coding_agent)\n(admins only)\n>\n> </details>\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>","sha":"cc0eea1826d9f73cb04ca2188477f843f325d932","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","💝community","backport:version","v9.4.0","a11y:agent-pr","v9.5.0","v9.3.4"],"title":"Add `aria-hidden` to decorative `EuiIcon` components in ES|QL files","number":262744,"url":"https://github.com/elastic/kibana/pull/262744","mergeCommit":{"message":"Add `aria-hidden` to decorative `EuiIcon` components in ES|QL files (#262744)\n\nCloses: https://github.com/elastic/kibana/issues/262712\n\nFixes 3 `@elastic/eui/icon-accessibility-rules` lint violations across\n`@elastic/kibana-esql` files. All three icons are decorative (adjacent\ntext already conveys meaning), so `aria-hidden={true}` is the correct\nfix.\n\n- **`errors_warnings_popover.tsx`** — error/warning icon next to \"Line\nN\" text\n- **`column_header_renderer.tsx`** — plus icon next to \"Add a field…\"\nlabel\n- **`data_grid.tsx`** — Discover app icon inside \"Open in Discover\" link\n\nCloses #224193\n\n> [!WARNING]\n>\n> <details>\n> <summary>Firewall rules blocked me from connecting to one or more\naddresses (expand for details)</summary>\n>\n> #### I tried to connect to the following addresses, but was blocked by\nfirewall rules:\n>\n> - `ci-stats.kibana.dev`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\nscripts/yarn_install_scripts.js run ldd 0.8.2` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap --no-validate s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1 t }\n }\n{ printf "%s%s", sep, --compressed /ldd get --global t ldd\ns/li\u0004\u0018` (dns block)\n> - `clients3.google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `detectportal.firefox.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `googlechromelabs.github.io`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js\nk/_temp/ghcca-node/node/bin/git ldd b/li\u0004\u0018` (dns block)\n> - `iojs.org`\n> - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s\nREDACTED -o -` (dns block)\n>\n> If you need me to access, download, or install something from one of\nthese locations, you can either:\n>\n> - Configure [Actions setup\nsteps](https://gh.io/copilot/actions-setup-steps) to set up my\nenvironment, which run before the firewall is enabled\n> - Add the appropriate URLs or hosts to the custom allowlist in this\nrepository's [Copilot coding agent\nsettings](https://github.com/elastic/kibana/settings/copilot/coding_agent)\n(admins only)\n>\n> </details>\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>","sha":"cc0eea1826d9f73cb04ca2188477f843f325d932"}},"sourceBranch":"main","suggestedTargetBranches":["9.4","9.3"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/262744","number":262744,"mergeCommit":{"message":"Add `aria-hidden` to decorative `EuiIcon` components in ES|QL files (#262744)\n\nCloses: https://github.com/elastic/kibana/issues/262712\n\nFixes 3 `@elastic/eui/icon-accessibility-rules` lint violations across\n`@elastic/kibana-esql` files. All three icons are decorative (adjacent\ntext already conveys meaning), so `aria-hidden={true}` is the correct\nfix.\n\n- **`errors_warnings_popover.tsx`** — error/warning icon next to \"Line\nN\" text\n- **`column_header_renderer.tsx`** — plus icon next to \"Add a field…\"\nlabel\n- **`data_grid.tsx`** — Discover app icon inside \"Open in Discover\" link\n\nCloses #224193\n\n> [!WARNING]\n>\n> <details>\n> <summary>Firewall rules blocked me from connecting to one or more\naddresses (expand for details)</summary>\n>\n> #### I tried to connect to the following addresses, but was blocked by\nfirewall rules:\n>\n> - `ci-stats.kibana.dev`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\nscripts/yarn_install_scripts.js run ldd 0.8.2` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap --no-validate s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1 t }\n }\n{ printf "%s%s", sep, --compressed /ldd get --global t ldd\ns/li\u0004\u0018` (dns block)\n> - `clients3.google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `detectportal.firefox.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `googlechromelabs.github.io`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js\nk/_temp/ghcca-node/node/bin/git ldd b/li\u0004\u0018` (dns block)\n> - `iojs.org`\n> - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s\nREDACTED -o -` (dns block)\n>\n> If you need me to access, download, or install something from one of\nthese locations, you can either:\n>\n> - Configure [Actions setup\nsteps](https://gh.io/copilot/actions-setup-steps) to set up my\nenvironment, which run before the firewall is enabled\n> - Add the appropriate URLs or hosts to the custom allowlist in this\nrepository's [Copilot coding agent\nsettings](https://github.com/elastic/kibana/settings/copilot/coding_agent)\n(admins only)\n>\n> </details>\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>","sha":"cc0eea1826d9f73cb04ca2188477f843f325d932"}},{"branch":"9.3","label":"v9.3.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Apr 13, 2026
…iles (#262744) (#262781) # Backport This will backport the following commits from `main` to `9.3`: - [Add `aria-hidden` to decorative `EuiIcon` components in ES|QL files (#262744)](#262744) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-04-13T13:48:13Z","message":"Add `aria-hidden` to decorative `EuiIcon` components in ES|QL files (#262744)\n\nCloses: https://github.com/elastic/kibana/issues/262712\n\nFixes 3 `@elastic/eui/icon-accessibility-rules` lint violations across\n`@elastic/kibana-esql` files. All three icons are decorative (adjacent\ntext already conveys meaning), so `aria-hidden={true}` is the correct\nfix.\n\n- **`errors_warnings_popover.tsx`** — error/warning icon next to \"Line\nN\" text\n- **`column_header_renderer.tsx`** — plus icon next to \"Add a field…\"\nlabel\n- **`data_grid.tsx`** — Discover app icon inside \"Open in Discover\" link\n\nCloses #224193\n\n> [!WARNING]\n>\n> <details>\n> <summary>Firewall rules blocked me from connecting to one or more\naddresses (expand for details)</summary>\n>\n> #### I tried to connect to the following addresses, but was blocked by\nfirewall rules:\n>\n> - `ci-stats.kibana.dev`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\nscripts/yarn_install_scripts.js run ldd 0.8.2` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap --no-validate s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1 t }\n }\n{ printf "%s%s", sep, --compressed /ldd get --global t ldd\ns/li\u0004\u0018` (dns block)\n> - `clients3.google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `detectportal.firefox.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `googlechromelabs.github.io`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js\nk/_temp/ghcca-node/node/bin/git ldd b/li\u0004\u0018` (dns block)\n> - `iojs.org`\n> - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s\nREDACTED -o -` (dns block)\n>\n> If you need me to access, download, or install something from one of\nthese locations, you can either:\n>\n> - Configure [Actions setup\nsteps](https://gh.io/copilot/actions-setup-steps) to set up my\nenvironment, which run before the firewall is enabled\n> - Add the appropriate URLs or hosts to the custom allowlist in this\nrepository's [Copilot coding agent\nsettings](https://github.com/elastic/kibana/settings/copilot/coding_agent)\n(admins only)\n>\n> </details>\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>","sha":"cc0eea1826d9f73cb04ca2188477f843f325d932","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","💝community","backport:version","v9.4.0","a11y:agent-pr","v9.5.0","v9.3.4"],"title":"Add `aria-hidden` to decorative `EuiIcon` components in ES|QL files","number":262744,"url":"https://github.com/elastic/kibana/pull/262744","mergeCommit":{"message":"Add `aria-hidden` to decorative `EuiIcon` components in ES|QL files (#262744)\n\nCloses: https://github.com/elastic/kibana/issues/262712\n\nFixes 3 `@elastic/eui/icon-accessibility-rules` lint violations across\n`@elastic/kibana-esql` files. All three icons are decorative (adjacent\ntext already conveys meaning), so `aria-hidden={true}` is the correct\nfix.\n\n- **`errors_warnings_popover.tsx`** — error/warning icon next to \"Line\nN\" text\n- **`column_header_renderer.tsx`** — plus icon next to \"Add a field…\"\nlabel\n- **`data_grid.tsx`** — Discover app icon inside \"Open in Discover\" link\n\nCloses #224193\n\n> [!WARNING]\n>\n> <details>\n> <summary>Firewall rules blocked me from connecting to one or more\naddresses (expand for details)</summary>\n>\n> #### I tried to connect to the following addresses, but was blocked by\nfirewall rules:\n>\n> - `ci-stats.kibana.dev`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\nscripts/yarn_install_scripts.js run ldd 0.8.2` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap --no-validate s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1 t }\n }\n{ printf "%s%s", sep, --compressed /ldd get --global t ldd\ns/li\u0004\u0018` (dns block)\n> - `clients3.google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `detectportal.firefox.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `googlechromelabs.github.io`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js\nk/_temp/ghcca-node/node/bin/git ldd b/li\u0004\u0018` (dns block)\n> - `iojs.org`\n> - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s\nREDACTED -o -` (dns block)\n>\n> If you need me to access, download, or install something from one of\nthese locations, you can either:\n>\n> - Configure [Actions setup\nsteps](https://gh.io/copilot/actions-setup-steps) to set up my\nenvironment, which run before the firewall is enabled\n> - Add the appropriate URLs or hosts to the custom allowlist in this\nrepository's [Copilot coding agent\nsettings](https://github.com/elastic/kibana/settings/copilot/coding_agent)\n(admins only)\n>\n> </details>\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>","sha":"cc0eea1826d9f73cb04ca2188477f843f325d932"}},"sourceBranch":"main","suggestedTargetBranches":["9.4","9.3"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/262744","number":262744,"mergeCommit":{"message":"Add `aria-hidden` to decorative `EuiIcon` components in ES|QL files (#262744)\n\nCloses: https://github.com/elastic/kibana/issues/262712\n\nFixes 3 `@elastic/eui/icon-accessibility-rules` lint violations across\n`@elastic/kibana-esql` files. All three icons are decorative (adjacent\ntext already conveys meaning), so `aria-hidden={true}` is the correct\nfix.\n\n- **`errors_warnings_popover.tsx`** — error/warning icon next to \"Line\nN\" text\n- **`column_header_renderer.tsx`** — plus icon next to \"Add a field…\"\nlabel\n- **`data_grid.tsx`** — Discover app icon inside \"Open in Discover\" link\n\nCloses #224193\n\n> [!WARNING]\n>\n> <details>\n> <summary>Firewall rules blocked me from connecting to one or more\naddresses (expand for details)</summary>\n>\n> #### I tried to connect to the following addresses, but was blocked by\nfirewall rules:\n>\n> - `ci-stats.kibana.dev`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\nscripts/yarn_install_scripts.js run ldd 0.8.2` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap --no-validate s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1 t }\n }\n{ printf "%s%s", sep, --compressed /ldd get --global t ldd\ns/li\u0004\u0018` (dns block)\n> - `clients3.google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `detectportal.firefox.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd b/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd s/li\u0004\u0018\nt/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git\nv22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global\ncal/bin/git ldd nibr\u0004\u0018` (dns block)\n> - `googlechromelabs.github.io`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js\nk/_temp/ghcca-node/node/bin/git ldd b/li\u0004\u0018` (dns block)\n> - `iojs.org`\n> - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s\nREDACTED -o -` (dns block)\n>\n> If you need me to access, download, or install something from one of\nthese locations, you can either:\n>\n> - Configure [Actions setup\nsteps](https://gh.io/copilot/actions-setup-steps) to set up my\nenvironment, which run before the firewall is enabled\n> - Add the appropriate URLs or hosts to the custom allowlist in this\nrepository's [Copilot coding agent\nsettings](https://github.com/elastic/kibana/settings/copilot/coding_agent)\n(admins only)\n>\n> </details>\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>","sha":"cc0eea1826d9f73cb04ca2188477f843f325d932"}},{"branch":"9.3","label":"v9.3.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
michel-laterman
pushed a commit
to michel-laterman/kibana
that referenced
this pull request
Apr 13, 2026
…lastic#262744) Closes: elastic#262712 Fixes 3 `@elastic/eui/icon-accessibility-rules` lint violations across `@elastic/kibana-esql` files. All three icons are decorative (adjacent text already conveys meaning), so `aria-hidden={true}` is the correct fix. - **`errors_warnings_popover.tsx`** — error/warning icon next to "Line N" text - **`column_header_renderer.tsx`** — plus icon next to "Add a field…" label - **`data_grid.tsx`** — Discover app icon inside "Open in Discover" link Closes elastic#224193 > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `ci-stats.kibana.dev` > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/yarn_install_scripts.js run ldd 0.8.2` (dns block) > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap` (dns block) > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap --no-validate s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1 t } } { printf &elastic#34;%s%s&elastic#34;, sep, --compressed /ldd get --global t ldd s/li��` (dns block) > - `clients3.google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��` (dns block) > - `detectportal.firefox.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��` (dns block) > - `google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��` (dns block) > - `googlechromelabs.github.io` > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js k/_temp/ghcca-node/node/bin/git ldd b/li��` (dns block) > - `iojs.org` > - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/elastic/kibana/settings/copilot/coding_agent) (admins only) > > </details> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #262712
Fixes 3
@elastic/eui/icon-accessibility-ruleslint violations across@elastic/kibana-esqlfiles. All three icons are decorative (adjacent text already conveys meaning), soaria-hidden={true}is the correct fix.errors_warnings_popover.tsx— error/warning icon next to "Line N" textcolumn_header_renderer.tsx— plus icon next to "Add a field…" labeldata_grid.tsx— Discover app icon inside "Open in Discover" linkCloses #224193
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ci-stats.kibana.dev/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/yarn_install_scripts.js run ldd 0.8.2(dns block)/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap(dns block)/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap --no-validate s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1 t } } { printf "%s%s", sep, --compressed /ldd get --global t ldd s/li��(dns block)clients3.google.com/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��(dns block)/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��(dns block)detectportal.firefox.com/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��(dns block)/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��(dns block)google.com/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd b/li��(dns block)/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd s/li�� t/webkit-2272/minibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git v22.22.0/lib/node_modules/npm/bin/node-gyp-bin/ldd get --global cal/bin/git ldd nibr��(dns block)googlechromelabs.github.io/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js k/_temp/ghcca-node/node/bin/git ldd b/li��(dns block)iojs.org/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -(dns block)If you need me to access, download, or install something from one of these locations, you can either: