[6.x] [ML] Wrap controller initialization in assertions. (#26265)#26273
Merged
peteharverson merged 1 commit intoelastic:6.xfrom Nov 29, 2018
Merged
[6.x] [ML] Wrap controller initialization in assertions. (#26265)#26273peteharverson merged 1 commit intoelastic:6.xfrom
peteharverson merged 1 commit intoelastic:6.xfrom
Conversation
- The controller tests introduced in elastic#25382 had a flaw: If a controller initialization would fail and throw an error, that test suite wouldn't be able to clean up any stubs. So tests using the same stubs would report and error because the stubs couldn't be wrapped again. - This PR wraps every controller initialization inside an assertion and catches those errors properly as part of the test.
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💔 Build Failed |
Contributor
|
retest |
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.x: