[Osquery] FF Enabled for Osquery 9.4 rework #262693
Merged
tomsonpl merged 12 commits intoelastic:mainfrom Apr 13, 2026
Merged
Conversation
…8935) Do not merge. Testing CI and getting ready for GA. --------- Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Contributor
Author
|
/ci |
tomsonpl
added
release_note:skip
tomsonpl
changed the title
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
| }; | ||
|
|
||
| const casesOsqueryResultRegex = /attached Osquery results[\s]?[\d]+[\s]?second(?:s)? ago/; | ||
| export const viewRecentCaseAndCheckResults = () => { |
Contributor
There was a problem hiding this comment.
🟢 Low tasks/live_query.ts:169
viewRecentCaseAndCheckResults no longer calls checkResults(), so it asserts the regex pattern exists but does not wait for the results table to populate. This can cause subsequent assertions like cy.contains(liveQueryQuery) to execute before the data is ready, leading to test flakiness.
🤖 Copy this AI Prompt to have your agent fix this:
In file x-pack/platform/plugins/shared/osquery/cypress/tasks/live_query.ts around line 169:
`viewRecentCaseAndCheckResults` no longer calls `checkResults()`, so it asserts the regex pattern exists but does not wait for the results table to populate. This can cause subsequent assertions like `cy.contains(liveQueryQuery)` to execute before the data is ready, leading to test flakiness.
Evidence trail:
- x-pack/platform/plugins/shared/osquery/cypress/tasks/live_query.ts lines 169-172 (REVIEWED_COMMIT): `viewRecentCaseAndCheckResults` function that no longer calls `checkResults()`
- git_diff MERGE_BASE..REVIEWED_COMMIT on live_query.ts: shows `- checkResults();` was removed from `viewRecentCaseAndCheckResults`
- x-pack/platform/plugins/shared/osquery/cypress/tasks/live_query.ts lines 65-76 (REVIEWED_COMMIT): `checkResults()` function with 240000ms timeout and retry logic for data grid
- x-pack/platform/plugins/shared/osquery/cypress/e2e/all/cases.cy.ts lines 48-50 and 74-76: show `viewRecentCaseAndCheckResults()` followed by `cy.contains(liveQueryQuery)` assertions
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
elastic-vault-github-plugin-prod
Bot
requested a review
from a team
as a code owner
This reverts commit 1ec6abc.
szwarckonrad
approved these changes
Apr 13, 2026
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
4 tasks
tfcmarques
pushed a commit
to tfcmarques/kibana
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies the same changes as #258935 (merged directly to
9.4).