Skip to content

[EDR Workflow] Default Endpoint exception as Global when creating from Alerts page#262282

Merged
gergoabraham merged 5 commits intoelastic:mainfrom
gergoabraham:default-to-global-endpoint-exception-from-alerts-page
Apr 10, 2026
Merged

[EDR Workflow] Default Endpoint exception as Global when creating from Alerts page#262282
gergoabraham merged 5 commits intoelastic:mainfrom
gergoabraham:default-to-global-endpoint-exception-from-alerts-page

Conversation

@gergoabraham
Copy link
Copy Markdown
Contributor

@gergoabraham gergoabraham commented Apr 9, 2026

Summary

Note

After endpointExceptionsMovedUnderManagement FF is enabled, and after user has opted in to per-policy Endpoint exceptions...

...the Endpoint exception create form shows the Policy selector:
image

This should be defaulted to 'Global' when trying to create an Endpoint exception on the Alerts page:

  • to harmonize with historic behavior: so far Endpoint exceptions used to be always global,
  • to harmonize with Endpoint artifact pages: there we also default to global.

Screen recording

User with Global artifact management privilege

Screen.Recording.2026-04-09.at.15.12.35.mov

User without Global artifact management privilege

Screen.Recording.2026-04-09.at.15.15.39.mov

Note

actually this cannot be tested in this PR manually, because it is hidden behind another hidden bug: https://github.com/elastic/security-team/issues/16784
but the unit test shows the behavior

Todo

  • update backport labels in case 9.4 branch is cut

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@gergoabraham gergoabraham self-assigned this Apr 9, 2026
@gergoabraham gergoabraham requested a review from a team as a code owner April 9, 2026 13:27
@gergoabraham gergoabraham added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v9.4.0 labels Apr 9, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Copy Markdown
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean change! Small, well-scoped, and good test coverage for both privilege branches. Left one minor nit about defensive tag merging, but otherwise LGTM 👍

)[0] as CreateExceptionListItemSchema),

os_types: retrieveAlertOsTypes(alertData),
tags: canManageGlobalArtifacts ? [GLOBAL_ARTIFACT_TAG] : [],
Copy link
Copy Markdown
Contributor

@tomsonpl tomsonpl Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (non-blocking): The tags field here overwrites whatever defaultEndpointExceptionItems returns. Currently that's likely empty, but as a defensive measure you could mergeinstead of replace:

Suggested change
tags: canManageGlobalArtifacts ? [GLOBAL_ARTIFACT_TAG] : [],
tags: [
...(initialException.tags ?? []),
...(canManageGlobalArtifacts ? [GLOBAL_ARTIFACT_TAG] : []),
],

This way if defaultEndpointExceptionItems ever evolves to set tags, they won't be silently dropped.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a really good point, thanks. updated:
341184a

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #34 / serverless observability UI - ML and Discover discover/observabilitySolution/context_awareness extension getRowIndicatorProvider should render log.level row indicators on Surrounding documents page

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.7MB 11.7MB +276.0B

History

cc @gergoabraham

@gergoabraham gergoabraham merged commit d6a29fe into elastic:main Apr 10, 2026
17 checks passed
@gergoabraham gergoabraham deleted the default-to-global-endpoint-exception-from-alerts-page branch April 10, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants