[9.3] [Fix] Jest Tests.x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/components - FilterLabel should render properly (#262207)#262237
Merged
Conversation
…iew/public/components/shared/exploratory_view/components - FilterLabel should render properly (elastic#262207) Resolves elastic#253320 **Root cause:** Anti-pattern of nesting findByText (async, retries) inside waitFor (also retries). The FilterItem component re-renders due to injectI18n() being called inside the render function, which makes element references go stale between the findByText resolution and the toBeInTheDocument() check. **Fix:** Replaced with waitFor(() => { getByText... }) — synchronous assertions inside waitFor so all checks run atomically in one retry cycle. Removed the duplicate assertion and unskipped the test. Verified: 155/155 consecutive runs pass locally. (cherry picked from commit 6431ca5)
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💚 Build Succeeded
Metrics [docs]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:Questions ?
Please refer to the Backport tool documentation