Attempt to fix flaky Infra test#261465
Merged
Conversation
…yout was opened in the test before proceeding further - Added a `data-test-subj` attribute to the `EuiFlyout` in the Flyout component for improved testing capabilities. - Updated the InfraHostsView functional tests to check for the existence of the new `infraAssetDetailsFlyout` test subject, enhancing test coverage for the flyout functionality.
miloszmarcinkowski
added
the
release_note:skip
miloszmarcinkowski
added
the
backport:all-open
…ctional-ui-testsx-packsolutionsobservabilitytestfunctionalappsinfrahosts_viewts
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#11406[✅] x-pack/solutions/observability/test/functional/apps/infra/config.ts: 100/100 tests passed. |
miloszmarcinkowski
added
the
Team:obs-presentation
Contributor
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
Contributor
ApprovabilityVerdict: Would Approve This PR adds a test subject attribute to a flyout component and waits for it in a functional test to fix flakiness. The changes are test infrastructure only with no runtime behavior impact. Macroscope would have approved this PR. A repo admin can enable approvability here. |
AlejandroFrndz
approved these changes
Apr 8, 2026
Contributor
|
Starting backport for target branches: 8.19, 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/24140115139 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 8, 2026
Closes elastic#258194 ## Summary An attempt to fix flaky Infrastructure test by verifying if Host view flyout is opened before proceeding further with other steps. There wasn't reliable way to replicate the flakiness on the local. Follow up on elastic#257997 ### How to test locally ``` node scripts/functional_tests_server --config x-pack/solutions/observability/test/functional/apps/infra/config.ts ``` ``` for i in $(seq 1 10); do echo "=== Run $i ===" node scripts/functional_test_runner \ --config x-pack/solutions/observability/test/functional/apps/infra/config.ts \ --grep "Dashboards Tab" \ || echo "FAILED on run $i" done ``` (cherry picked from commit fb8461f)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
miloszmarcinkowski
added
backport:version
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Apr 10, 2026
# Backport This will backport the following commits from `main` to `9.3`: - [Attempt to fix flaky Infra test (#261465)](#261465) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Miłosz Marcinkowski","email":"38698566+miloszmarcinkowski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-04-08T14:14:15Z","message":"Attempt to fix flaky Infra test (#261465)\n\nCloses #258194\n\n## Summary\n\nAn attempt to fix flaky Infrastructure test by verifying if Host view\nflyout is opened before proceeding further with other steps. There\nwasn't reliable way to replicate the flakiness on the local. Follow up\non #257997\n\n### How to test locally\n```\nnode scripts/functional_tests_server --config x-pack/solutions/observability/test/functional/apps/infra/config.ts\n```\n\n```\nfor i in $(seq 1 10); do\n echo \"=== Run $i ===\"\n node scripts/functional_test_runner \\\n --config x-pack/solutions/observability/test/functional/apps/infra/config.ts \\\n --grep \"Dashboards Tab\" \\\n || echo \"FAILED on run $i\"\ndone\n```","sha":"fb8461fdcbf6f9bfdb63eb8d4e9c814a65c62b5e","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v9.4.0","Team:obs-presentation"],"title":"Attempt to fix flaky Infra test","number":261465,"url":"https://github.com/elastic/kibana/pull/261465","mergeCommit":{"message":"Attempt to fix flaky Infra test (#261465)\n\nCloses #258194\n\n## Summary\n\nAn attempt to fix flaky Infrastructure test by verifying if Host view\nflyout is opened before proceeding further with other steps. There\nwasn't reliable way to replicate the flakiness on the local. Follow up\non #257997\n\n### How to test locally\n```\nnode scripts/functional_tests_server --config x-pack/solutions/observability/test/functional/apps/infra/config.ts\n```\n\n```\nfor i in $(seq 1 10); do\n echo \"=== Run $i ===\"\n node scripts/functional_test_runner \\\n --config x-pack/solutions/observability/test/functional/apps/infra/config.ts \\\n --grep \"Dashboards Tab\" \\\n || echo \"FAILED on run $i\"\ndone\n```","sha":"fb8461fdcbf6f9bfdb63eb8d4e9c814a65c62b5e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/261465","number":261465,"mergeCommit":{"message":"Attempt to fix flaky Infra test (#261465)\n\nCloses #258194\n\n## Summary\n\nAn attempt to fix flaky Infrastructure test by verifying if Host view\nflyout is opened before proceeding further with other steps. There\nwasn't reliable way to replicate the flakiness on the local. Follow up\non #257997\n\n### How to test locally\n```\nnode scripts/functional_tests_server --config x-pack/solutions/observability/test/functional/apps/infra/config.ts\n```\n\n```\nfor i in $(seq 1 10); do\n echo \"=== Run $i ===\"\n node scripts/functional_test_runner \\\n --config x-pack/solutions/observability/test/functional/apps/infra/config.ts \\\n --grep \"Dashboards Tab\" \\\n || echo \"FAILED on run $i\"\ndone\n```","sha":"fb8461fdcbf6f9bfdb63eb8d4e9c814a65c62b5e"}}]}] BACKPORT--> Co-authored-by: Miłosz Marcinkowski <38698566+miloszmarcinkowski@users.noreply.github.com>
kibanamachine
added
v9.3.4
and removed
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258194
Summary
An attempt to fix flaky Infrastructure test by verifying if Host view flyout is opened before proceeding further with other steps. There wasn't reliable way to replicate the flakiness on the local. Follow up on #257997
How to test locally