Skip to content

[6.x] fix(NA): prettier throw rule error ocurring on master. (#26071) #26129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mistic merged 1 commit into from
Nov 23, 2018
Merged

[6.x] fix(NA): prettier throw rule error ocurring on master. (#26071) #26129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 25 additions & 24 deletions x-pack/plugins/spaces/public/views/management/edit_space/space_identifier.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,7 @@
* you may not use this file except in compliance with the Elastic License.
*/

import {
EuiFieldText,
EuiFormRow,
EuiLink,
} from '@elastic/eui';
import { EuiFieldText, EuiFormRow, EuiLink } from '@elastic/eui';
import { FormattedMessage, InjectedIntl, injectI18n } from '@kbn/i18n/react';
import React, { ChangeEvent, Component, Fragment } from 'react';
import { Space } from '../../../../common/model/space';
Expand All @@ -27,7 +23,6 @@ interface State {
}

class SpaceIdentifierUI extends Component<Props, State> {

private textFieldRef: HTMLInputElement | null = null;

constructor(props: Props) {
Expand All @@ -39,9 +34,7 @@ class SpaceIdentifierUI extends Component<Props, State> {

public render() {
const { intl } = this.props;
const {
id = ''
} = this.props.space;
const { id = '' } = this.props.space;

return (
<Fragment>
Expand All @@ -64,7 +57,7 @@ class SpaceIdentifierUI extends Component<Props, State> {
}
value={id}
onChange={this.onChange}
inputRef={(ref) => this.textFieldRef = ref}
inputRef={ref => (this.textFieldRef = ref)}
fullWidth
/>
</EuiFormRow>
Expand All @@ -75,12 +68,13 @@ class SpaceIdentifierUI extends Component<Props, State> {
public getLabel = () => {
if (!this.props.editable) {
return (
<p>
<FormattedMessage
id="xpack.spaces.management.spaceIdentifier.urlIdentifierTitle"
defaultMessage="URL identifier"
/>
</p>);
<p>
<FormattedMessage
id="xpack.spaces.management.spaceIdentifier.urlIdentifierTitle"
defaultMessage="URL identifier"
/>
</p>
);
}

const editLinkText = this.state.editing ? (
Expand Down Expand Up @@ -124,7 +118,9 @@ class SpaceIdentifierUI extends Component<Props, State> {
nextLine: <br />,
engineeringKibanaUrl: (
<React.Fragment>
https://my-kibana.example<strong>/s/engineering/</strong>app/kibana
{`https://my-kibana.example`}
<strong>/s/engineering/</strong>
app/kibana
</React.Fragment>
),
}}
Expand All @@ -134,17 +130,22 @@ class SpaceIdentifierUI extends Component<Props, State> {
};

public onEditClick = () => {
this.setState({
editing: !this.state.editing
}, () => {
if (this.textFieldRef && this.state.editing) {
this.textFieldRef.focus();
this.setState(
{
editing: !this.state.editing,
},
() => {
if (this.textFieldRef && this.state.editing) {
this.textFieldRef.focus();
}
}
});
);
};

public onChange = (e: ChangeEvent<HTMLInputElement>) => {
if (!this.state.editing) { return; }
if (!this.state.editing) {
return;
}
this.props.onChange(e);
};
}
Expand Down