Fix quotes in kbn-i18n build scripts#26120
Merged
spalger merged 1 commit intoelastic:masterfrom Nov 23, 2018
Merged
Conversation
LeanidShutau
added
bug
Contributor
|
Pinging @elastic/kibana-platform |
LeanidShutau
added
v6.5.2
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations |
LeanidShutau
removed
the
Team:Core
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 23, 2018
**Bug**
`packages/kbn-i18n/package.json`:
```
...
scripts: {
"kbn:bootstrap": "run-p 'build:babel:** --quiet' build:tsc",
"kbn:watch": "run-p 'build:** --watch'",
},
...
```
These commands throw errors on Windows because of wrong command line arguments parsing (`'build:babel:**`, `--quiet'` and `build:tsc`):
```
@kbn/i18n: $ run-p 'build:babel:** --quiet' build:tsc
× @kbn/i18n: ERROR: Invalid Option: --quiet'
```
So `yarn kbn bootstrap` fails on Windows
**Fix**
Use cross-platform escaped double quotes instead of single quotes:
```
...
scripts: {
"kbn:bootstrap": "run-p \"build:babel:** --quiet\" build:tsc",
"kbn:watch": "run-p \"build:** --watch\"",
},
...
```
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 23, 2018
**Bug**
`packages/kbn-i18n/package.json`:
```
...
scripts: {
"kbn:bootstrap": "run-p 'build:babel:** --quiet' build:tsc",
"kbn:watch": "run-p 'build:** --watch'",
},
...
```
These commands throw errors on Windows because of wrong command line arguments parsing (`'build:babel:**`, `--quiet'` and `build:tsc`):
```
@kbn/i18n: $ run-p 'build:babel:** --quiet' build:tsc
× @kbn/i18n: ERROR: Invalid Option: --quiet'
```
So `yarn kbn bootstrap` fails on Windows
**Fix**
Use cross-platform escaped double quotes instead of single quotes:
```
...
scripts: {
"kbn:bootstrap": "run-p \"build:babel:** --quiet\" build:tsc",
"kbn:watch": "run-p \"build:** --watch\"",
},
...
```
Contributor
💚 Build Succeeded |
spalger
pushed a commit
that referenced
this pull request
Nov 23, 2018
**Bug**
`packages/kbn-i18n/package.json`:
```
...
scripts: {
"kbn:bootstrap": "run-p 'build:babel:** --quiet' build:tsc",
"kbn:watch": "run-p 'build:** --watch'",
},
...
```
These commands throw errors on Windows because of wrong command line arguments parsing (`'build:babel:**`, `--quiet'` and `build:tsc`):
```
@kbn/i18n: $ run-p 'build:babel:** --quiet' build:tsc
× @kbn/i18n: ERROR: Invalid Option: --quiet'
```
So `yarn kbn bootstrap` fails on Windows
**Fix**
Use cross-platform escaped double quotes instead of single quotes:
```
...
scripts: {
"kbn:bootstrap": "run-p \"build:babel:** --quiet\" build:tsc",
"kbn:watch": "run-p \"build:** --watch\"",
},
...
```
spalger
pushed a commit
that referenced
this pull request
Nov 23, 2018
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
packages/kbn-i18n/package.json:These commands throw errors on Windows because of wrong command line arguments parsing (
'build:babel:**,--quiet'andbuild:tsc):So
yarn kbn bootstrapfails on WindowsFix
Use cross-platform escaped double quotes instead of single quotes: