Skip to content

[Lens] Add Primary metric position: 'middle' for Metric chart #260902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awahab07 merged 2 commits into from
Apr 7, 2026
Merged

[Lens] Add Primary metric position: 'middle' for Metric chart #260902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f531847
Add value position 'middle' for primary metric chart.
awahab07 Apr 2, 2026
8d322f4
Merge branch 'main' into 234956_Lens_Metric_Allow-Middle-Center-Align…
awahab07 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ed/chart_expressions/expression_metric/common/expression_functions/metric_vis_function.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const metricVisFunction = (): MetricVisExpressionFunctionDefinition => ({
primaryPosition: {
types: ['string'],
help: i18n.translate('expressionMetricVis.function.primaryPosition.help', {
defaultMessage: 'The postion of the Primary Metric (top or bottom).',
defaultMessage: 'The position of the Primary Metric (top, middle, or bottom).',
}),
},
titleWeight: {
Expand Down
4 changes: 4 additions & 0 deletions ...orm/plugins/shared/lens/public/visualizations/metric/toolbar/appearance_settings.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,11 @@ describe('appearance settings', () => {

it.each<[PrimaryMetricPosition, string, PrimaryMetricPosition, string]>([
['top', 'Top', 'bottom', 'Bottom'],
['middle', 'Middle', 'bottom', 'Bottom'],
['bottom', 'Bottom', 'top', 'Top'],
['bottom', 'Bottom', 'middle', 'Middle'],
['middle', 'Middle', 'top', 'Top'],
['top', 'Top', 'middle', 'Middle'],
])(
'should set default config when changing from %j (%s) to %j (%s)',
(newPosition, newLabel, prevPosition, prevLabel) => {
Expand Down
6 changes: 6 additions & 0 deletions ...platform/plugins/shared/lens/public/visualizations/metric/toolbar/appearance_settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,12 @@ const primaryMetricPositionOptions: Array<
defaultMessage: 'Top',
}),
},
{
id: 'middle',
label: i18n.translate('xpack.lens.metric.appearancePopover.middle', {
defaultMessage: 'Middle',
}),
},
{
id: 'bottom',
label: i18n.translate('xpack.lens.metric.appearancePopover.bottom', {
Expand Down
Loading