Update naming of functions to make state ownership clearer.#260839
Closed
ThomThomson wants to merge 13 commits into
Closed
Update naming of functions to make state ownership clearer.#260839ThomThomson wants to merge 13 commits into
ThomThomson wants to merge 13 commits into
Conversation
Renamed and changed types for unsaved changes blurp
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
Author
|
/ci |
ThomThomson
commented
Apr 10, 2026
| elasticAssistantSharedState: 4881 | ||
| elasticConsole: 4451 | ||
| embeddable: 16634 | ||
| embeddable: 19659 |
Contributor
Author
There was a problem hiding this comment.
I opted to update the limits here manually rather than async importing the function responsible for the increase. This is because the function is required for every embeddable on start up.
An async import of this function would require either an additional bundle, or placement of this function with another module that hosts unrelated code that isn't imported for every embeddable.
This function has been moved from a package import into the embeddable plugin.
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
⏳ Build in-progress, with failures
Failed CI Steps
Test Failures
History
|
Contributor
|
Replacing with #270270 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #260082.
The above PR made embeddables capable of "resetting" to any arbitrary state by moving "last saved state" based resetting into the Dashboard, and changing the related unsaved changes interfaces to take arguments for state to set.
This PR promotes that capability directly into the Embeddable framework and updates the naming of all related functionality. Embeddables no longer need to import and call
initializeUnsavedChangesand instead get this capability provided to them as an argument calledinitializeStateApi.