Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
cdaba94
remove custom settings for model selection and fallback to Model Sett…
achyutjhunjhunwala Apr 1, 2026
4fc95ee
Changed order for Discovery models
achyutjhunjhunwala Apr 1, 2026
12def90
Changes from node scripts/check_mappings_update --fix
kibanamachine Apr 1, 2026
cd46f52
Fixed missing core settings client
achyutjhunjhunwala Apr 1, 2026
6f30a7a
Merge branch 'main' into use-model-settings-inside-sig-event
achyutjhunjhunwala Apr 1, 2026
1e2bada
Remove unnecessary isLoading and error state
achyutjhunjhunwala Apr 1, 2026
5f91a36
Merge branch 'main' into use-model-settings-inside-sig-event
achyutjhunjhunwala Apr 1, 2026
ebcfef1
Fix CI build failures: update SO types count, tsconfig refs, and moon…
achyutjhunjhunwala Apr 1, 2026
f02e290
Merge branch 'main' into use-model-settings-inside-sig-event
achyutjhunjhunwala Apr 1, 2026
9e80af3
Register observability:streamsSigEventsIndexPatterns in management co…
achyutjhunjhunwala Apr 1, 2026
4d78c45
Add streams-significant-events-settings to removed saved object types
achyutjhunjhunwala Apr 1, 2026
63d0320
Fixed review comments from Marco
achyutjhunjhunwala Apr 2, 2026
25edd37
Fix incorrect update of text
achyutjhunjhunwala Apr 2, 2026
32e9c27
Merge branch 'main' into use-model-settings-inside-sig-event
achyutjhunjhunwala Apr 2, 2026
04bddb9
Fix macroscope and external review comments
achyutjhunjhunwala Apr 2, 2026
26575bb
Changes from node scripts/check_mappings_update --fix
kibanamachine Apr 2, 2026
f7ea592
Merge branch 'main' into use-model-settings-inside-sig-event
achyutjhunjhunwala Apr 2, 2026
4660a69
Fix review comments from the team-reviewer-claude
achyutjhunjhunwala Apr 2, 2026
f90c53c
Revert message as pointed by review bot
achyutjhunjhunwala Apr 2, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/kbn-check-saved-objects-cli/current_fields.json
Original file line number Diff line number Diff line change
Expand Up @@ -1341,7 +1341,6 @@
],
"spaces-usage-stats": [],
"stream-prompts": [],
"streams-significant-events-settings": [],
"synthetics-dynamic-settings": [],
"synthetics-monitor": [
"alert",
Expand Down
4 changes: 0 additions & 4 deletions packages/kbn-check-saved-objects-cli/current_mappings.json
Original file line number Diff line number Diff line change
Expand Up @@ -4402,10 +4402,6 @@
"dynamic": false,
"properties": {}
},
"streams-significant-events-settings": {
"dynamic": false,
"properties": {}
},
"synthetics-dynamic-settings": {
"dynamic": false,
"properties": {}
Expand Down
1 change: 1 addition & 0 deletions packages/kbn-check-saved-objects-cli/removed_types.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"osquery-usage-metric",
"server",
"siem-detection-engine-rule-execution-info",
"streams-significant-events-settings",
"siem-detection-engine-rule-status",
"timelion-sheet",
"tsvb-validation-telemetry",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,6 @@ export const REMOVED_TYPES: string[] = [
// Removed in 9.1 https://github.com/elastic/kibana/pull/231084
'guided-onboarding-guide-state',
'guided-onboarding-plugin-state',
// Removed in 9.4 https://github.com/elastic/kibana/pull/260741
'streams-significant-events-settings',
].sort();
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ export { registerCoreObjectTypes } from './registration';

// set minimum number of registered saved objects to ensure no object types are removed after 8.8
// declared in internal implementation explicitly to prevent unintended changes.
export const SAVED_OBJECT_TYPES_COUNT = 155 as const;
export const SAVED_OBJECT_TYPES_COUNT = 154 as const;
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ describe('checking migration metadata changes on all registered SO types', () =>
"space": "a3792f667888f8a976a742c941bd6db28d027604eccc854986a5ec2515f44483",
"spaces-usage-stats": "f692e8d75a0ac9187bfbf237e1b5aa6f9a028cf5569a3df2f9e0e96e625b6215",
"stream-prompts": "25d761054f4e6c60362ef73da19e1bee4c22bcf79e858bdb11ef3eb7f433c66c",
"streams-significant-events-settings": "698cd5c78851582ab24fa131b9c44be69f1f8c27e79ee0d7cbb07d30d66550e8",
"synthetics-dynamic-settings": "30883b9647f119e1d4529f49bc0fee459c56f62489993cd7f2397ffcb8608e63",
"synthetics-monitor": "19af677892a5eac45b3d1903c083cb222d8898d69ee545eaf079522b0bbbb85b",
"synthetics-monitor-multi-space": "9159e968b4c011ee11fe7887572e883e0928c4b4b0924d672c77003cfdf01fe0",
Expand Down Expand Up @@ -1234,10 +1233,6 @@ describe('checking migration metadata changes on all registered SO types', () =>
"stream-prompts|10.2.0: a79e6825ccd534ba98f6b8ce45357da62f162efe3fbad1d0c2c7d3c0f8d1e48c",
"stream-prompts|10.1.0: ba35cffdf735265c1b4bc2652c4ea22c74e81fafb58a5c67eba53a4ec3e821bc",
"=======================================================================================",
"streams-significant-events-settings|global: 4ed764f62f5d97deb97b50db2c41718ffd13b391",
"streams-significant-events-settings|mappings: e1b10e5bec060a176469a5e9a4f80c94e23abcd7",
"streams-significant-events-settings|schemas: da39a3ee5e6b4b0d3255bfef95601890afd80709",
"=====================================================================================",
"synthetics-dynamic-settings|global: 79542e96ca9347188221391c3c7157ee5e8daefc",
"synthetics-dynamic-settings|mappings: e1b10e5bec060a176469a5e9a4f80c94e23abcd7",
"synthetics-dynamic-settings|schemas: da39a3ee5e6b4b0d3255bfef95601890afd80709",
Expand Down Expand Up @@ -1530,7 +1525,6 @@ describe('checking migration metadata changes on all registered SO types', () =>
"space": "10.2.0",
"spaces-usage-stats": "10.0.0",
"stream-prompts": "10.3.0",
"streams-significant-events-settings": "10.0.0",
"synthetics-dynamic-settings": "10.0.0",
"synthetics-monitor": "10.2.0",
"synthetics-monitor-multi-space": "10.0.0",
Expand Down Expand Up @@ -1695,7 +1689,6 @@ describe('checking migration metadata changes on all registered SO types', () =>
"space": "10.2.0",
"spaces-usage-stats": "7.14.1",
"stream-prompts": "10.3.0",
"streams-significant-events-settings": "0.0.0",
"synthetics-dynamic-settings": "0.0.0",
"synthetics-monitor": "10.2.0",
"synthetics-monitor-multi-space": "10.0.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ export const OBSERVABILITY_STREAMS_ENABLE_ATTACHMENTS = 'observability:streamsEn
export const OBSERVABILITY_STREAMS_ENABLE_WIRED_STREAM_VIEWS =
'observability:streamsEnableWiredStreamViews';
export const OBSERVABILITY_STREAMS_ENABLE_OVERVIEW_PAGE = 'observability:streamsEnableOverviewPage';
export const OBSERVABILITY_STREAMS_SIG_EVENTS_INDEX_PATTERNS =
'observability:streamsSigEventsIndexPatterns';
export const OBSERVABILITY_ENABLE_DIAGNOSTIC_MODE = 'observability:enableDiagnosticMode';

// Reporting settings
Expand Down
Comment thread
macroscopeapp[bot] marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,13 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
description: 'Enable the Streams management Overview tab',
},
},
'observability:streamsSigEventsIndexPatterns': {
type: 'keyword',
_meta: {
description:
'Comma-separated index patterns used for Significant Events stream filtering and analysis.',
},
},
'observability:enableDiagnosticMode': {
type: 'boolean',
_meta: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ export interface UsageStats {
'observability:streamsEnableQueryStreams': boolean;
'observability:streamsEnableWiredStreamViews': boolean;
'observability:streamsEnableOverviewPage': boolean;
'observability:streamsSigEventsIndexPatterns': string;
'securitySolution:entityStoreEnableV2': boolean;
'elasticConsole:enabled': boolean;
}
Original file line number Diff line number Diff line change
Expand Up @@ -11642,6 +11642,12 @@
"description": "Enable the Streams management Overview tab"
}
},
"observability:streamsSigEventsIndexPatterns": {
"type": "keyword",
"_meta": {
"description": "Comma-separated index patterns used for Significant Events stream filtering and analysis."
}
},
"observability:enableDiagnosticMode": {
"type": "boolean",
"_meta": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
import type { Client } from '@elastic/elasticsearch';
import type { ToolingLog } from '@kbn/tooling-log';
import type { Feature } from '@kbn/streams-schema';
import {
STREAMS_SIG_EVENTS_KI_EXTRACTION_INFERENCE_FEATURE_ID,
STREAMS_SIG_EVENTS_KI_QUERY_GENERATION_INFERENCE_FEATURE_ID,
STREAMS_SIG_EVENTS_DISCOVERY_INFERENCE_FEATURE_ID,
} from '@kbn/streams-schema';
import type { ConnectionConfig } from './get_connection_config';
import { kibanaRequest } from './kibana';
import {
Expand Down Expand Up @@ -52,22 +57,35 @@ export async function configureModelSelectionSettings(
log: ToolingLog,
connectorId: string
): Promise<void> {
log.info(`Configuring model selection (connector: ${connectorId})...`);
log.info(`Configuring model override via inference settings (connector: ${connectorId})...`);
const { status, data } = await kibanaRequest(
config,
'PUT',
'/internal/streams/_significant_events/settings',
{ connectorIdKnowledgeIndicatorExtraction: connectorId }
'/internal/search_inference_endpoints/settings',
{
features: [
{
feature_id: STREAMS_SIG_EVENTS_KI_EXTRACTION_INFERENCE_FEATURE_ID,
endpoints: [{ id: connectorId }],
},
{
feature_id: STREAMS_SIG_EVENTS_KI_QUERY_GENERATION_INFERENCE_FEATURE_ID,
endpoints: [{ id: connectorId }],
},
{
feature_id: STREAMS_SIG_EVENTS_DISCOVERY_INFERENCE_FEATURE_ID,
endpoints: [{ id: connectorId }],
},
],
}
);

if (status >= 200 && status < 300) {
log.info('Model selection settings configured');
log.info('Model selection settings configured via inference settings');
return;
}

throw new Error(
`Failed to configure model selection settings: ${status} ${JSON.stringify(data)}`
);
throw new Error(`Failed to configure inference settings: ${status} ${JSON.stringify(data)}`);
}
export async function triggerSigEventsKIFeatureExtraction(
config: ConnectionConfig,
Expand Down
23 changes: 23 additions & 0 deletions x-pack/platform/plugins/shared/streams/server/feature_flags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ import {
OBSERVABILITY_STREAMS_ENABLE_QUERY_STREAMS,
OBSERVABILITY_STREAMS_ENABLE_WIRED_STREAM_VIEWS,
OBSERVABILITY_STREAMS_ENABLE_OVERVIEW_PAGE,
OBSERVABILITY_STREAMS_SIG_EVENTS_INDEX_PATTERNS,
} from '@kbn/management-settings-ids';
import { DEFAULT_INDEX_PATTERNS } from '@kbn/streams-schema';
import type { StreamsPluginStartDependencies } from './types';
import { STREAMS_TIERED_SIGNIFICANT_EVENT_FEATURE } from '../common';

Expand Down Expand Up @@ -46,6 +48,27 @@ export function registerFeatureFlags(
},
});

core.uiSettings.register({
[OBSERVABILITY_STREAMS_SIG_EVENTS_INDEX_PATTERNS]: {
category: ['observability'],
name: i18n.translate('xpack.streams.sigEventsIndexPatternsSettingsName', {
defaultMessage: 'Significant Events index patterns',
}) as string,
value: DEFAULT_INDEX_PATTERNS,
description: i18n.translate('xpack.streams.sigEventsIndexPatternsSettingsDescription', {
defaultMessage:
'Comma-separated list of index patterns used for Significant Events stream filtering and analysis.',
}),
type: 'string',
schema: schema.string(),
requiresPageReload: false,
solutionViews: ['classic', 'oblt'],
technicalPreview: true,
readonly: true,
readonlyMode: 'ui',
},
});

core.uiSettings.register({
[OBSERVABILITY_STREAMS_ENABLE_SIGNIFICANT_EVENTS_DISCOVERY]: {
category: ['observability'],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@
import type { SavedObjectsServiceSetup } from '@kbn/core/server';

import { getStreamsPromptsSavedObject } from '../sig_events/saved_objects/prompts_config';
import { getStreamsSignificantEventsSettingsSavedObject } from '../sig_events/saved_objects/model_settings_config';

export const registerStreamsSavedObjects = (savedObjectsService: SavedObjectsServiceSetup) => {
savedObjectsService.registerType(getStreamsPromptsSavedObject());
savedObjectsService.registerType(getStreamsSignificantEventsSettingsSavedObject());
};

This file was deleted.

This file was deleted.

Loading
Loading