-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[SigEvents] Remove custom model selection, migrate index patterns to uiSettings #260741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
achyutjhunjhunwala
merged 19 commits into
elastic:main
from
achyutjhunjhunwala:use-model-settings-inside-sig-event
Apr 2, 2026
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
cdaba94
remove custom settings for model selection and fallback to Model Sett…
achyutjhunjhunwala 4fc95ee
Changed order for Discovery models
achyutjhunjhunwala 12def90
Changes from node scripts/check_mappings_update --fix
kibanamachine cd46f52
Fixed missing core settings client
achyutjhunjhunwala 6f30a7a
Merge branch 'main' into use-model-settings-inside-sig-event
achyutjhunjhunwala 1e2bada
Remove unnecessary isLoading and error state
achyutjhunjhunwala 5f91a36
Merge branch 'main' into use-model-settings-inside-sig-event
achyutjhunjhunwala ebcfef1
Fix CI build failures: update SO types count, tsconfig refs, and moon…
achyutjhunjhunwala f02e290
Merge branch 'main' into use-model-settings-inside-sig-event
achyutjhunjhunwala 9e80af3
Register observability:streamsSigEventsIndexPatterns in management co…
achyutjhunjhunwala 4d78c45
Add streams-significant-events-settings to removed saved object types
achyutjhunjhunwala 63d0320
Fixed review comments from Marco
achyutjhunjhunwala 25edd37
Fix incorrect update of text
achyutjhunjhunwala 32e9c27
Merge branch 'main' into use-model-settings-inside-sig-event
achyutjhunjhunwala 04bddb9
Fix macroscope and external review comments
achyutjhunjhunwala 26575bb
Changes from node scripts/check_mappings_update --fix
kibanamachine f7ea592
Merge branch 'main' into use-model-settings-inside-sig-event
achyutjhunjhunwala 4660a69
Fix review comments from the team-reviewer-claude
achyutjhunjhunwala f90c53c
Revert message as pointed by review bot
achyutjhunjhunwala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 0 additions & 65 deletions
65
...orm/plugins/shared/streams/server/lib/sig_events/helpers/get_configured_index_patterns.ts
This file was deleted.
Oops, something went wrong.
41 changes: 0 additions & 41 deletions
41
...tform/plugins/shared/streams/server/lib/sig_events/saved_objects/model_settings_config.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.