Fix prettier throw rule error #26071
Merged
mistic merged 1 commit intoelastic:masterfrom Nov 23, 2018
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-operations |
Contributor
💚 Build Succeeded |
spalger
approved these changes
Nov 22, 2018
Contributor
spalger
left a comment
There was a problem hiding this comment.
I'm not sure which part of this fixes something, but I think this looks good to me.
Contributor
Author
|
@spalger this solution for the issue is being discussed here 😃 |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Nov 23, 2018
mistic
added a commit
that referenced
this pull request
Nov 23, 2018
Contributor
Author
|
6.x: 696a4de |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small PR in order to fix an error I'm watching a lot of times when merging with last master and running the pre-commit hook. The output of the error is the following:
This is happening due to a known bug on
prettierand this PR solved the line that is causing the problem without changing the behaviour and the logic of it.PS: I have also ran
node scripts/tslint --fixover this file to fix a lot of errors that appear on it, after I solved the prettier problem.