[8.19] Remove --no-experimental-require-module from node.options (#256379)

.buildkite/scripts/steps/test/jest_parallel.sh

@@ -60,7 +60,7 @@ while read -r config; do
   # --trace-warnings to debug
   # Node.js process-warning detected:
   # Warning: Closing file descriptor 24 on garbage collection
-  cmd="NODE_OPTIONS=\"--max-old-space-size=12288 --trace-warnings --no-experimental-require-module"
+  cmd="NODE_OPTIONS=\"--max-old-space-size=12288 --trace-warnings"
 
   if [[ "${TEST_ENABLE_FIPS_VERSION:-}" == "140-2" ]] || [[ "${TEST_ENABLE_FIPS_VERSION:-}" == "140-3" ]] ; then
     cmd=$cmd" --enable-fips --openssl-config=$HOME/nodejs.cnf"

config/node.options

@@ -13,6 +13,3 @@
 
 ## enable OpenSSL 3 legacy provider
 --openssl-legacy-provider
-
-## disable ES modules until stable
---no-experimental-require-module

package.json

@@ -39,33 +39,33 @@
   "author": "Rashid Khan <rashid.khan@elastic.co>",
   "scripts": {
     "backport-skip-ci": "backport --prDescription \"[skip-ci]\"",
-    "build": "node --no-experimental-require-module scripts/build --all-platforms",
-    "build:apidocs": "node --no-experimental-require-module scripts/build_api_docs",
-    "checkLicenses": "node --no-experimental-require-module scripts/check_licenses --dev",
-    "debug": "node --no-experimental-require-module --nolazy --inspect scripts/kibana --dev",
-    "debug-break": "node --no-experimental-require-module --nolazy --inspect-brk scripts/kibana --dev",
+    "build": "node scripts/build --all-platforms",
+    "build:apidocs": "node scripts/build_api_docs",
+    "checkLicenses": "node scripts/check_licenses --dev",
+    "debug": "node --nolazy --inspect scripts/kibana --dev",
+    "debug-break": "node --nolazy --inspect-brk scripts/kibana --dev",
     "dev-docs": "scripts/dev_docs.sh",
-    "es": "node --no-experimental-require-module scripts/es",
-    "preinstall": "node --no-experimental-require-module ./preinstall_check",
-    "kbn": "node --no-experimental-require-module scripts/kbn",
+    "es": "node scripts/es",
+    "preinstall": "node ./preinstall_check",
+    "kbn": "node scripts/kbn",
     "lint": "yarn run lint:es && yarn run lint:style",
-    "lint:es": "node --no-experimental-require-module scripts/eslint_all_files",
-    "lint:style": "node --no-experimental-require-module scripts/stylelint",
-    "makelogs": "node --no-experimental-require-module scripts/makelogs",
-    "quick-checks": "node --no-experimental-require-module scripts/quick_checks",
-    "serverless": "node --no-experimental-require-module scripts/kibana --dev --serverless",
-    "serverless-es": "node --no-experimental-require-module scripts/kibana --dev --serverless=es",
-    "serverless-oblt": "node --no-experimental-require-module scripts/kibana --dev --serverless=oblt",
-    "serverless-security": "node --no-experimental-require-module scripts/kibana --dev --serverless=security",
-    "spec_to_console": "node --no-experimental-require-module scripts/spec_to_console",
-    "start": "node --no-experimental-require-module scripts/kibana --dev",
-    "storybook": "node --no-experimental-require-module scripts/storybook",
-    "test:ftr": "node --no-experimental-require-module scripts/functional_tests",
-    "test:ftr:runner": "node --no-experimental-require-module scripts/functional_test_runner",
-    "test:ftr:server": "node --no-experimental-require-module scripts/functional_tests_server",
-    "test:jest": "node --no-experimental-require-module scripts/jest",
-    "test:jest_integration": "node --no-experimental-require-module scripts/jest_integration",
-    "test:type_check": "node --no-experimental-require-module scripts/type_check"
+    "lint:es": "node scripts/eslint_all_files",
+    "lint:style": "node scripts/stylelint",
+    "makelogs": "node scripts/makelogs",
+    "quick-checks": "node scripts/quick_checks",
+    "serverless": "node scripts/kibana --dev --serverless",
+    "serverless-es": "node scripts/kibana --dev --serverless=es",
+    "serverless-oblt": "node scripts/kibana --dev --serverless=oblt",
+    "serverless-security": "node scripts/kibana --dev --serverless=security",
+    "spec_to_console": "node scripts/spec_to_console",
+    "start": "node scripts/kibana --dev",
+    "storybook": "node scripts/storybook",
+    "test:ftr": "node scripts/functional_tests",
+    "test:ftr:runner": "node scripts/functional_test_runner",
+    "test:ftr:server": "node scripts/functional_tests_server",
+    "test:jest": "node scripts/jest",
+    "test:jest_integration": "node scripts/jest_integration",
+    "test:type_check": "node scripts/type_check"
   },
   "repository": {
     "type": "git",

src/cli/kibana/dev.js

@@ -7,12 +7,6 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-if (process.features.require_module) {
-  console.warn(
-    "Node.js's experimental support for native ES modules is enabled.  This will not be enabled in production while the feature is experimental.  It is recommended to add `--no-experimental-require-module` to NODE_OPTIONS."
-  );
-}
-
 require('@kbn/setup-node-env');
 require('./apm')(process.env.ELASTIC_APM_SERVICE_NAME || 'kibana-proxy');
 require('./cli');