[9.3] Fix yarn.lock v1 parser for compound package alias headers (#259640)#260060
Closed
tylersmalley wants to merge 1 commit intoelastic:9.3from
Closed
[9.3] Fix yarn.lock v1 parser for compound package alias headers (#259640)#260060tylersmalley wants to merge 1 commit intoelastic:9.3from
tylersmalley wants to merge 1 commit intoelastic:9.3from
Conversation
…59640) ## Summary Fixes `extract-version-dependencies` failing with `Unable to resolve d3-color@1 - 2 from yarn.lock dependency graph` when Yarn merges multiple lockfile descriptors (aliases) into a single block. ## Changes - **`yarn_lock_v1.ts`**: Parse each comma-separated header descriptor with correct scoped vs unscoped `@` splitting; register `PackageInfo` per alias; merge `requestedVersions` for duplicate `name@resolvedVersion` keys. In `focus` mode, include a block if any alias matches. - **`yarn_lock_v1.test.ts`**: Regression test for compound headers. - **`yarn.lock`**: Refreshed merged descriptor lines (e.g. `d3-color` / `@elastic/kibana-d3-color`, `ajv` / `@redocly/ajv`). - **`version_dependencies.txt`**: Regenerated via `extract-version-dependencies`. ## Testing - `node scripts/jest src/dev/yarn/yarn_lock_v1.test.ts` - `moon run @kbn/ui-shared-deps-npm:extract-version-dependencies` - `node scripts/check_changes.ts` Made with [Cursor](https://cursor.com) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit c82b6d4)
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:Questions ?
Please refer to the Backport tool documentation