Skip to content

[dashboards as code] rename lens and visualization embeddable types#260040

Merged
nreese merged 52 commits into
elastic:mainfrom
nreese:rename_lens_to_vis
Apr 8, 2026
Merged

[dashboards as code] rename lens and visualization embeddable types#260040
nreese merged 52 commits into
elastic:mainfrom
nreese:rename_lens_to_vis

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Mar 27, 2026

Closes #245192
Closes #260493

Note: Opening for view before getting green CI to get reviews in from external teams. CI issues with lens that will be resolved in #250115

In screen shot, notice how lens embeddables are returned from REST API with vis type. Same applies for visualization embeddables, they are now returned with legacy_vis type
Screenshot 2026-03-27 at 2 48 46 PM

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 27, 2026

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 27, 2026

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 27, 2026

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 27, 2026

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 27, 2026

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 30, 2026

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 30, 2026

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 30, 2026

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 30, 2026

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 31, 2026

/ci

@nreese nreese changed the title [dashboards as code] rename lens to vis and visualization to legacy_vis [dashboards as code] rrename lens and visualization embeddable types Mar 31, 2026
@nreese nreese changed the title [dashboards as code] rrename lens and visualization embeddable types [dashboards as code] rename lens and visualization embeddable types Mar 31, 2026
@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 31, 2026

/ci

@nreese nreese requested a review from a team as a code owner April 7, 2026 15:22
Copy link
Copy Markdown
Contributor

@miguelmartin-elastic miguelmartin-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actionable-obs changes lgtm! (code review only)

Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ⚡

Copy link
Copy Markdown
Member

@qn895 qn895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nreese nreese enabled auto-merge (squash) April 8, 2026 00:54
@nreese nreese merged commit 67e869c into elastic:main Apr 8, 2026
18 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / should call onSelectionChange on user selection
  • [job] [logs] Jest Tests #2 / buildEsqlFetchSubscribe changing a ES|QL query with no transformational commands should not change state when loading and finished if index pattern and columns are the same

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
agentBuilder 1441 1442 +1
canvas 1449 1315 -134
cases 2076 2077 +1
dashboard 1118 1119 +1
dashboardAgent 604 605 +1
discover 1995 1996 +1
infra 1842 1843 +1
lens 1733 1734 +1
ml 4097 4265 +168
observability 1896 1897 +1
observabilityAIAssistantApp 823 824 +1
triggersActionsUi 1271 1441 +170
unifiedDocViewer 952 953 +1
visTypePie 208 209 +1
visTypeTimeseries 572 573 +1
visTypeXy 238 239 +1
total +217

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/lens-common 1397 1398 +1
lens 608 607 -1
total -0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB -113.0B
dashboardAgent 138.0KB 138.0KB -2.0B
discoverEnhanced 4.0KB 4.0KB -14.0B
embeddable 42.2KB 42.3KB +50.0B
lens 2.0MB 2.0MB -30.0B
ml 5.8MB 5.8MB +129.0B
unifiedDocViewer 424.8KB 424.8KB -1.0B
visualizations 334.9KB 334.5KB -369.0B
total -350.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 13.5KB 13.3KB -277.0B
dashboard 19.2KB 19.2KB +16.0B
discoverEnhanced 4.9KB 4.8KB -142.0B
kbnUiSharedDeps-srcJs 4.1MB 4.1MB -3.0B
lens 83.4KB 83.4KB -48.0B
triggersActionsUi 111.0KB 111.0KB -1.0B
visualizations 46.6KB 46.6KB -27.0B
total -482.0B
Unknown metric groups

API count

id before after diff
@kbn/lens-common 1557 1558 +1
lens 723 722 -1
total -0

History

nickpeihl added a commit that referenced this pull request Apr 8, 2026
…cal Preview (#256302)

Fixes #256073

## Summary

Introduces the Dashboard API endpoints as Technical Preview

Dashboard API documentation will be published as OpenAPI specifications
and available in the [Kibana API
Documentation](https://www.elastic.co/docs/api/doc/kibana/). Dashboard
API create/update endpoints are initially limited to a select few types
including Lens, markdown, synthetics, and SLO panels. Support for
additional panel types will be available in future updates.

## OAS documentation
To build documentation bundle for public route
* Add `server.oas.enabled: true` to `config/kibana.dev.yml`
* Run `node scripts/capture_oas_snapshot --include-path /api/dashboards
--no-serverless --update`

### Blocked by

- [x] #259670
- [x] #259461
- [x] #260040
- [x] #261186
- [x] #260945

---------

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
florent-leborgne added a commit that referenced this pull request Apr 8, 2026
- Update panel type from `lens` to `vis` in all inline JSON examples
  and YAML examples per #260040
- Replace "Lens" with "visualization(s)" in user-facing overlay text
  and example descriptions

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
florent-leborgne added a commit that referenced this pull request Apr 9, 2026
- Update panel type from `lens` to `vis` in all inline JSON examples
  and YAML examples per #260040
- Replace "Lens" with "visualization(s)" in user-facing overlay text
  and example descriptions

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Project:Dashboards API release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dashboards as code] rename lens and visualization embeddable types [Lens] Extract LENS_EMBEDDABLE_TYPE to @kbn/lens-common