Skip to content

fix: remove ansi-styles 4.3.0 resolution#259974

Merged
TamerlanG merged 2 commits intoelastic:mainfrom
TamerlanG:fix/ansi-styles-resolution
Mar 27, 2026
Merged

fix: remove ansi-styles 4.3.0 resolution#259974
TamerlanG merged 2 commits intoelastic:mainfrom
TamerlanG:fix/ansi-styles-resolution

Conversation

@TamerlanG
Copy link
Copy Markdown
Contributor

@TamerlanG TamerlanG commented Mar 27, 2026

Summary

  • Removes the @langchain/core/ansi-styles resolution (pinned to 4.3.0) from package.json, which was forcing a specific version of ansi-styles through @langchain/core

Why

The resolution was likely a workaround that is no longer needed. Removing it cleans up the dependency tree and allows ansi-styles@^5.0.0 consumers (like pretty-format) to get the correct major version instead of being pinned to an incompatible 4.x release

Resolves #259961

@TamerlanG TamerlanG requested a review from a team March 27, 2026 12:25
@TamerlanG TamerlanG self-assigned this Mar 27, 2026
@TamerlanG TamerlanG added Team:Operations Kibana-Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Mar 27, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Mar 27, 2026

Approvability

Verdict: Would Approve

This PR removes a version resolution override for ansi-styles, allowing the ^5.0.0 range to resolve to 5.2.0 instead of being forced to 4.3.0. This is a straightforward dependency management cleanup with low risk and clear intent.

Macroscope would have approved this PR. Enable approvability here.

…ally, or add an exception to src/dev/yarn_deduplicate/index.ts and then commit the changes and push to your branch
@jbudz jbudz requested a review from patrykkopycinski March 27, 2026 14:08
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
agentBuilder 1416 1417 +1
aiops 617 618 +1
apm 2065 2066 +1
canvas 1400 1401 +1
cases 2104 2105 +1
console 383 384 +1
controls 427 428 +1
dashboard 1096 1097 +1
dashboardAgent 654 655 +1
dashboardMarkdown 120 121 +1
data 622 623 +1
datasetQuality 1130 1131 +1
dataVisualizer 875 876 +1
discover 2001 2002 +1
discoverEnhanced 111 112 +1
embeddable 215 216 +1
embeddableAlertsTable 510 511 +1
esql 973 974 +1
eventAnnotationListing 701 702 +1
imageEmbeddable 169 170 +1
infra 1832 1833 +1
inputControlVis 135 136 +1
lens 1717 1718 +1
links 157 158 +1
lists 468 469 +1
maps 1372 1373 +1
ml 4160 4161 +1
observability 1787 1788 +1
observabilityAIAssistantApp 812 813 +1
presentationPanel 173 174 +1
reporting 260 261 +1
securitySolution 9289 9290 +1
slo 1295 1296 +1
stackAlerts 230 231 +1
streamsApp 1789 1790 +1
synthetics 1263 1264 +1
triggersActionsUi 1329 1330 +1
unifiedDocViewer 941 942 +1
urlDrilldown 159 160 +1
visTypeTimeseries 571 572 +1
visTypeVega 1830 1831 +1
visualizations 629 630 +1
total +42

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 522.2KB 524.2KB +2.0KB
apm 2.7MB 2.7MB +2.0KB
controls 524.1KB 526.1KB +2.0KB
dashboard 844.2KB 846.2KB +2.0KB
dashboardMarkdown 71.3KB 73.3KB +2.0KB
dataVisualizer 616.2KB 618.2KB +2.0KB
discover 1.6MB 1.6MB +2.0KB
embeddableAlertsTable 1.2MB 1.2MB +2.0KB
imageEmbeddable 109.3KB 111.2KB +2.0KB
lens 2.0MB 2.0MB +2.0KB
links 101.5KB 103.5KB +2.0KB
maps 3.2MB 3.2MB +2.0KB
ml 5.8MB 5.8MB +2.0KB
securitySolution 11.4MB 11.4MB +1.0B
slo 1.1MB 1.1MB +2.0KB
synthetics 1.1MB 1.1MB +2.0KB
visualizations 332.3KB 334.2KB +2.0KB
total +31.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 174.1KB 174.1KB +6.0B

cc @TamerlanG

@TamerlanG TamerlanG merged commit 9ef393d into elastic:main Mar 27, 2026
20 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.19, 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/23652853509

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts
9.2 Backport failed because of merge conflicts
9.3 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

node scripts/backport --pr 259974

Questions ?

Please refer to the Backport tool documentation

patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Mar 28, 2026
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Mar 28, 2026
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Mar 30, 2026
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 30, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 259974 locally
cc: @TamerlanG

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 259974 locally
cc: @TamerlanG

jeramysoucy pushed a commit to jeramysoucy/kibana that referenced this pull request Apr 1, 2026
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 259974 locally
cc: @TamerlanG

paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Apr 2, 2026
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 259974 locally
cc: @TamerlanG

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 259974 locally
cc: @TamerlanG

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 259974 locally
cc: @TamerlanG

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 259974 locally
cc: @TamerlanG

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 259974 locally
cc: @TamerlanG

@TamerlanG TamerlanG removed backport:all-open Backport to all branches that could still receive a release backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 8, 2026
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:all-gen-ai-suites release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Fix ansi-styles v4<->5 resolution issue

5 participants