Merged
Conversation
Member
Author
|
/ci |
delanni
force-pushed
the
fix-moon-cache-usage
branch
from
5ad38f4 to
80cb1a9
Compare
delanni
force-pushed
the
fix-moon-cache-usage
branch
from
deac09f to
0908280
Compare
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
delanni
commented
Mar 27, 2026
| log.info('extract relevant versions for packages and pre-build webpack bundles'); | ||
| await moonRun([':extract-version-dependencies', ':build-webpack'], { | ||
| log.info('pre-build webpack bundles'); | ||
| await moonRun([':build-webpack'], { |
Member
Author
There was a problem hiding this comment.
the extract-version-dependencies tasks are already marked as dependencies of the webpack build. I've experimented with this, and it seems we don't benefit from the cache until the 2nd rerun locally if we run both tasks like this, but we do if we just rely on :build-webpack pulling in it's dependencies
delanni
commented
Mar 27, 2026
| const args = ['kbn', 'build-shared']; | ||
| if (quiet) args.push('--quiet'); | ||
| if (dist) args.push('--dist'); | ||
| if (dist) { |
Member
Author
There was a problem hiding this comment.
This avoids reusing a bad cache
kowalczyk-krzysztof
approved these changes
Mar 27, 2026
delanni
commented
Mar 27, 2026
| mkdir -p ./.moon/cache | ||
| echo "Extracting moon-cache.tar.gz to ./.moon/cache" | ||
| tar -xzf ~/moon-cache.tar.gz -C ./ | ||
| elif [[ -d ~/.kibana-moon-cache ]]; then |
Member
Author
There was a problem hiding this comment.
This was trying to retrieve a warmed moon cache from the VM image build.
It seems that cache cannot be reused, probably because some absolute paths are no longer valid on the executors compared to the VM image builder's context. Since it is not useful any longer, it just adds extra weight to the .moon/cache prior to archiving it per-build, that also could have been the reason for failing bootstraps
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis pull request refactors the build system's caching and task orchestration. Changes include: removing the fallback moon cache recovery mechanism, enabling moon caching by removing the explicit ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Comment |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis pull request refactors cache initialization and Moon build task configuration. The changes remove fallback cache logic from bootstrap scripts and disable the unconditional ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Comment |
delanni
added
release_note:skip
Contributor
|
Starting backport for target branches: 8.19, 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/23646386763 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kelvtanv
pushed a commit
to kelvtanv/kibana
that referenced
this pull request
Mar 27, 2026
## Summary Test clearing the moon cache before trying to store one for the job.
tylersmalley
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 27, 2026
## Summary Test clearing the moon cache before trying to store one for the job.
tylersmalley
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 27, 2026
## Summary Test clearing the moon cache before trying to store one for the job.
tylersmalley
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 27, 2026
## Summary Test clearing the moon cache before trying to store one for the job.
This was referenced Mar 27, 2026
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Mar 27, 2026
## Summary Test clearing the moon cache before trying to store one for the job.
tylersmalley
added
backport:skip
kibanamachine
added a commit
that referenced
this pull request
Mar 27, 2026
# Backport This will backport the following commits from `main` to `9.2`: - [Fix Moon webpack dependency cache invalidation (#258940)](#258940) - [Fix yarn.lock v1 parser for compound package alias headers (#259640)](#259640) - [[CI] Fix moon cache usage (#259760)](#259760) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Tyler Smalley","email":"tyler.smalley@elastic.co"},"sourceCommit":{"committedDate":"2026-03-24T23:56:42Z","message":"Fix Moon webpack dependency cache invalidation (#258940)\n\nMoon cached webpack-built shared dependency bundles using only local source files and webpack config as inputs. When a dependency like `@elastic/eui` changed after bootstrap, Moon did not see any relevant\ninput change for `@kbn/ui-shared-deps-npm`, so it could restore a stale cached bundle. That left the installed dependency tree newer than the built artifact, which is why code present under\n`node_modules/@elastic/eui` was missing from the emitted shared deps bundle.\n\nThis change makes Moon invalidate those webpack bundle caches when, and only when, the actual resolved dependency graph for the bundle changes. Instead of keying off the entire workspace yarn.lock, it adds an exact\ntransitive dependency fingerprint for each affected webpack-built package. That gives correct rebuilds for updated dependencies, including transitive ones, without broadly uncaching on unrelated lockfile churn.\n\n---------\n\nSigned-off-by: Tyler Smalley <tyler.smalley@elastic.co>","sha":"41b1f045b52a2e3ab40fdf7d71cfb0f7b36eed09","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v9.4.0"],"title":"Fix Moon webpack dependency cache invalidation","number":258940,"url":"https://github.com/elastic/kibana/pull/258940","mergeCommit":{"message":"Fix Moon webpack dependency cache invalidation (#258940)\n\nMoon cached webpack-built shared dependency bundles using only local source files and webpack config as inputs. When a dependency like `@elastic/eui` changed after bootstrap, Moon did not see any relevant\ninput change for `@kbn/ui-shared-deps-npm`, so it could restore a stale cached bundle. That left the installed dependency tree newer than the built artifact, which is why code present under\n`node_modules/@elastic/eui` was missing from the emitted shared deps bundle.\n\nThis change makes Moon invalidate those webpack bundle caches when, and only when, the actual resolved dependency graph for the bundle changes. Instead of keying off the entire workspace yarn.lock, it adds an exact\ntransitive dependency fingerprint for each affected webpack-built package. That gives correct rebuilds for updated dependencies, including transitive ones, without broadly uncaching on unrelated lockfile churn.\n\n---------\n\nSigned-off-by: Tyler Smalley <tyler.smalley@elastic.co>","sha":"41b1f045b52a2e3ab40fdf7d71cfb0f7b36eed09"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/258940","number":258940,"mergeCommit":{"message":"Fix Moon webpack dependency cache invalidation (#258940)\n\nMoon cached webpack-built shared dependency bundles using only local source files and webpack config as inputs. When a dependency like `@elastic/eui` changed after bootstrap, Moon did not see any relevant\ninput change for `@kbn/ui-shared-deps-npm`, so it could restore a stale cached bundle. That left the installed dependency tree newer than the built artifact, which is why code present under\n`node_modules/@elastic/eui` was missing from the emitted shared deps bundle.\n\nThis change makes Moon invalidate those webpack bundle caches when, and only when, the actual resolved dependency graph for the bundle changes. Instead of keying off the entire workspace yarn.lock, it adds an exact\ntransitive dependency fingerprint for each affected webpack-built package. That gives correct rebuilds for updated dependencies, including transitive ones, without broadly uncaching on unrelated lockfile churn.\n\n---------\n\nSigned-off-by: Tyler Smalley <tyler.smalley@elastic.co>","sha":"41b1f045b52a2e3ab40fdf7d71cfb0f7b36eed09"}}]}] BACKPORT--> --------- Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co> Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
tylersmalley
added a commit
that referenced
this pull request
Mar 27, 2026
…9640) (#260090) # Backport This will backport the following commits from `main` to `9.3`: - [Fix yarn.lock v1 parser for compound package alias headers (#259640)](#259640) - [[CI] Fix moon cache usage (#259760)](#259760) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2026-03-25T19:33:17Z","message":"Fix yarn.lock v1 parser for compound package alias headers (#259640)\n\n## Summary\n\nFixes `extract-version-dependencies` failing with `Unable to resolve\nd3-color@1 - 2 from yarn.lock dependency graph` when Yarn merges\nmultiple lockfile descriptors (aliases) into a single block.\n\n## Changes\n\n- **`yarn_lock_v1.ts`**: Parse each comma-separated header descriptor\nwith correct scoped vs unscoped `@` splitting; register `PackageInfo`\nper alias; merge `requestedVersions` for duplicate\n`name@resolvedVersion` keys. In `focus` mode, include a block if any\nalias matches.\n- **`yarn_lock_v1.test.ts`**: Regression test for compound headers.\n- **`yarn.lock`**: Refreshed merged descriptor lines (e.g. `d3-color` /\n`@elastic/kibana-d3-color`, `ajv` / `@redocly/ajv`).\n- **`version_dependencies.txt`**: Regenerated via\n`extract-version-dependencies`.\n\n## Testing\n\n- `node scripts/jest src/dev/yarn/yarn_lock_v1.test.ts`\n- `moon run @kbn/ui-shared-deps-npm:extract-version-dependencies`\n- `node scripts/check_changes.ts`\n\nMade with [Cursor](https://cursor.com)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c82b6d42eb7fecc5116eaab557ad8a4cf8869076","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","backport:all-open","v9.4.0"],"title":"Fix yarn.lock v1 parser for compound package alias headers","number":259640,"url":"https://github.com/elastic/kibana/pull/259640","mergeCommit":{"message":"Fix yarn.lock v1 parser for compound package alias headers (#259640)\n\n## Summary\n\nFixes `extract-version-dependencies` failing with `Unable to resolve\nd3-color@1 - 2 from yarn.lock dependency graph` when Yarn merges\nmultiple lockfile descriptors (aliases) into a single block.\n\n## Changes\n\n- **`yarn_lock_v1.ts`**: Parse each comma-separated header descriptor\nwith correct scoped vs unscoped `@` splitting; register `PackageInfo`\nper alias; merge `requestedVersions` for duplicate\n`name@resolvedVersion` keys. In `focus` mode, include a block if any\nalias matches.\n- **`yarn_lock_v1.test.ts`**: Regression test for compound headers.\n- **`yarn.lock`**: Refreshed merged descriptor lines (e.g. `d3-color` /\n`@elastic/kibana-d3-color`, `ajv` / `@redocly/ajv`).\n- **`version_dependencies.txt`**: Regenerated via\n`extract-version-dependencies`.\n\n## Testing\n\n- `node scripts/jest src/dev/yarn/yarn_lock_v1.test.ts`\n- `moon run @kbn/ui-shared-deps-npm:extract-version-dependencies`\n- `node scripts/check_changes.ts`\n\nMade with [Cursor](https://cursor.com)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c82b6d42eb7fecc5116eaab557ad8a4cf8869076"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/259640","number":259640,"mergeCommit":{"message":"Fix yarn.lock v1 parser for compound package alias headers (#259640)\n\n## Summary\n\nFixes `extract-version-dependencies` failing with `Unable to resolve\nd3-color@1 - 2 from yarn.lock dependency graph` when Yarn merges\nmultiple lockfile descriptors (aliases) into a single block.\n\n## Changes\n\n- **`yarn_lock_v1.ts`**: Parse each comma-separated header descriptor\nwith correct scoped vs unscoped `@` splitting; register `PackageInfo`\nper alias; merge `requestedVersions` for duplicate\n`name@resolvedVersion` keys. In `focus` mode, include a block if any\nalias matches.\n- **`yarn_lock_v1.test.ts`**: Regression test for compound headers.\n- **`yarn.lock`**: Refreshed merged descriptor lines (e.g. `d3-color` /\n`@elastic/kibana-d3-color`, `ajv` / `@redocly/ajv`).\n- **`version_dependencies.txt`**: Regenerated via\n`extract-version-dependencies`.\n\n## Testing\n\n- `node scripts/jest src/dev/yarn/yarn_lock_v1.test.ts`\n- `moon run @kbn/ui-shared-deps-npm:extract-version-dependencies`\n- `node scripts/check_changes.ts`\n\nMade with [Cursor](https://cursor.com)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c82b6d42eb7fecc5116eaab557ad8a4cf8869076"}},{"url":"https://github.com/elastic/kibana/pull/259476","number":259476,"branch":"9.2","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/259475","number":259475,"branch":"8.19","state":"OPEN"}]}] BACKPORT--> --------- Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 27, 2026
) # Backport This will backport the following commits from `main` to `8.19`: - [Fix Moon webpack dependency cache invalidation (#258940)](#258940) - [Fix yarn.lock v1 parser for compound package alias headers (#259640)](#259640) - [[CI] Fix moon cache usage (#259760)](#259760) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Tyler Smalley","email":"tyler.smalley@elastic.co"},"sourceCommit":{"committedDate":"2026-03-24T23:56:42Z","message":"Fix Moon webpack dependency cache invalidation (#258940)\n\nMoon cached webpack-built shared dependency bundles using only local source files and webpack config as inputs. When a dependency like `@elastic/eui` changed after bootstrap, Moon did not see any relevant\ninput change for `@kbn/ui-shared-deps-npm`, so it could restore a stale cached bundle. That left the installed dependency tree newer than the built artifact, which is why code present under\n`node_modules/@elastic/eui` was missing from the emitted shared deps bundle.\n\nThis change makes Moon invalidate those webpack bundle caches when, and only when, the actual resolved dependency graph for the bundle changes. Instead of keying off the entire workspace yarn.lock, it adds an exact\ntransitive dependency fingerprint for each affected webpack-built package. That gives correct rebuilds for updated dependencies, including transitive ones, without broadly uncaching on unrelated lockfile churn.\n\n---------\n\nSigned-off-by: Tyler Smalley <tyler.smalley@elastic.co>","sha":"41b1f045b52a2e3ab40fdf7d71cfb0f7b36eed09","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v9.4.0"],"title":"Fix Moon webpack dependency cache invalidation","number":258940,"url":"https://github.com/elastic/kibana/pull/258940","mergeCommit":{"message":"Fix Moon webpack dependency cache invalidation (#258940)\n\nMoon cached webpack-built shared dependency bundles using only local source files and webpack config as inputs. When a dependency like `@elastic/eui` changed after bootstrap, Moon did not see any relevant\ninput change for `@kbn/ui-shared-deps-npm`, so it could restore a stale cached bundle. That left the installed dependency tree newer than the built artifact, which is why code present under\n`node_modules/@elastic/eui` was missing from the emitted shared deps bundle.\n\nThis change makes Moon invalidate those webpack bundle caches when, and only when, the actual resolved dependency graph for the bundle changes. Instead of keying off the entire workspace yarn.lock, it adds an exact\ntransitive dependency fingerprint for each affected webpack-built package. That gives correct rebuilds for updated dependencies, including transitive ones, without broadly uncaching on unrelated lockfile churn.\n\n---------\n\nSigned-off-by: Tyler Smalley <tyler.smalley@elastic.co>","sha":"41b1f045b52a2e3ab40fdf7d71cfb0f7b36eed09"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/258940","number":258940,"mergeCommit":{"message":"Fix Moon webpack dependency cache invalidation (#258940)\n\nMoon cached webpack-built shared dependency bundles using only local source files and webpack config as inputs. When a dependency like `@elastic/eui` changed after bootstrap, Moon did not see any relevant\ninput change for `@kbn/ui-shared-deps-npm`, so it could restore a stale cached bundle. That left the installed dependency tree newer than the built artifact, which is why code present under\n`node_modules/@elastic/eui` was missing from the emitted shared deps bundle.\n\nThis change makes Moon invalidate those webpack bundle caches when, and only when, the actual resolved dependency graph for the bundle changes. Instead of keying off the entire workspace yarn.lock, it adds an exact\ntransitive dependency fingerprint for each affected webpack-built package. That gives correct rebuilds for updated dependencies, including transitive ones, without broadly uncaching on unrelated lockfile churn.\n\n---------\n\nSigned-off-by: Tyler Smalley <tyler.smalley@elastic.co>","sha":"41b1f045b52a2e3ab40fdf7d71cfb0f7b36eed09"}}]}] BACKPORT--> --------- Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co> Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 30, 2026
## Summary Test clearing the moon cache before trying to store one for the job.
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Apr 1, 2026
## Summary Test clearing the moon cache before trying to store one for the job.
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Apr 2, 2026
## Summary Test clearing the moon cache before trying to store one for the job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test clearing the moon cache before trying to store one for the job.