fix(NA): yarn_lock_v1.ts parser for aliased packages#259654
Open
mistic wants to merge 7 commits intoelastic:mainfrom
Open
fix(NA): yarn_lock_v1.ts parser for aliased packages#259654mistic wants to merge 7 commits intoelastic:mainfrom
mistic wants to merge 7 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
ApprovabilityVerdict: Needs human review This is a bug fix to dev tooling (yarn.lock parser) with tests, but the author does not own these files—they belong to @elastic/kibana-operations. The designated code owners should review changes to their infrastructure tooling. You can customize Macroscope's approvability policy. Learn more. |
Member
…mistic/kibana into fix-yarn-v1-parser-for-aliased-packages
Contributor
Author
|
I've only got in touch with the other PR after I put mine up. The end results are similar but I just think this changes are a closer fit to the past code structure that we had there before. Up to decide if we either close this or still merge it . I'm okay either way |
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @mistic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When yarn v1 merges aliased packages (like d3-color aliased to @elastic/kibana-d3-color) into a single yarn.lock header, the parser assumed all entries shared the same package name. It extracted the name from the first entry (@elastic/kibana-d3-color) and stripped it from all entries to compute versions, producing garbage for entries with a different name (d3-color@1 - 2).
So in this PR: