Skip to content

[Lens as code] Cleanup api namings#259636

Merged
markov00 merged 11 commits intoelastic:mainfrom
markov00:2026_03_26-cleanup_api_namings
Mar 27, 2026
Merged

[Lens as code] Cleanup api namings#259636
markov00 merged 11 commits intoelastic:mainfrom
markov00:2026_03_26-cleanup_api_namings

Conversation

@markov00
Copy link
Copy Markdown
Contributor

@markov00 markov00 commented Mar 25, 2026 •
edited
Loading

Summary

Fix #257034

Cleanup namings like:

  • Heatmap axis -> axes (like XY charts)
  • unassignedColor -> unassigned
  • axis title.value -> title.text

markov00
markov00 commented Mar 26, 2026
View reviewed changes
Comment thread src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/color.test.ts Outdated
@walterra walterra mentioned this pull request Mar 26, 2026
Closed
4 tasks
@markov00 markov00 force-pushed the 2026_03_26-cleanup_api_namings branch from ddb1886 to 3cc13fc Compare March 26, 2026 09:09
@markov00 markov00 marked this pull request as ready for review March 26, 2026 21:26
@markov00 markov00 requested a review from a team as a code owner March 26, 2026 21:26
@markov00 markov00 added enhancement New value added to drive a business result Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Mar 26, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 26, 2026

Pinging @elastic/kibana-visualizations (Team:Visualizations)

nickofthyme
nickofthyme approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, so many satisfies! 😍 🫶

@markov00 markov00 enabled auto-merge (squash) March 26, 2026 21:50
@markov00 markov00 merged commit 5860bc5 into elastic:main Mar 27, 2026
18 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 27, 2026

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
agentBuilder 665.8KB 665.3KB -458.0B
cases 2.0MB 2.0MB -458.0B
dashboard 844.2KB 843.7KB -458.0B
dashboardAgent 180.3KB 179.9KB -458.0B
discover 1.6MB 1.6MB -458.0B
infra 1.3MB 1.3MB -458.0B
lens 2.0MB 2.0MB -358.0B
observability 2.0MB 2.0MB -458.0B
observabilityAIAssistantApp 326.8KB 326.4KB -458.0B
unifiedDocViewer 421.4KB 420.9KB -458.0B
total -4.4KB

History

kelvtanv pushed a commit to kelvtanv/kibana that referenced this pull request Mar 27, 2026
@markov00 @nickofthyme @kelvtanv
[Lens as code] Cleanup api namings (elastic#259636)
9e61b4d 
## Summary

Fix elastic#257034

Cleanup namings like:
- Heatmap `axis` -> `axes` (like XY charts)
- `unassignedColor` -> `unassigned`
- axis `title.value` -> `title.text`

---------

Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Mar 30, 2026
@markov00 @nickofthyme @SoniaSanzV
[Lens as code] Cleanup api namings (elastic#259636)
ec2ebb0 
## Summary

Fix elastic#257034

Cleanup namings like:
- Heatmap `axis` -> `axes` (like XY charts)
- `unassignedColor` -> `unassigned`
- axis `title.value` -> `title.text`

---------

Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
jeramysoucy pushed a commit to jeramysoucy/kibana that referenced this pull request Apr 1, 2026
@markov00 @nickofthyme @jeramysoucy
[Lens as code] Cleanup api namings (elastic#259636)
3d5e5e0 
## Summary

Fix elastic#257034

Cleanup namings like:
- Heatmap `axis` -> `axes` (like XY charts)
- `unassignedColor` -> `unassigned`
- axis `title.value` -> `title.text`

---------

Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Apr 2, 2026
@markov00 @nickofthyme @paulinashakirova
[Lens as code] Cleanup api namings (elastic#259636)
4f57c3c 
## Summary

Fix elastic#257034

Cleanup namings like:
- Heatmap `axis` -> `axes` (like XY charts)
- `unassignedColor` -> `unassigned`
- axis `title.value` -> `title.text`

---------

Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
@walterra walterra mentioned this pull request Apr 16, 2026
Merged
walterra added a commit that referenced this pull request Apr 16, 2026
@walterra
[Lens as Code] Revert heatmap 'axes' property to 'axis' (#263784)
4e1046d 
## Summary

Part of #257034. Follow up to #259636.

Reverts Heatmap `axes` -> `axis` to be actually in line with xy charts.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 16, 2026
@walterra
[Lens as Code] Revert heatmap 'axes' property to 'axis' (elastic#263784)
4eb090e 
## Summary

Part of elastic#257034. Follow up to elastic#259636.

Reverts Heatmap `axes` -> `axis` to be actually in line with xy charts.

(cherry picked from commit 4e1046d)
kibanamachine added a commit that referenced this pull request Apr 20, 2026
@kibanamachine @walterra @nickofthyme
[9.4] [Lens as Code] Revert heatmap 'axes' property to 'axis' (#263784)…
69cba5a 
… (#263834)

# Backport

This will backport the following commits from `main` to `9.4`:
- [[Lens as Code] Revert heatmap 'axes' property to 'axis'
(#263784)](#263784)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Walter M.
Rafelsberger","email":"walter.rafelsberger@elastic.co"},"sourceCommit":{"committedDate":"2026-04-16T15:43:36Z","message":"[Lens
as Code] Revert heatmap 'axes' property to 'axis' (#263784)\n\n##
Summary\n\nPart of #257034. Follow up to #259636.\n\nReverts Heatmap
`axes` -> `axis` to be actually in line with xy
charts.","sha":"4e1046d084cf6e8d1340d22ebcd8f8d471389743","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","backport:version","v9.4.0","v9.5.0"],"title":"[Lens
as Code] Revert heatmap 'axes' property to
'axis'","number":263784,"url":"https://github.com/elastic/kibana/pull/263784","mergeCommit":{"message":"[Lens
as Code] Revert heatmap 'axes' property to 'axis' (#263784)\n\n##
Summary\n\nPart of #257034. Follow up to #259636.\n\nReverts Heatmap
`axes` -> `axis` to be actually in line with xy
charts.","sha":"4e1046d084cf6e8d1340d22ebcd8f8d471389743"}},"sourceBranch":"main","suggestedTargetBranches":["9.4"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/263784","number":263784,"mergeCommit":{"message":"[Lens
as Code] Revert heatmap 'axes' property to 'axis' (#263784)\n\n##
Summary\n\nPart of #257034. Follow up to #259636.\n\nReverts Heatmap
`axes` -> `axis` to be actually in line with xy
charts.","sha":"4e1046d084cf6e8d1340d22ebcd8f8d471389743"}}]}]
BACKPORT-->

Co-authored-by: Walter M. Rafelsberger <walter.rafelsberger@elastic.co>
Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Lens as code] Casing convention cleanup

4 participants

@markov00 @elasticmachine @nickofthyme @kibanamachine