[ResponseOps][MaintenanceWindow] Add filter button of DSL filter throws error on create/edit MWs by georgianaonoleata1904 · Pull Request #259517 · elastic/kibana

georgianaonoleata1904 · 2026-03-25T09:48:21Z

Summary

Fix crash in FilterEditor when submitting a Query DSL filter with no index patterns available. getFilterFromQueryDsl accessed indexPatterns[0].id without guarding against an empty array.

fixed also: filter not being displayed after creation, two separate guards were preventing DSL filter pills from rendering in Maintenance Windows (where indexPatterns / dataViews is an empty array):
fixed also edit added filter: indexPattern?.getName() fails because getName() is a method on the DataView class, not on plain DataViewBase objects. Fixed by using optional call getName?.() with fallbacks to name and title.

Related to: #256622

elasticmachine · 2026-03-25T09:48:25Z

Pinging @elastic/response-ops (Team:ResponseOps)

...latform/plugins/shared/unified_search/public/filter_bar/filter_editor/filter_editor.test.tsx

nreese

LGTM
code review only

src/platform/plugins/shared/unified_search/public/search_bar/search_bar.tsx

js-jankisalvi

Verified locally, works as expected 👍

src/platform/plugins/shared/unified_search/public/search_bar/search_bar.tsx

nreese · 2026-03-27T16:41:48Z

src/platform/plugins/shared/unified_search/public/search_bar/search_bar.tsx

@@ -346,12 +346,10 @@ export class SearchBarUI<QT extends (Query | AggregateQuery) | Query = Query> ex
  }

  private shouldRenderFilterBar() {


How about just return this.props.showFilterBar || this.props.filters.length?

Really you are just removing indexPatterns length check.

it works with &&: return this.props.showFilterBar && this.props.filters

updated the pr

I don't think return this.props.showFilterBar && this.props.filters is correct. This will return false when this.props.filters is not provided.

Taking a step back, we want to render filter bar whenever this.props.showFilterBar is true regardless of available indexPatterns. In that case. I think we should remove shouldRenderFilterBar helper function and just replace its usage with this.props.showFilterBar

Hi @nreese I've addressed the requested changes to remove shouldRenderFilterBar function and to use this.props.showFilterBar instead.

…noleata1904/kibana into mw-wildcard-follow-up

cnasikas · 2026-03-31T10:18:38Z

@elasticmachine merge upstream

elasticmachine · 2026-04-02T11:01:21Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 6ff0198

Failed CI Steps

FTR Configs #186

Test Failures

[job] [logs] FTR Configs #186 / Agent Builder sidebar Sidebar Error Handling can start a new chat when there is an error

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`unifiedSearch`	154.9KB	155.1KB	+220.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`unifiedSearch`	2	4	+2

Unreferenced deprecated APIs

id	before	after	diff
`unifiedSearch`	2	4	+2

History

💛 Build #419530 was flaky 179f3f3
💛 Build #418132 was flaky e97c081
💔 Build #418111 failed 564a28a
💔 Build #417631 failed dfb696a
💔 Build #417629 failed c221f00
💚 Build #416098 succeeded f2b4dc8

cc @georgianaonoleata1904

js-jankisalvi

changes look good to me 👍

verified locally, works as expected 🎉

nreese

LGTM
code review only

kibanamachine · 2026-04-03T13:40:06Z

Starting backport for target branches: 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/23948182226

kibanamachine · 2026-04-03T13:40:07Z

Starting backport for target branches: 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/23948182217

…ws error on create/edit MWs (elastic#259517) Closes elastic#259514 ## Summary Fix crash in FilterEditor when submitting a Query DSL filter with no index patterns available. getFilterFromQueryDsl accessed indexPatterns[0].id without guarding against an empty array. - fixed also: filter not being displayed after creation, two separate guards were preventing DSL filter pills from rendering in Maintenance Windows (where indexPatterns / dataViews is an empty array): - fixed also edit added filter: indexPattern?.getName() fails because getName() is a method on the DataView class, not on plain DataViewBase objects. Fixed by using optional call getName?.() with fallbacks to name and title. Related to: elastic#256622 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit f6c8369)

kibanamachine · 2026-04-03T13:48:33Z

💚 All backports created successfully

Status	Branch	Result
✅	9.2
✅	9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ws error on create/edit MWs (elastic#259517) Closes elastic#259514 ## Summary Fix crash in FilterEditor when submitting a Query DSL filter with no index patterns available. getFilterFromQueryDsl accessed indexPatterns[0].id without guarding against an empty array. - fixed also: filter not being displayed after creation, two separate guards were preventing DSL filter pills from rendering in Maintenance Windows (where indexPatterns / dataViews is an empty array): - fixed also edit added filter: indexPattern?.getName() fails because getName() is a method on the DataView class, not on plain DataViewBase objects. Fixed by using optional call getName?.() with fallbacks to name and title. Related to: elastic#256622 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit f6c8369)

kibanamachine · 2026-04-03T13:49:04Z

💚 All backports created successfully

Status	Branch	Result
✅	9.2
✅	9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…r throws error on create/edit MWs (#259517) (#261139) # Backport This will backport the following commits from `main` to `9.3`: - [[ResponseOps][MaintenanceWindow] Add filter button of DSL filter throws error on create/edit MWs (#259517)](#259517)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Georgiana-Andreea Onoleață <georgiana.onoleata@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…r throws error on create/edit MWs (#259517) (#261138) # Backport This will backport the following commits from `main` to `9.2`: - [[ResponseOps][MaintenanceWindow] Add filter button of DSL filter throws error on create/edit MWs (#259517)](#259517)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Georgiana-Andreea Onoleață <georgiana.onoleata@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

initial commit

d1aa2db

georgianaonoleata1904 self-assigned this Mar 25, 2026

georgianaonoleata1904 requested a review from a team as a code owner March 25, 2026 09:48

georgianaonoleata1904 added release_note:fix backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.4.0 labels Mar 25, 2026

added test

f2b4dc8

nreese reviewed Mar 25, 2026

View reviewed changes

georgianaonoleata1904 added 2 commits March 26, 2026 09:35

addressed comments

32075ad

Merge branch 'main' into mw-wildcard-follow-up

616668a

georgianaonoleata1904 added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Mar 26, 2026

nreese approved these changes Mar 26, 2026

View reviewed changes

georgianaonoleata1904 added 3 commits March 27, 2026 09:23

fix

c221f00

Merge branch 'main' into mw-wildcard-follow-up

dfb696a

Merge branch 'main' into mw-wildcard-follow-up

e40a17a

nreese reviewed Mar 27, 2026

View reviewed changes

src/platform/plugins/shared/unified_search/public/search_bar/search_bar.tsx Outdated Show resolved Hide resolved

js-jankisalvi reviewed Mar 27, 2026

View reviewed changes

src/platform/plugins/shared/unified_search/public/search_bar/search_bar.tsx Outdated Show resolved Hide resolved

src/platform/plugins/shared/unified_search/public/search_bar/search_bar.tsx Outdated Show resolved Hide resolved

nreese reviewed Mar 27, 2026

View reviewed changes

georgianaonoleata1904 and others added 4 commits March 27, 2026 19:31

addressed comments

564a28a

type check fix

96939de

Changes from node scripts/eslint_all_files --no-cache --fix

26d0301

Merge branch 'mw-wildcard-follow-up' of https://github.com/georgianao…

e97c081

…noleata1904/kibana into mw-wildcard-follow-up

Merge branch 'main' into mw-wildcard-follow-up

179f3f3

nreese requested changes Mar 31, 2026

View reviewed changes

georgianaonoleata1904 added 2 commits April 2, 2026 12:40

Merge branch 'main' into mw-wildcard-follow-up

254b3d9

addressed requested changes

6ff0198

georgianaonoleata1904 requested a review from nreese April 2, 2026 09:46

js-jankisalvi approved these changes Apr 2, 2026

View reviewed changes

nreese approved these changes Apr 2, 2026

View reviewed changes

georgianaonoleata1904 merged commit f6c8369 into elastic:main Apr 3, 2026
19 checks passed

cnasikas added the bug Fixes for quality problems that affect the customer experience label Apr 3, 2026

georgianaonoleata1904 added backport:version Backport to applied version labels v9.3.3 v9.2.8 and removed backport:skip This PR does not require backporting labels Apr 3, 2026

kibanamachine mentioned this pull request Apr 3, 2026

[9.2] [ResponseOps][MaintenanceWindow] Add filter button of DSL filter throws error on create/edit MWs (#259517) #261138

Merged

kibanamachine mentioned this pull request Apr 3, 2026

[9.3] [ResponseOps][MaintenanceWindow] Add filter button of DSL filter throws error on create/edit MWs (#259517) #261139

Merged

		@@ -346,12 +346,10 @@ export class SearchBarUI<QT extends (Query \| AggregateQuery) \| Query = Query> ex
		}

		private shouldRenderFilterBar() {

Conversation

georgianaonoleata1904 commented Mar 25, 2026 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Mar 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

js-jankisalvi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nreese Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

georgianaonoleata1904 Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

georgianaonoleata1904 Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

nreese Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

georgianaonoleata1904 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

cnasikas commented Mar 31, 2026

Uh oh!

elasticmachine commented Apr 2, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

References to deprecated APIs

Unreferenced deprecated APIs

History

Uh oh!

js-jankisalvi left a comment

Choose a reason for hiding this comment

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Apr 3, 2026

Uh oh!

kibanamachine commented Apr 3, 2026

Uh oh!

kibanamachine commented Apr 3, 2026

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Apr 3, 2026

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

georgianaonoleata1904 commented Mar 25, 2026 •

edited by kibanamachine

Loading