-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Update EUI to v114.0.0 #259497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update EUI to v114.0.0 #259497
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
b1e32f0
Update EUI to v114.0.0
acstll 6188286
Update @elastic/eslint-plugin-eui
acstll 0835cd5
[Security Plugin] Update snapshots
acstll 19a0b33
[Discover][Scout] Fix flyout tests related to new scoped history
acstll 1e7c214
Revert "[Discover][Scout] Fix flyout tests related to new scoped hist…
tsullivan 9a9528e
wiring of historyKey for Traces Waterfall flyout
tsullivan e3dcf9f
Move cascade-close flyout stability test to Traces in Discover
tsullivan bbb1ddd
Fix for 'Explore from APM › Errors page - "Open in Discover"' test
tsullivan 038cf56
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine b019a02
Fix lint error in 'Explore from APM › Errors page - Open in Discover'…
acstll eedd32f
Merge branch 'main' into eui/v114.0.0
weronikaolejniczak 5f43e9d
TO FIX: Run node 'scripts/yarn_deduplicate && yarn kbn bootstrap' loc…
kibanamachine 6bec361
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 6fb8bbd
remove strictness from useFlyoutHistoryKey hook
tsullivan 7df0c06
fix ts error
tsullivan 5ad719f
Merge branch 'main' into eui/v114.0.0
weronikaolejniczak 7fb2dbf
Merge branch 'main' into eui/v114.0.0
weronikaolejniczak 0d966b5
Merge branch 'main' into eui/v114.0.0
weronikaolejniczak cbd5739
fix(unified_doc_viewer): add custom footer back
weronikaolejniczak cfdcdaa
fix(doc_viewer_flyout): add missing import
weronikaolejniczak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
src/core/packages/i18n/browser-internal/src/__snapshots__/i18n_service.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 0 additions & 16 deletions
16
src/platform/plugins/shared/discover/test/scout/ui/fixtures/flyout_stability/constants.ts
This file was deleted.
Oops, something went wrong.
11 changes: 0 additions & 11 deletions
11
src/platform/plugins/shared/discover/test/scout/ui/fixtures/flyout_stability/index.ts
This file was deleted.
Oops, something went wrong.
15 changes: 0 additions & 15 deletions
15
...red/discover/test/scout/ui/fixtures/flyout_stability/kbn_archives/logstash_data_view.json
This file was deleted.
Oops, something went wrong.
27 changes: 0 additions & 27 deletions
27
src/platform/plugins/shared/discover/test/scout/ui/fixtures/flyout_stability/setup.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 0 additions & 69 deletions
69
...hared/discover/test/scout/ui/parallel_tests/flyout_stability/flyout_emotion_cache.spec.ts
This file was deleted.
Oops, something went wrong.
104 changes: 104 additions & 0 deletions
104
...ared/discover/test/scout/ui/parallel_tests/traces_experience/flyout_cascade_close.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the "Elastic License | ||
| * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
| * Public License v 1"; you may not use this file except in compliance with, at | ||
| * your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
| * License v3.0 only", or the "Server Side Public License, v 1". | ||
| */ | ||
|
|
||
|
iblancof marked this conversation as resolved.
|
||
| import { tags } from '@kbn/scout'; | ||
| import { expect } from '@kbn/scout/ui'; | ||
| import type { PageObjects } from '@kbn/scout'; | ||
| import { | ||
| spaceTest, | ||
| TRACES, | ||
| RICH_TRACE, | ||
| setupTracesExperience, | ||
| teardownTracesExperience, | ||
| } from '../../fixtures/traces_experience'; | ||
| import type { TracesFlyout } from '../../fixtures/traces_experience/page_objects/flyout'; | ||
|
|
||
| type DiscoverPage = PageObjects['discover']; | ||
|
|
||
| const openDocViewerAndTraceTimeline = async (pageObjects: { | ||
| discover: DiscoverPage; | ||
| tracesExperience: { | ||
| openOverviewTab: (d: DiscoverPage) => Promise<void>; | ||
| flyout: TracesFlyout; | ||
| }; | ||
| }) => { | ||
| await pageObjects.discover.writeAndSubmitEsqlQuery( | ||
| `${TRACES.ESQL_QUERY} | WHERE transaction.name == "${RICH_TRACE.TRANSACTION_NAME}"` | ||
| ); | ||
| await pageObjects.tracesExperience.openOverviewTab(pageObjects.discover); | ||
| await pageObjects.tracesExperience.flyout.traceSummary.fullScreenButton.click(); | ||
| await expect(pageObjects.tracesExperience.flyout.waterfallFlyout.container).toBeVisible(); | ||
| }; | ||
|
|
||
| spaceTest.describe( | ||
| 'Traces in Discover - Flyout cascade-close Emotion cache stability', | ||
| { | ||
| tag: [...tags.stateful.all, ...tags.serverless.observability.complete], | ||
| }, | ||
| () => { | ||
| spaceTest.beforeAll(async ({ scoutSpace, config }) => { | ||
| await setupTracesExperience(scoutSpace, config); | ||
| }); | ||
|
|
||
| spaceTest.beforeEach(async ({ browserAuth, pageObjects, page }) => { | ||
| await browserAuth.loginAsViewer(); | ||
| await pageObjects.discover.goto(); | ||
| // Suppress the tour so it does not overlap the waterfall flyout interactions. | ||
| await page.evaluate(() => localStorage.setItem('fullscreenWaterfallTourDismissed', 'true')); | ||
| }); | ||
|
|
||
| spaceTest.afterAll(async ({ scoutSpace }) => { | ||
| await teardownTracesExperience(scoutSpace); | ||
| }); | ||
|
|
||
| spaceTest( | ||
| 'closing the Trace Timeline flyout navigates back to the Document Viewer without corrupting the Emotion style cache', | ||
| async ({ page, pageObjects }) => { | ||
| const { flyout } = pageObjects.tracesExperience; | ||
| const docViewerFlyout = page.testSubj.locator('docViewerFlyout'); | ||
|
|
||
| const consoleErrors: string[] = []; | ||
| page.on('console', (msg) => { | ||
| if (msg.type() === 'error') { | ||
| consoleErrors.push(msg.text()); | ||
| } | ||
| }); | ||
|
|
||
| await spaceTest.step('open the Document Viewer and Trace Timeline flyouts', async () => { | ||
| await pageObjects.discover.waitUntilSearchingHasFinished(); | ||
| await openDocViewerAndTraceTimeline(pageObjects); | ||
| }); | ||
|
|
||
| await spaceTest.step('close the Trace Timeline flyout via the Back button', async () => { | ||
| await flyout.waterfallFlyout.backButton.click(); | ||
| await expect(flyout.waterfallFlyout.container).toBeHidden(); | ||
| // The Document Viewer remains visible — it was not cascade-closed because | ||
| // both flyouts share the same EUI flyout-manager historyKey. | ||
| await expect(docViewerFlyout).toBeVisible(); | ||
| }); | ||
|
|
||
| await spaceTest.step( | ||
| 're-open the Trace Timeline flyout after navigating back', | ||
| async () => { | ||
| await flyout.traceSummary.fullScreenButton.click(); | ||
| await expect(flyout.waterfallFlyout.container).toBeVisible(); | ||
| } | ||
| ); | ||
|
|
||
| await spaceTest.step( | ||
| 'verify no insertBefore errors from stale Emotion cache refs', | ||
| async () => { | ||
| const hasInsertBeforeError = consoleErrors.some((msg) => msg.includes('insertBefore')); | ||
| expect(hasInsertBeforeError).toBe(false); | ||
| } | ||
| ); | ||
| } | ||
| ); | ||
| } | ||
| ); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.