Fix Traces persists invalid filters#259432
Merged
sbelastic merged 1 commit intoelastic:mainfrom Mar 25, 2026
Merged
Conversation
sbelastic
added
release_note:skip
Contributor
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
sbelastic
changed the title
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]Async chunks
Historycc @sbelastic |
AlejandroFrndz
approved these changes
Mar 25, 2026
Contributor
AlejandroFrndz
left a comment
AlejandroFrndz
left a comment
There was a problem hiding this comment.
Good eye realising the kql params in the service map filter the map but not the traces in edges. LGTM!
sbelastic
added
backport:version
Contributor
|
Starting backport for target branches: 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/23533304239 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
sbelastic
added
backport:skip
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
Closes elastic#257427 ## Summary - Like it written in the issue, the kuery is not longer passed to the discover page from the service map when exploring traces because it's not used in the red metrics, now the data stays consistent when going between pages - Add unit tests for this ### Before and After #### Before https://github.com/user-attachments/assets/345ac5a9-fa32-4410-afff-003db8593ed1 #### After https://github.com/user-attachments/assets/c97944f5-f5b1-4cfa-b577-46ebbcc0fdaa ### How to run Unit Tests `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_map/popover/edge_contents.test.tsx` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
sbelastic
added a commit
to sbelastic/kibana
that referenced
this pull request
Mar 27, 2026
Closes elastic#257427 - Like it written in the issue, the kuery is not longer passed to the discover page from the service map when exploring traces because it's not used in the red metrics, now the data stays consistent when going between pages - Add unit tests for this https://github.com/user-attachments/assets/345ac5a9-fa32-4410-afff-003db8593ed1 https://github.com/user-attachments/assets/c97944f5-f5b1-4cfa-b577-46ebbcc0fdaa `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_map/popover/edge_contents.test.tsx` - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 68aab74)
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Apr 1, 2026
Closes elastic#257427 ## Summary - Like it written in the issue, the kuery is not longer passed to the discover page from the service map when exploring traces because it's not used in the red metrics, now the data stays consistent when going between pages - Add unit tests for this ### Before and After #### Before https://github.com/user-attachments/assets/345ac5a9-fa32-4410-afff-003db8593ed1 #### After https://github.com/user-attachments/assets/c97944f5-f5b1-4cfa-b577-46ebbcc0fdaa ### How to run Unit Tests `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_map/popover/edge_contents.test.tsx` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257427
Summary
Before and After
Before
Before.mp4
After
After.mp4
How to run Unit Tests
yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_map/popover/edge_contents.test.tsxChecklist