[CI] Jest through moon#259075
Conversation
| '--no-experimental-require-module', | ||
| '$workspaceRoot/scripts/jest', | ||
| '--config', | ||
| `$projectRoot/${jestConfigName}`, |
There was a problem hiding this comment.
we've been encoding the details to where the config can be found as arguments to the task.
I've realized we can do this instead by adding an entry to fileGroups, then refer that in any required arguments.
|
I'll only move this to ready-for-review after the changes are accepted by @elastic/kibana-operations , so that the regenerated configs by CI will not make reviewing impossible :) |
955d3b4 to
5271082
Compare
TamerlanG
left a comment
There was a problem hiding this comment.
lgtm, tried it locally and works
4c2e84c to
661302c
Compare
…s without command details to avoid updates
This reverts commit d5e3e00.
c1f8d9d to
f06a197
Compare
💚 Build Succeeded
Metrics [docs]
History
|
|
Admin-merging because it's pending on an irrelevant file for review, keeping an eye on the builds |
|
Starting backport for target branches: 8.19, 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/23683131894 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
## Summary Splitting: elastic#253279 into multiple parts. Part 1: remove jest task details from individual configs. This PR refreshes the current (erroneous) jest setup, and extracts the specifics of the jest command to the task file containing the jest command. We can switch these tasks to point to a file with their fileGroups, then refer these tokens in the shared commands, this way, any local specificity is captured in a filegroup entry (once per concern) then any task can just refer to these in the shared/centralized point of describing the task. This PR will run a moon config regeneration, removing the jest tasks, so it will be a 1000+ file update. I've added a single moon file regenerated to show a preview of how the change would look.
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
## Summary Splitting: elastic#253279 into multiple parts. Part 1: remove jest task details from individual configs. This PR refreshes the current (erroneous) jest setup, and extracts the specifics of the jest command to the task file containing the jest command. We can switch these tasks to point to a file with their fileGroups, then refer these tokens in the shared commands, this way, any local specificity is captured in a filegroup entry (once per concern) then any task can just refer to these in the shared/centralized point of describing the task. This PR will run a moon config regeneration, removing the jest tasks, so it will be a 1000+ file update. I've added a single moon file regenerated to show a preview of how the change would look.
## Summary Splitting: elastic#253279 into multiple parts. Part 1: remove jest task details from individual configs. This PR refreshes the current (erroneous) jest setup, and extracts the specifics of the jest command to the task file containing the jest command. We can switch these tasks to point to a file with their fileGroups, then refer these tokens in the shared commands, this way, any local specificity is captured in a filegroup entry (once per concern) then any task can just refer to these in the shared/centralized point of describing the task. This PR will run a moon config regeneration, removing the jest tasks, so it will be a 1000+ file update. I've added a single moon file regenerated to show a preview of how the change would look.
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
5 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
Splitting: #253279 into multiple parts. Part 1: remove jest task details from individual configs.
This PR refreshes the current (erroneous) jest setup, and extracts the specifics of the jest command to the task file containing the jest command. We can switch these tasks to point to a file with their fileGroups, then refer these tokens in the shared commands, this way, any local specificity is captured in a filegroup entry (once per concern) then any task can just refer to these in the shared/centralized point of describing the task.
This PR will run a moon config regeneration, removing the jest tasks, so it will be a 1000+ file update. I've added a single moon file regenerated to show a preview of how the change would look.