[Fleet] Fix screen reader announcement for actions buttons across Fleet tables#258559
[Fleet] Fix screen reader announcement for actions buttons across Fleet tables#258559
Conversation
…ble actions button Co-authored-by: bhavyarm <7074629+bhavyarm@users.noreply.github.com>
|
Pinging @elastic/fleet (Team:Fleet) |
|
/ci |
|
@elasticmachine run docs-build |
|
@elasticmachine merge upstream |
|
@elasticmachine run docs-build |
|
/ci |
|
@bhavyarm I’m not sure a simple rename fully resolves the a11y issue. With multiple rows, we still end up with items that have very similar labels. Previously, we agreed to add more context to the aria-label, e.g. “Actions for row {row number}” or “Actions for {row title}”. |
|
@copilot please apply suggestions from my previous message |
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @bhavyarm @Copilot |
ApprovabilityVerdict: Would Approve This PR adds aria-label attributes to action buttons for screen reader accessibility improvements. The changes are purely presentational with no runtime behavior impact - only adding i18n-translated labels to existing buttons. The open review comment about prop naming appears to already be addressed in the current code. No code changes detected at Macroscope would have approved this PR. A repo admin can enable approvability here. |
|
/ci |
|
@elasticmachine run docs-build |
|
/ci |
|
@elasticmachine run docs-build |
|
Starting backport for target branches: 9.3, 9.4 https://github.com/elastic/kibana/actions/runs/24423527735 |
…et tables (elastic#258559) (cherry picked from commit 3303bb4)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…ss Fleet tables (#258559) (#263207) # Backport This will backport the following commits from `main` to `9.4`: - [[Fleet] Fix screen reader announcement for actions buttons across Fleet tables (#258559)](#258559) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-04-14T21:20:32Z","message":"[Fleet] Fix screen reader announcement for actions buttons across Fleet tables (#258559)","sha":"3303bb4d2182153a16be2632d0c012031ca0271b","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","💝community","Team:Fleet","backport:version","v9.4.0","a11y:agent-pr","v9.5.0","v9.3.4"],"title":"[Fleet] Fix screen reader announcement for actions buttons across Fleet tables","number":258559,"url":"https://github.com/elastic/kibana/pull/258559","mergeCommit":{"message":"[Fleet] Fix screen reader announcement for actions buttons across Fleet tables (#258559)","sha":"3303bb4d2182153a16be2632d0c012031ca0271b"}},"sourceBranch":"main","suggestedTargetBranches":["9.4","9.3"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/258559","number":258559,"mergeCommit":{"message":"[Fleet] Fix screen reader announcement for actions buttons across Fleet tables (#258559)","sha":"3303bb4d2182153a16be2632d0c012031ca0271b"}},{"branch":"9.3","label":"v9.3.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
…et tables (elastic#258559) (cherry picked from commit 3303bb4) # Conflicts: # x-pack/platform/plugins/shared/fleet/public/components/context_menu_actions.tsx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ss Fleet tables (#258559) (#263320) # Backport This will backport the following commits from `main` to `9.3`: - [[Fleet] Fix screen reader announcement for actions buttons across Fleet tables (#258559)](#258559) <!--- Backport version: 11.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-04-14T21:20:32Z","message":"[Fleet] Fix screen reader announcement for actions buttons across Fleet tables (#258559)","sha":"3303bb4d2182153a16be2632d0c012031ca0271b","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","💝community","Team:Fleet","backport:version","v9.4.0","a11y:agent-pr","v9.5.0","v9.3.4"],"title":"[Fleet] Fix screen reader announcement for actions buttons across Fleet tables","number":258559,"url":"https://github.com/elastic/kibana/pull/258559","mergeCommit":{"message":"[Fleet] Fix screen reader announcement for actions buttons across Fleet tables (#258559)","sha":"3303bb4d2182153a16be2632d0c012031ca0271b"}},"sourceBranch":"main","suggestedTargetBranches":["9.3"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/263207","number":263207,"state":"MERGED","mergeCommit":{"sha":"8ef171d45c78eb301827446fd3cdc189f586c132","message":"[9.4] [Fleet] Fix screen reader announcement for actions buttons across Fleet tables (#258559) (#263207)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.4`:\n- [[Fleet] Fix screen reader announcement for actions buttons across\nFleet tables (#258559)](https://github.com/elastic/kibana/pull/258559)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>"}},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/258559","number":258559,"mergeCommit":{"message":"[Fleet] Fix screen reader announcement for actions buttons across Fleet tables (#258559)","sha":"3303bb4d2182153a16be2632d0c012031ca0271b"}},{"branch":"9.3","label":"v9.3.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Closes: #230985
The
⋯actions button in Fleet tables hadaria-label="Open", causing screen readers to announce it as "Open, button" — providing no semantic context for non-sighted users (WCAG 1.3.1). With multiple rows, a generic label like "Actions" still doesn't help screen reader users distinguish between buttons in different rows.Changes
context_menu_actions.tsx: Added an optionalariaLabelprop toContextMenuActions. TheEuiButtonIconuses the passed label when provided, falling back to the generic"Actions"translation.actions_menu.tsx(AgentPolicyActionMenu): Passes"Actions for {policyName}"as theariaLabelwhen rendering in icon-only mode, so each row's button is uniquely announced (e.g."Actions for ESTEC Agent Policy, button").package_policy_actions_menu.tsx(PackagePolicyActionsMenu): Passes"Actions for {policyName}"using the package policy name.data_stream_row_actions.tsx(DataStreamRowActions): Passes"Actions for {dataset}"using the data stream's dataset name.This ensures screen readers announce each row's button with enough context to distinguish it from buttons in other rows, across all Fleet tables that use the shared
ContextMenuActionscomponent.Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.