[Agent Builder] Sidebar designs#258547
Merged
chrisbmar merged 14 commits intoelastic:ab-agent-centric-ux-feature-branchfrom Mar 19, 2026
Merged
[Agent Builder] Sidebar designs#258547chrisbmar merged 14 commits intoelastic:ab-agent-centric-ux-feature-branchfrom
chrisbmar merged 14 commits intoelastic:ab-agent-centric-ux-feature-branchfrom
Conversation
chrisbmar
added
release_note:skip
chrisbmar
commented
Mar 19, 2026
| @@ -0,0 +1,180 @@ | |||
| /* | |||
Contributor
Author
There was a problem hiding this comment.
just moved from another location, not new
chrisbmar
commented
Mar 19, 2026
Comment on lines
-54
to
-71
| <KibanaPageTemplate | ||
| offset={0} | ||
| restrictWidth={false} | ||
| data-test-subj="agentBuilderPageConversations" | ||
| grow={false} | ||
| panelled={false} | ||
| mainProps={{ | ||
| css: mainStyles, | ||
| }} | ||
| responsive={[]} | ||
| > | ||
| <KibanaPageTemplate.Header | ||
| css={headerStyles} | ||
| bottomBorder={false} | ||
| aria-label={labels.header} | ||
| paddingSize="m" | ||
| responsive={false} | ||
| > |
Contributor
Author
There was a problem hiding this comment.
These components should not be here anymore, they now live in the AppLayout
chrisbmar
commented
Mar 19, 2026
Comment on lines
+144
to
+153
| {/* <EuiFlexItem grow={false}> | ||
| <EuiButtonIcon | ||
| color="text" | ||
| iconType="search" | ||
| size="s" | ||
| display="base" | ||
| aria-label={searchConversationsLabel} | ||
| onClick={() => {}} | ||
| /> | ||
| </EuiFlexItem> */} |
Contributor
Author
There was a problem hiding this comment.
Out of scope to implement the search functionality via a modal rn
chrisbmar
commented
Mar 19, 2026
Comment on lines
+36
to
+40
| const sidebarStyles = css` | ||
| @media (max-width: ${euiTheme.breakpoint.m - 1}px) { | ||
| display: none; | ||
| } | ||
| `; |
Contributor
Author
There was a problem hiding this comment.
removes the sidebar at the correct breakpoint, same as how discover do it
chrisbmar
commented
Mar 19, 2026
Comment on lines
+29
to
+34
| const onKeyDown = useCallback((event: KeyboardEvent) => { | ||
| if ((event.code === 'Period' || event.key === '.') && (isMac ? event.metaKey : event.ctrlKey)) { | ||
| event.preventDefault(); | ||
| setIsCondensed((v) => !v); | ||
| } | ||
| }, []); |
Contributor
Author
There was a problem hiding this comment.
keyboard shortcut for opening and closing the sidebar
Contributor
Author
Screen.Recording.2026-03-19.at.18.37.40.mov |
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]
Historycc @chrisbmar |
SiddharthMantri
approved these changes
Mar 19, 2026
Contributor
SiddharthMantri
left a comment
SiddharthMantri
left a comment
There was a problem hiding this comment.
Tested locally. LGTM on stateful too. Noticed that the sidebar disappears on smaller screens, but maybe we don't need to optimize for narrow screens? attached screenshot for reference
chrisbmar
merged commit 53f5bfd
into
elastic:ab-agent-centric-ux-feature-branch
12 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wip - no need for review yet