Skip to content

[ResponseOps][Connectors] Increase the test coverage for connector schema validation performed by the framework#258503

Merged
georgianaonoleata1904 merged 15 commits intoelastic:mainfrom
georgianaonoleata1904:connector-schema-validation-framework
Mar 26, 2026
Merged

[ResponseOps][Connectors] Increase the test coverage for connector schema validation performed by the framework#258503
georgianaonoleata1904 merged 15 commits intoelastic:mainfrom
georgianaonoleata1904:connector-schema-validation-framework

Conversation

@georgianaonoleata1904
Copy link
Copy Markdown
Contributor

@georgianaonoleata1904 georgianaonoleata1904 commented Mar 19, 2026 •
edited by kibanamachine
Loading

Closes #251653

Summary

  • Added unit tests across the actions framework to ensure schema validation behavior is stable against schema parser changes or upgrades.

@georgianaonoleata1904 georgianaonoleata1904 self-assigned this Mar 19, 2026
@georgianaonoleata1904 georgianaonoleata1904 added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// backport:version Backport to applied version labels v9.4.0 v9.3.3 labels Mar 19, 2026
@georgianaonoleata1904 georgianaonoleata1904 marked this pull request as ready for review March 20, 2026 11:45
@georgianaonoleata1904 georgianaonoleata1904 requested a review from a team as a code owner March 20, 2026 11:45
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 20, 2026

Pinging @elastic/response-ops (Team:ResponseOps)

adcoelho
adcoelho reviewed Mar 20, 2026
View reviewed changes
adcoelho
adcoelho reviewed Mar 25, 2026
View reviewed changes
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 26, 2026 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] affected Scout: [ security / security_solution ] plugin / local-serverless-security_complete - Entity analytics management page - Engine Status tab - Engine Status tab appears after enabling entity analytics and shows components table
  • [job] [logs] Jest Integration Tests #6 / scripts/generate_plugin builds a generated plugin into a viable archive

History

cc @georgianaonoleata1904

@georgianaonoleata1904 georgianaonoleata1904 merged commit 995465b into elastic:main Mar 26, 2026
18 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 26, 2026

Starting backport for target branches: 9.3

https://github.com/elastic/kibana/actions/runs/23595174951

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 26, 2026

💔 All backports failed

Status Branch Result
❌ 9.3 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 258503

Questions ?

Please refer to the Backport tool documentation

georgianaonoleata1904 added a commit to georgianaonoleata1904/kibana that referenced this pull request Mar 26, 2026
@georgianaonoleata1904
[ResponseOps][Connectors] Increase the test coverage for connector sc…
5723499 
…hema validation performed by the framework (elastic#258503)

Closes elastic#251653

## Summary

- Added unit tests across the actions framework to ensure schema
validation behavior is stable against schema parser changes or upgrades.

(cherry picked from commit 995465b)

# Conflicts:
#	src/platform/packages/shared/kbn-connector-specs/src/lib/generate_secrets_schema_from_spec.test.ts
#	x-pack/platform/plugins/shared/actions/server/application/connector/methods/create/create.test.ts
#	x-pack/platform/plugins/shared/actions/server/application/connector/methods/get/get.test.ts
#	x-pack/platform/plugins/shared/actions/server/application/connector/methods/update/update.test.ts
#	x-pack/platform/plugins/shared/actions/server/lib/validate_with_schema.test.ts
@georgianaonoleata1904 georgianaonoleata1904 mentioned this pull request Mar 26, 2026
Merged
@georgianaonoleata1904
Copy link
Copy Markdown
Contributor Author

georgianaonoleata1904 commented Mar 26, 2026

💚 All backports created successfully

Status Branch Result
✅ 9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

shahargl pushed a commit to shahargl/kibana that referenced this pull request Mar 26, 2026
@georgianaonoleata1904 @shahargl
[ResponseOps][Connectors] Increase the test coverage for connector sc…
b8d214d 
…hema validation performed by the framework (elastic#258503)

Closes elastic#251653

## Summary

- Added unit tests across the actions framework to ensure schema
validation behavior is stable against schema parser changes or upgrades.
@kibanamachine kibanamachine mentioned this pull request Mar 26, 2026
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 30, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 30, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @georgianaonoleata1904

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 31, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @georgianaonoleata1904

jeramysoucy pushed a commit to jeramysoucy/kibana that referenced this pull request Apr 1, 2026
@georgianaonoleata1904 @jeramysoucy
[ResponseOps][Connectors] Increase the test coverage for connector sc…
71d3b6a 
…hema validation performed by the framework (elastic#258503)

Closes elastic#251653

## Summary

- Added unit tests across the actions framework to ensure schema
validation behavior is stable against schema parser changes or upgrades.
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 1, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @georgianaonoleata1904

paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Apr 2, 2026
@georgianaonoleata1904 @paulinashakirova
[ResponseOps][Connectors] Increase the test coverage for connector sc…
c581bb8 
…hema validation performed by the framework (elastic#258503)

Closes elastic#251653

## Summary

- Added unit tests across the actions framework to ensure schema
validation behavior is stable against schema parser changes or upgrades.
georgianaonoleata1904 added a commit that referenced this pull request Apr 2, 2026
@georgianaonoleata1904
[9.3] [ResponseOps][Connectors] Increase the test coverage for connec…
6211530 
…tor schema validation performed by the framework (#258503) (#259774)

# Backport

This will backport the following commits from `main` to `9.3`:
- [[ResponseOps][Connectors] Increase the test coverage for connector
schema validation performed by the framework
(#258503)](#258503)

<!--- Backport version: 11.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Georgiana-Andreea
Onoleață","email":"georgiana.onoleata@elastic.co"},"sourceCommit":{"committedDate":"2026-03-26T12:49:38Z","message":"[ResponseOps][Connectors]
Increase the test coverage for connector schema validation performed by
the framework (#258503)\n\nCloses
https://github.com/elastic/kibana/issues/251653\n\n## Summary\n\n- Added
unit tests across the actions framework to ensure schema\nvalidation
behavior is stable against schema parser changes or
upgrades.","sha":"995465be0cce243def0a0e29b580d758791cf251","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport:version","v9.4.0","v9.3.3"],"title":"[ResponseOps][Connectors]
Increase the test coverage for connector schema validation performed by
the
framework","number":258503,"url":"https://github.com/elastic/kibana/pull/258503","mergeCommit":{"message":"[ResponseOps][Connectors]
Increase the test coverage for connector schema validation performed by
the framework (#258503)\n\nCloses
https://github.com/elastic/kibana/issues/251653\n\n## Summary\n\n- Added
unit tests across the actions framework to ensure schema\nvalidation
behavior is stable against schema parser changes or
upgrades.","sha":"995465be0cce243def0a0e29b580d758791cf251"}},"sourceBranch":"main","suggestedTargetBranches":["9.3"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/258503","number":258503,"mergeCommit":{"message":"[ResponseOps][Connectors]
Increase the test coverage for connector schema validation performed by
the framework (#258503)\n\nCloses
https://github.com/elastic/kibana/issues/251653\n\n## Summary\n\n- Added
unit tests across the actions framework to ensure schema\nvalidation
behavior is stable against schema parser changes or
upgrades.","sha":"995465be0cce243def0a0e29b580d758791cf251"}},{"branch":"9.3","label":"v9.3.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adcoelho adcoelho adcoelho approved these changes

Assignees

@georgianaonoleata1904 georgianaonoleata1904

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.3.3 v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ResponseOps][Connectors] Increase the test coverage for connector schema validation performed by the framework

4 participants

@georgianaonoleata1904 @elasticmachine @kibanamachine @adcoelho