Merged
Conversation
…esses page background color
cqliu1
added
review
v7.0.0
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
💚 Build Succeeded |
w33ble
suggested changes
Nov 16, 2018
Contributor
w33ble
left a comment
w33ble
left a comment
There was a problem hiding this comment.
Functionally LGTM, couple small change requests though.
| return !state || !renderable; | ||
| }, renderComponent(Loading)), | ||
|
|
||
| }, renderComponent(({ backgroundColor }) => <Loading backgroundColor={backgroundColor} />)), |
Contributor
There was a problem hiding this comment.
Add backgroundColor to the propTypes too.
| }); | ||
|
|
||
| export const Loading = connect(mapStateToProps)(Component); | ||
| export const Loading = pure(Component); |
Contributor
There was a problem hiding this comment.
I think we need a defaultValue in loading.js for the backgroundColor prop. It's not a required prop, and it'll be null otherwise. You could also make it a required prop...
Contributor
Author
|
@w33ble I added a |
Contributor
💚 Build Succeeded |
This was referenced Nov 19, 2018
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Nov 19, 2018
* Removes redux selectors from loading component. Fixes how loading accesses page background color * Fixed props
cqliu1
added a commit
that referenced
this pull request
Nov 19, 2018
cqliu1
added a commit
that referenced
this pull request
Nov 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re #25342.
This is a permanent fix to the bug that was crashing kibana when you upload images.
The cause was the
Loadingcomponent was trying to access redux from inside one of the arg forms, which don't have access to the redux store.This removes the redux selector from the Loading component and moves it higher up to a component that has access to redux and passes that page background color into the loading component as a prop.