[EDR Workflows][Artifact transfer 4] UI fine tuning #257983
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| /** | ||
| * Helper function to extract list ids from an imported file. Does not check whether | ||
| * the file is valid, just tries to find list_id fields, so it can be used on UI side | ||
| * as a pre-check to ensure only the correct artifact type is being imported. | ||
| * | ||
| * @param file {File} file to extract list ids from | ||
| * @returns {Promise<Set<string>>} set of list ids found in the file | ||
| */ | ||
| export const parseListIdsFromImportedFile = async (file: File): Promise<Set<string>> => | ||
| (await file.text()) | ||
| .split('\n') | ||
| .filter((x) => x.trim() !== '') | ||
| .reduce((acc, line) => { | ||
| try { | ||
| const parsedItem = JSON.parse(line); | ||
|
|
||
| if (parsedItem.list_id) { | ||
| acc.add(parsedItem.list_id); | ||
| } | ||
| } catch (e) { | ||
| // ignore parsing errors, the API will handle them and return an error for the line | ||
| } | ||
|
|
||
| return acc; | ||
| }, new Set<string>()); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
| import React from 'react'; | ||
| import { i18n } from '@kbn/i18n'; | ||
| import { | ||
| EuiButton, | ||
| EuiButtonEmpty, | ||
| EuiModal, | ||
| EuiModalBody, | ||
| EuiModalFooter, | ||
| EuiModalHeader, | ||
| EuiModalHeaderTitle, | ||
| EuiText, | ||
| useGeneratedHtmlId, | ||
| } from '@elastic/eui'; | ||
| import { useTestIdGenerator } from '../../../hooks/use_test_id_generator'; | ||
|
|
||
| interface ArtifactImportConfirmModalProps { | ||
| onCancel: () => void; | ||
| onConfirm: () => void; | ||
| isLoading: boolean; | ||
| 'data-test-subj'?: string; | ||
| } | ||
|
|
||
| export const ArtifactImportConfirmModal: React.FC<ArtifactImportConfirmModalProps> = ({ | ||
| onCancel, | ||
| onConfirm, | ||
| isLoading, | ||
| 'data-test-subj': dataTestSubj = 'artifactImportConfirmModal', | ||
| }) => { | ||
| const getTestId = useTestIdGenerator(dataTestSubj); | ||
| const modalTitleId = useGeneratedHtmlId(); | ||
|
|
||
| return ( | ||
| <EuiModal onClose={onCancel} aria-labelledby={modalTitleId} data-test-subj={getTestId()}> | ||
| <EuiModalHeader> | ||
| <EuiModalHeaderTitle id={modalTitleId}> | ||
| {i18n.translate('xpack.securitySolution.artifactListPage.importConfirmModal.title', { | ||
| defaultMessage: 'Import artifacts?', | ||
| })} | ||
| </EuiModalHeaderTitle> | ||
| </EuiModalHeader> | ||
| <EuiModalBody> | ||
| <EuiText> | ||
| <p> | ||
| {i18n.translate('xpack.securitySolution.artifactListPage.importConfirmModal.info', { | ||
| defaultMessage: | ||
| "This will add new artifacts to your list. If an artifact you're importing already exists, the existing version will be kept, and the import of that artifact will be skipped.", | ||
| })} | ||
| </p> | ||
| </EuiText> | ||
| </EuiModalBody> | ||
| <EuiModalFooter> | ||
| <EuiButtonEmpty onClick={onCancel} data-test-subj={getTestId('cancelButton')}> | ||
| {i18n.translate( | ||
| 'xpack.securitySolution.artifactListPage.importConfirmModal.cancelButtonTitle', | ||
| { defaultMessage: 'Cancel' } | ||
| )} | ||
| </EuiButtonEmpty> | ||
|
|
||
| <EuiButton | ||
| fill | ||
| color="primary" | ||
| onClick={onConfirm} | ||
| isLoading={isLoading} | ||
| data-test-subj={getTestId('confirmButton')} | ||
| > | ||
| {i18n.translate( | ||
| 'xpack.securitySolution.artifactListPage.importConfirmModal.confirmButtonTitle', | ||
| { defaultMessage: 'Import' } | ||
| )} | ||
| </EuiButton> | ||
| </EuiModalFooter> | ||
| </EuiModal> | ||
| ); | ||
| }; | ||
|
|
||
| ArtifactImportConfirmModal.displayName = 'ArtifactImportConfirmModal'; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a good idea? To load the entire file into memory in the browser?
My suggestions if you really do need to go through the file in the browser:
File#stream()AbortController? so that if the user navigates away from the page while this is ongoing, you can efficiently abort?IMO - this type of check should happen on the server at the API level and not in the browser. Files could be large
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on browser vs server: I agree, however, as we only have one API for both shared exception list pages and endpoint artifact pages, and that API now accepts shared exception lists and endpoint exceptions, blocking endpoint exceptions on it (e.g. by adding a query parameter) would be a breaking change. I added this quick check to avoid that.
on performance: as far as i understood, on modern browsers this shouldn't be an issue. import API allows a maximum of 10k items to be imported, one item is 600-800 byte, depending on the type, so calculating with 1kB per item is still 10MB, not much.
created a test file 13k items, sized 8.6MB, it took 30-45ms on my oldish macbook both in Chrome and Firefox, with the following result anyway:
so for now, I think we should be safe with this approach on this feature, that's probably not used extensively in daily routine of the users, without adding more complexity by using streams