[Infra] Fix hosts view crashing on load#257893
Merged
AlejandroFrndz merged 6 commits intoMar 16, 2026
Merged
Conversation
Contributor
⏳ Build in-progress, with failures
Failed CI Steps |
Contributor
Author
|
/ci |
AlejandroFrndz
added
Team:obs-presentation
Contributor
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
cauemarcondes
approved these changes
Mar 16, 2026
Contributor
cauemarcondes
left a comment
cauemarcondes
left a comment
There was a problem hiding this comment.
Obs UI changes LGTM
rmyz
approved these changes
Mar 16, 2026
Contributor
rmyz
left a comment
rmyz
left a comment
There was a problem hiding this comment.
LGTM, tested and works fine, thanks for the fix!
sbelastic
requested changes
Mar 16, 2026
Contributor
sbelastic
left a comment
sbelastic
left a comment
There was a problem hiding this comment.
@AlejandroFrndz I would just ask you to check if the skipped tests are now working with these fixes and un-skipped them if that's the case.
Besides that LGTM.
Contributor
Author
Unfortunately, 4 tests in the suite are still failing even after the fix. Nevertheless I did confirm tests do fail without the fix as expected because the page is crashed. I'm not sure why these didn't flag the issues in the CI for #254079 before it was merged. We should maybe include tasks in any upcoming maintenance to look at these tests and migrate them to scout so they're more reliable |
sbelastic
approved these changes
Mar 16, 2026
sorenlouv
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Summary Closes #257867 This PR introduces a fix to prevent the infra plugin hosts view page from crashing on load. Both parts of the problem are addressed ### Control type value miss match 1. Changes in `x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/search_bar/control_panels_config.ts` ensure urls are built with correct values and future proofs the page by replacing hardcoded strings with imported constants 2. Changes in `x-pack/solutions/observability/plugins/observability_shared/public/hooks/use_control_panels_url_state.ts` ensure any existing URL using old values for types can be handled and converted to the new model. This is to prevent users that might still be using old urls after upgrading (i.e. bookmars) from seeing broken filter controls ### Embeddables error leading to a page crash Changes in `x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/search_bar/controls_content.tsx` ensure the hosts view page doesn't crash entirely if filter control embeddables run into critical issues. If a situation like this were to happen in the future, the page will render error UI in place of the filter controls. Page functionality will be degraded but we avoid a full page crash and maintain other page functions not directly related to embeddables ### Tests Updated/new tests for this plugin will be created in a follow up PR to ensure issues like this are caught by CI in the future before reaching production environments --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Mar 18, 2026
## Summary Closes elastic#257867 This PR introduces a fix to prevent the infra plugin hosts view page from crashing on load. Both parts of the problem are addressed ### Control type value miss match 1. Changes in `x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/search_bar/control_panels_config.ts` ensure urls are built with correct values and future proofs the page by replacing hardcoded strings with imported constants 2. Changes in `x-pack/solutions/observability/plugins/observability_shared/public/hooks/use_control_panels_url_state.ts` ensure any existing URL using old values for types can be handled and converted to the new model. This is to prevent users that might still be using old urls after upgrading (i.e. bookmars) from seeing broken filter controls ### Embeddables error leading to a page crash Changes in `x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/search_bar/controls_content.tsx` ensure the hosts view page doesn't crash entirely if filter control embeddables run into critical issues. If a situation like this were to happen in the future, the page will render error UI in place of the filter controls. Page functionality will be degraded but we avoid a full page crash and maintain other page functions not directly related to embeddables ### Tests Updated/new tests for this plugin will be created in a follow up PR to ensure issues like this are caught by CI in the future before reaching production environments --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
## Summary Closes elastic#257867 This PR introduces a fix to prevent the infra plugin hosts view page from crashing on load. Both parts of the problem are addressed ### Control type value miss match 1. Changes in `x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/search_bar/control_panels_config.ts` ensure urls are built with correct values and future proofs the page by replacing hardcoded strings with imported constants 2. Changes in `x-pack/solutions/observability/plugins/observability_shared/public/hooks/use_control_panels_url_state.ts` ensure any existing URL using old values for types can be handled and converted to the new model. This is to prevent users that might still be using old urls after upgrading (i.e. bookmars) from seeing broken filter controls ### Embeddables error leading to a page crash Changes in `x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/search_bar/controls_content.tsx` ensure the hosts view page doesn't crash entirely if filter control embeddables run into critical issues. If a situation like this were to happen in the future, the page will render error UI in place of the filter controls. Page functionality will be degraded but we avoid a full page crash and maintain other page functions not directly related to embeddables ### Tests Updated/new tests for this plugin will be created in a follow up PR to ensure issues like this are caught by CI in the future before reaching production environments --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #257867
This PR introduces a fix to prevent the infra plugin hosts view page from crashing on load. Both parts of the problem are addressed
Control type value miss match
x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/search_bar/control_panels_config.tsensure urls are built with correct values and future proofs the page by replacing hardcoded strings with imported constantsx-pack/solutions/observability/plugins/observability_shared/public/hooks/use_control_panels_url_state.tsensure any existing URL using old values for types can be handled and converted to the new model. This is to prevent users that might still be using old urls after upgrading (i.e. bookmars) from seeing broken filter controlsEmbeddables error leading to a page crash
Changes in
x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/search_bar/controls_content.tsxensure the hosts view page doesn't crash entirely if filter control embeddables run into critical issues. If a situation like this were to happen in the future, the page will render error UI in place of the filter controls. Page functionality will be degraded but we avoid a full page crash and maintain other page functions not directly related to embeddablesTests
Updated/new tests for this plugin will be created in a follow up PR to ensure issues like this are caught by CI in the future before reaching production environments