-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Observability Onboarding] Add data detection & loading indicators to onboarding flows #257870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rStelmach
merged 33 commits into
elastic:main
from
rStelmach:5296-observability-onboarding-add-data-detection-loading-indicators-to-onboarding-flows
Apr 7, 2026
Merged
Changes from 26 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
699aa42
k8s otel flow
rStelmach d73a7c4
add otel host flow
rStelmach 5384013
apm otel flow
rStelmach 8032e28
cloud-forwarder
rStelmach ac24ca3
Merge branch 'main' into 5296-observability-onboarding-add-data-detec…
rStelmach a433a87
add runtime field for k8s logs essentials + wired flow
rStelmach 4b99f82
dedup + cleanup
rStelmach 3bd3dbd
cleanup
rStelmach 1cace10
update ensemble tests
rStelmach 449ae88
Merge branch 'main' into 5296-observability-onboarding-add-data-detec…
rStelmach 533244b
Merge branch 'main' into 5296-observability-onboarding-add-data-detec…
rStelmach 384d8c7
harden data detection
rStelmach 926badd
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 2f1f077
Merge branch 'main' into 5296-observability-onboarding-add-data-detec…
rStelmach f93c257
Merge branch 'main' into 5296-observability-onboarding-add-data-detec…
rStelmach 7c32546
remove `any`
rStelmach 97c52df
Merge branch 'main' into 5296-observability-onboarding-add-data-detec…
rStelmach d7f978a
address comments, resolve CI problems
rStelmach 40abee3
new approach for otel apm
rStelmach fe20160
Merge branch 'main' into 5296-observability-onboarding-add-data-detec…
rStelmach b4ed90a
Merge branch 'main' into 5296-observability-onboarding-add-data-detec…
rStelmach 9889a83
Merge branch 'main' into 5296-observability-onboarding-add-data-dete…
rStelmach 8079686
fix K8s has-data timeout on serverless by scoping runtime mapping to …
rStelmach 66f5cdb
Merge branch 'main' into 5296-observability-onboarding-add-data-detec…
rStelmach 6c73c8d
fix K8s has-data timeout on serverless by dropping runtime mapping fo…
rStelmach 9ec039b
detect already flowing data, disable detection if true
rStelmach 3ba7dd1
Changes from node scripts/lint_ts_projects --fix
kibanamachine c4a01c3
Changes from node scripts/regenerate_moon_projects.js --update
kibanamachine 1e991e5
address comments, remove window blur action when preexisting data is…
rStelmach 03b17cd
Merge branch 'main' into 5296-observability-onboarding-add-data-detec…
rStelmach f076ee0
widen pre-existing data window and gate bypass on wired streams
rStelmach 518df1c
Merge branch 'main' into 5296-observability-onboarding-add-data-detec…
flash1293 477be11
add precheck for APM otel flow
rStelmach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -89,12 +89,24 @@ test('Otel Kubernetes', async ({ | |
| fs.writeFileSync(outputPath, codeSnippet); | ||
|
|
||
| /** | ||
| * There is no explicit data ingest indication | ||
| * in the flow, so we need to rely on a timeout. | ||
| * 5 minutes should be enough for the stack to be | ||
| * created and to start pushing data. | ||
| * The page waits for the browser window to lose | ||
| * focus as a signal to start checking for incoming data | ||
| */ | ||
| await page.waitForTimeout(5 * 60000); | ||
| await page.evaluate('window.dispatchEvent(new Event("blur"))'); | ||
|
|
||
| /** | ||
| * Wait for the data received indicator to appear. | ||
| * The flow now uses DataIngestStatus which polls for data | ||
| * after the blur event and shows "We are monitoring your cluster" | ||
| * once both logs and metrics have arrived. | ||
| */ | ||
| await otelKubernetesFlowPage.assertDataReceivedIndicator(); | ||
|
|
||
| /** | ||
| * Additional buffer to ensure data has propagated | ||
| * to dashboards and Discover before navigating. | ||
| */ | ||
| await page.waitForTimeout(2 * 60000); | ||
|
Comment on lines
+105
to
+109
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove unconditional 2-minute sleep. Line 109 introduces a fixed 120s delay on every run, which inflates suite time and still isn’t a deterministic readiness check. Proposed fix- await page.waitForTimeout(2 * 60000);
+ const readinessLinkTestId =
+ useWiredStreams || isLogsEssentialsMode
+ ? 'observabilityOnboardingDataIngestStatusActionLink-logs'
+ : 'observabilityOnboardingDataIngestStatusActionLink-kubernetes_otel-cluster-overview';
+ await page.getByTestId(readinessLinkTestId).waitFor({
+ state: 'visible',
+ timeout: 2 * 60_000,
+ });🤖 Prompt for AI Agents |
||
|
|
||
| /** | ||
| * Wired streams only reroutes logs (to logs.otel); metrics and traces are | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid fixed 2-minute buffer; wait on branch-specific readiness instead.
Line 76 adds a static delay that slows all runs and is still less reliable than condition-based waiting.
Proposed fix
🤖 Prompt for AI Agents