[Maps] Do not patch maps calls with local project_routing#257706
[Maps] Do not patch maps calls with local project_routing#257706mbondyra merged 5 commits intoelastic:mainfrom
Conversation
mbondyra
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
lukeelmers
added
bug
| closePopover(); | ||
| }, | ||
| }, | ||
| { |
There was a problem hiding this comment.
Should commented out code just be removed?
There was a problem hiding this comment.
I'd rather keep it - they have be suported for GA so it's gonna be just one - two month of this code to live as a comment and less work in the future. It's not like the feature that we'll forget about, it is planned to add this (just not ready from cloud side).
| method: 'POST', | ||
| path, | ||
| body, | ||
| querystring: { project_routing: '_alias:_origin' }, |
There was a problem hiding this comment.
Can you explain this change?
There was a problem hiding this comment.
What Rudolf did in his PR (linked in the description) is patching all the routes that should have project_routing always set on _alias:_origin. But patching this one was a mistake - we actually don't want this route to be set to local, because maps support cps so the setting should be instead taken from cps picker and then propagated down to body of this request. This has already been working, but the change from the linked PR broke it (I didn't notice when approving).
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
CPS utils changes LGTM (just commented out code). But it would be great if we have an issue for the link, to also mention it at the comments.
Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
## Summary 1. In this one: #256456 we accidentally patched Maps mvt routes with only supporting local project routing, but we shouldn't have, as CPS is supported on Maps (the setting should be taken from the project picker) 2. In this PR I also removed a setting from the cps picker, since it cannot be linked for tech preview <img width="932" height="263" alt="Screenshot 2026-03-13 at 16 41 35" src="https://github.com/user-attachments/assets/ec12dcf5-3a9d-4597-bda6-1573b4f9247d" />
…7706) ## Summary 1. In this one: elastic#256456 we accidentally patched Maps mvt routes with only supporting local project routing, but we shouldn't have, as CPS is supported on Maps (the setting should be taken from the project picker) 2. In this PR I also removed a setting from the cps picker, since it cannot be linked for tech preview <img width="932" height="263" alt="Screenshot 2026-03-13 at 16 41 35" src="https://github.com/user-attachments/assets/ec12dcf5-3a9d-4597-bda6-1573b4f9247d" />
7 participants
Summary
In this one: Convert transport.request() to typed ES client methods #256456 we accidentally patched Maps mvt routes with only supporting local project routing, but we shouldn't have, as CPS is supported on Maps (the setting should be taken from the project picker)
In this PR I also removed a setting from the cps picker, since it cannot be linked for tech preview