add comment about docvalue for each date fields in getComputedFields#25725
Merged
nreese merged 1 commit intoelastic:masterfrom Nov 19, 2018
Merged
add comment about docvalue for each date fields in getComputedFields#25725nreese merged 1 commit intoelastic:masterfrom
nreese merged 1 commit intoelastic:masterfrom
Conversation
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Nov 19, 2018
nreese
added a commit
that referenced
this pull request
Nov 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip ci]
getComputedFields adds a docvalue to docvalue_feilds for each date field in an index pattern. This PR just adds a comment explaining why this happens. The old comment for getComputedFields was a copy paste error from IndexPatternsFlattenHitProvider.