Rework cascade internal store initialization to be data-driven from the provider#257220
Merged
Conversation
Contributor
Author
|
/ci |
eokoneyo
added
Team:SharedUX
Contributor
Author
|
/ci |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
/ci |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @eokoneyo |
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
kowalczyk-krzysztof
approved these changes
Mar 13, 2026
eokoneyo
added
backport:skip
Contributor
Author
|
@elasticmachine merge upstream |
sorenlouv
pushed a commit
that referenced
this pull request
Mar 17, 2026
…he provider (#257220) ### Summary - Lifts the `data` prop from `DataCascadeImpl` up to `DataCascadeProvider`, making the store the single source of truth for cascade group nodes from initialization onward. - Introduces a `useEffect` synchronization in the provider that detects external changes to `data` or `cascadeGroups` and resets the store (clearing derived table/leaf state) via a new internal `_setStoreState` action, ensuring the cascade re-renders correctly when its input data changes. - Renames the `setInitialState` reducer to `setInitialGroupNodes` for clarity, and adds a `_setStoreState` reducer (hidden from context consumers) that performs a full state reset when the source data shape changes. ### Changes - **`DataCascadeProvider` (`store_provider/index.tsx`)**: Now accepts a required `data` prop, builds the initial store state via `useMemo`, and synchronizes external prop changes through `useEffect`. The context value is memoized, and the `_setStoreState` action is excluded from the consumer-facing type. - **`DataCascadeImpl` / `types.ts`**: Removed the `data` prop from the impl component and its type definition; the table hook now reads `groupNodes` directly from the store. - **`components/index.tsx`**: Passes `data` to `DataCascadeProvider` instead of `DataCascadeImpl`; adds `data` to the memoization dependency array. - **`store_provider/reducers.ts`**: Added `_setStoreState` reducer (resets table, leafNodes, groupNodes, columns); renamed `setInitialState` to `setInitialGroupNodes`; removed an unnecessary spread in `setRowGroupNodeData`. - **`store_provider/store.ts`**: Relaxed the store state type constraint from `Record<string, unknown>` to `object`; simplified the `state` return (removed getter indirection). - **`useCascadeTable` (`lib/core/table/index.tsx`)**: Removed the `initialData` parameter; data is now read from the store via `useDataCascadeState`. - **Tests**: Updated all test files to pass the required `data` prop to `DataCascadeProvider`; updated reducer test to use the renamed `setInitialGroupNodes`. <!-- ### Test plan - [ ] Existing unit tests pass (`yarn test:jest` for the `document_data_cascade` package) - [ ] Verify cascade renders correctly with initial data provided through the provider - [ ] Verify cascade re-renders when external `data` or `cascadeGroups` props change (store resets derived state) - [ ] Verify `_setStoreState` is not accessible to context consumers outside the provider ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Mar 18, 2026
…he provider (elastic#257220) ### Summary - Lifts the `data` prop from `DataCascadeImpl` up to `DataCascadeProvider`, making the store the single source of truth for cascade group nodes from initialization onward. - Introduces a `useEffect` synchronization in the provider that detects external changes to `data` or `cascadeGroups` and resets the store (clearing derived table/leaf state) via a new internal `_setStoreState` action, ensuring the cascade re-renders correctly when its input data changes. - Renames the `setInitialState` reducer to `setInitialGroupNodes` for clarity, and adds a `_setStoreState` reducer (hidden from context consumers) that performs a full state reset when the source data shape changes. ### Changes - **`DataCascadeProvider` (`store_provider/index.tsx`)**: Now accepts a required `data` prop, builds the initial store state via `useMemo`, and synchronizes external prop changes through `useEffect`. The context value is memoized, and the `_setStoreState` action is excluded from the consumer-facing type. - **`DataCascadeImpl` / `types.ts`**: Removed the `data` prop from the impl component and its type definition; the table hook now reads `groupNodes` directly from the store. - **`components/index.tsx`**: Passes `data` to `DataCascadeProvider` instead of `DataCascadeImpl`; adds `data` to the memoization dependency array. - **`store_provider/reducers.ts`**: Added `_setStoreState` reducer (resets table, leafNodes, groupNodes, columns); renamed `setInitialState` to `setInitialGroupNodes`; removed an unnecessary spread in `setRowGroupNodeData`. - **`store_provider/store.ts`**: Relaxed the store state type constraint from `Record<string, unknown>` to `object`; simplified the `state` return (removed getter indirection). - **`useCascadeTable` (`lib/core/table/index.tsx`)**: Removed the `initialData` parameter; data is now read from the store via `useDataCascadeState`. - **Tests**: Updated all test files to pass the required `data` prop to `DataCascadeProvider`; updated reducer test to use the renamed `setInitialGroupNodes`. <!-- ### Test plan - [ ] Existing unit tests pass (`yarn test:jest` for the `document_data_cascade` package) - [ ] Verify cascade renders correctly with initial data provided through the provider - [ ] Verify cascade re-renders when external `data` or `cascadeGroups` props change (store resets derived state) - [ ] Verify `_setStoreState` is not accessible to context consumers outside the provider ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
…he provider (elastic#257220) ### Summary - Lifts the `data` prop from `DataCascadeImpl` up to `DataCascadeProvider`, making the store the single source of truth for cascade group nodes from initialization onward. - Introduces a `useEffect` synchronization in the provider that detects external changes to `data` or `cascadeGroups` and resets the store (clearing derived table/leaf state) via a new internal `_setStoreState` action, ensuring the cascade re-renders correctly when its input data changes. - Renames the `setInitialState` reducer to `setInitialGroupNodes` for clarity, and adds a `_setStoreState` reducer (hidden from context consumers) that performs a full state reset when the source data shape changes. ### Changes - **`DataCascadeProvider` (`store_provider/index.tsx`)**: Now accepts a required `data` prop, builds the initial store state via `useMemo`, and synchronizes external prop changes through `useEffect`. The context value is memoized, and the `_setStoreState` action is excluded from the consumer-facing type. - **`DataCascadeImpl` / `types.ts`**: Removed the `data` prop from the impl component and its type definition; the table hook now reads `groupNodes` directly from the store. - **`components/index.tsx`**: Passes `data` to `DataCascadeProvider` instead of `DataCascadeImpl`; adds `data` to the memoization dependency array. - **`store_provider/reducers.ts`**: Added `_setStoreState` reducer (resets table, leafNodes, groupNodes, columns); renamed `setInitialState` to `setInitialGroupNodes`; removed an unnecessary spread in `setRowGroupNodeData`. - **`store_provider/store.ts`**: Relaxed the store state type constraint from `Record<string, unknown>` to `object`; simplified the `state` return (removed getter indirection). - **`useCascadeTable` (`lib/core/table/index.tsx`)**: Removed the `initialData` parameter; data is now read from the store via `useDataCascadeState`. - **Tests**: Updated all test files to pass the required `data` prop to `DataCascadeProvider`; updated reducer test to use the renamed `setInitialGroupNodes`. <!-- ### Test plan - [ ] Existing unit tests pass (`yarn test:jest` for the `document_data_cascade` package) - [ ] Verify cascade renders correctly with initial data provided through the provider - [ ] Verify cascade re-renders when external `data` or `cascadeGroups` props change (store resets derived state) - [ ] Verify `_setStoreState` is not accessible to context consumers outside the provider ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataprop fromDataCascadeImplup toDataCascadeProvider, making the store the single source of truth for cascade group nodes from initialization onward.useEffectsynchronization in the provider that detects external changes todataorcascadeGroupsand resets the store (clearing derived table/leaf state) via a new internal_setStoreStateaction, ensuring the cascade re-renders correctly when its input data changes.setInitialStatereducer tosetInitialGroupNodesfor clarity, and adds a_setStoreStatereducer (hidden from context consumers) that performs a full state reset when the source data shape changes.Changes
DataCascadeProvider(store_provider/index.tsx): Now accepts a requireddataprop, builds the initial store state viauseMemo, and synchronizes external prop changes throughuseEffect. The context value is memoized, and the_setStoreStateaction is excluded from the consumer-facing type.DataCascadeImpl/types.ts: Removed thedataprop from the impl component and its type definition; the table hook now readsgroupNodesdirectly from the store.components/index.tsx: PassesdatatoDataCascadeProviderinstead ofDataCascadeImpl; addsdatato the memoization dependency array.store_provider/reducers.ts: Added_setStoreStatereducer (resets table, leafNodes, groupNodes, columns); renamedsetInitialStatetosetInitialGroupNodes; removed an unnecessary spread insetRowGroupNodeData.store_provider/store.ts: Relaxed the store state type constraint fromRecord<string, unknown>toobject; simplified thestatereturn (removed getter indirection).useCascadeTable(lib/core/table/index.tsx): Removed theinitialDataparameter; data is now read from the store viauseDataCascadeState.dataprop toDataCascadeProvider; updated reducer test to use the renamedsetInitialGroupNodes.