Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
3c9bdbf
combine artifacts into one main page with separate tabs
parkiino Mar 10, 2026
f02eb23
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 10, 2026
79684b6
move old pages into one artifacts navigation link
parkiino Mar 16, 2026
f3c8e89
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 18, 2026
dfd7e80
add artifacts light and dark icon
parkiino Mar 18, 2026
a4f4999
adjust artifact page to fit design
parkiino Mar 19, 2026
28ab571
remove unnecessary files
parkiino Mar 19, 2026
f4a1501
remove unnecessary file, add breadcrumbs
parkiino Mar 19, 2026
04423b0
add unit tests
parkiino Mar 20, 2026
12b2b05
hide timeline for artifacts tabs
parkiino Mar 20, 2026
26d69d3
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 20, 2026
c8ee881
remove docs folder
parkiino Mar 20, 2026
13fbc0e
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine Mar 20, 2026
1ecf551
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 20, 2026
90e3f4f
fix lint errors
parkiino Mar 24, 2026
1bb64ad
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino Mar 24, 2026
1996091
fix i18n
parkiino Mar 24, 2026
d0da48d
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 24, 2026
8437523
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 24, 2026
856e0d7
update cypress test for artifact regrouping
parkiino Mar 24, 2026
77299ab
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 25, 2026
58a40c2
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 25, 2026
9d5707e
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 25, 2026
d5efafe
move artifact no data state vertically so it looks more centered
parkiino Mar 26, 2026
e17d0bc
Wrap artifact tabs in TrackApplicationView
parkiino Mar 26, 2026
c4ccc91
make ontabclick usecallback
parkiino Mar 26, 2026
fcbcbaf
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine Mar 26, 2026
d1ccec6
fix tests wip
parkiino Mar 26, 2026
4f128dc
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino Mar 26, 2026
a7e33bc
bring back show host isolation exception logic
parkiino Mar 27, 2026
66573ea
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 27, 2026
1b2b5f5
remove one more translation
parkiino Mar 27, 2026
c954c33
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine Mar 27, 2026
1d0a1eb
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 30, 2026
8556238
adjust artifact description text, add back individual artifact tab de…
parkiino Mar 30, 2026
4f5309a
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino Mar 30, 2026
3aa96f4
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 30, 2026
a701d14
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine Mar 30, 2026
024d834
make artifacts link dynamic everywhere
parkiino Mar 30, 2026
fab97c2
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino Mar 30, 2026
7e31a31
make default path for tab more robust
parkiino Mar 30, 2026
212be7c
checks for host isolation exception on artifacts page
parkiino Mar 31, 2026
5baa80f
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Mar 31, 2026
b5e78d0
fix nav test
parkiino Mar 31, 2026
c3be77f
fix merge errors
parkiino Mar 31, 2026
52c7227
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine Mar 31, 2026
90929e4
fixing merge errors
parkiino Mar 31, 2026
b63f5fd
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino Mar 31, 2026
51311c9
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine Mar 31, 2026
45f49e7
fix flashing assets side menu on artifacts page in serverless
parkiino Apr 2, 2026
bbb081d
restore missing back button
parkiino Apr 2, 2026
6d1f36a
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Apr 2, 2026
f702ad2
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino Apr 2, 2026
540b50b
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Apr 2, 2026
aa6bf12
make experimental features a direct parameter
parkiino Apr 2, 2026
1007f2d
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine Apr 2, 2026
466bfee
make canReadAnyArtifact more robust with experimental features check
parkiino Apr 2, 2026
7369be9
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Apr 2, 2026
854005e
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino Apr 2, 2026
3ee83e2
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine Apr 2, 2026
04d004e
incorporate konrads pr reviews
parkiino Apr 3, 2026
1ca780c
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino Apr 3, 2026
3b87f3c
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Apr 3, 2026
b29ddd9
adjust test mock
parkiino Apr 4, 2026
1dfd650
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino Apr 6, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export enum SecurityPageName {
alerts = 'alerts',
attacks = 'attacks',
aiValue = 'ai_value',
artifacts = 'artifacts',
assetInventory = 'asset_inventory',
attackDiscovery = 'attack_discovery',
blocklist = 'blocklist',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32258,7 +32258,6 @@
"xpack.securitySolution.appLinks.actionHistoryDescription": "Zeigen Sie den Verlauf der auf Hosts ausgeführten Reaktionsmaßnahmen an.",
"xpack.securitySolution.appLinks.alerts": "Alerts",
"xpack.securitySolution.appLinks.attackDiscovery": "Angriffserkennung",
"xpack.securitySolution.appLinks.blocklistDescription": "Schließen Sie unerwünschte Anwendungen von der Ausführung auf Ihren Hosts aus.",
"xpack.securitySolution.appLinks.category.discover": "Discover",
"xpack.securitySolution.appLinks.category.endpoints": "Endpoints",
"xpack.securitySolution.appLinks.category.entityAnalytics": "Entity Analytics",
Expand All @@ -32275,12 +32274,10 @@
"xpack.securitySolution.appLinks.ecsDataQualityDashboardDescription": "Überprüfen Sie die Index-Mappings und Werte auf Kompatibilität mit dem Elastic Common Schema (ECS).",
"xpack.securitySolution.appLinks.endpointsDescription": "Hosts, auf denen Elastic Defend läuft.",
"xpack.securitySolution.appLinks.entityAnalyticsDescription": "Entitätsanalysen, Anomalien und Bedrohungen, um den Monitoring-Bereich einzugrenzen.",
"xpack.securitySolution.appLinks.eventFiltersDescription": "Verhindern Sie, dass Ereignisse mit hohem Volumen oder unerwünschte Ereignisse in Elasticsearch geschrieben werden.",
"xpack.securitySolution.appLinks.exceptions": "Ausnahmelisten",
"xpack.securitySolution.appLinks.exceptionsDescription": "Erstellen und verwalten Sie gemeinsame Ausnahmelisten, um die Erstellung unerwünschter Alarme zu verhindern.",
"xpack.securitySolution.appLinks.explore": "Erkunden",
"xpack.securitySolution.appLinks.getStarted": "Erste Schritte",
"xpack.securitySolution.appLinks.hostIsolationDescription": "Erlauben Sie isolierten Hosts, mit bestimmten IP-Adressen zu kommunizieren.",
"xpack.securitySolution.appLinks.hosts": "Hosts",
"xpack.securitySolution.appLinks.hosts.allHosts": "Alle Hosts",
"xpack.securitySolution.appLinks.hosts.anomalies": "Anomalien",
Expand All @@ -32305,7 +32302,6 @@
"xpack.securitySolution.appLinks.rulesDescription": "Erstellen und verwalten Sie Erkennungsregeln für die Bedrohungserkennung und -Monitoring.",
"xpack.securitySolution.appLinks.timeline.templates": "Vorlagen",
"xpack.securitySolution.appLinks.timelines": "Zeitleisten",
"xpack.securitySolution.appLinks.trustedApplicationsDescription": "Verbessern Sie die Leistung oder mindern Sie Konflikte mit anderen Anwendungen, die auf Ihren Hosts ausgeführt werden.",
"xpack.securitySolution.appLinks.users": "Nutzer",
"xpack.securitySolution.appLinks.users.allUsers": "Alle Nutzer",
"xpack.securitySolution.appLinks.users.anomalies": "Anomalien",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32601,7 +32601,6 @@
"xpack.securitySolution.appLinks.actionHistoryDescription": "Affichez l'historique des actions de réponse effectuées sur les hôtes.",
"xpack.securitySolution.appLinks.alerts": "Alertes",
"xpack.securitySolution.appLinks.attackDiscovery": "Attack discovery",
"xpack.securitySolution.appLinks.blocklistDescription": "Excluez les applications non souhaitées de l'exécution sur vos hôtes.",
"xpack.securitySolution.appLinks.category.cloudSecurity": "Sécurité du cloud",
"xpack.securitySolution.appLinks.category.discover": "Discover",
"xpack.securitySolution.appLinks.category.endpoints": "Points de terminaison",
Expand All @@ -32620,12 +32619,10 @@
"xpack.securitySolution.appLinks.ecsDataQualityDashboardDescription": "Vérifiez la compatibilité des mappings et des valeurs d'index avec Elastic Common Schema (ECS)",
"xpack.securitySolution.appLinks.endpointsDescription": "Hôtes exécutant Elastic Defend.",
"xpack.securitySolution.appLinks.entityAnalyticsDescription": "Analyse d'entités, anomalies et menaces pour limiter la surface de monitoring.",
"xpack.securitySolution.appLinks.eventFiltersDescription": "Excluez les volumes importants ou les événements non souhaités de l'écriture dans Elasticsearch.",
"xpack.securitySolution.appLinks.exceptions": "Listes d'exceptions",
"xpack.securitySolution.appLinks.exceptionsDescription": "Créez et gérez des listes d'exceptions partagées pour empêcher la création d'alertes non souhaitées.",
"xpack.securitySolution.appLinks.explore": "Explorer",
"xpack.securitySolution.appLinks.getStarted": "Premiers pas",
"xpack.securitySolution.appLinks.hostIsolationDescription": "Autorisez les hôtes isolés à communiquer avec des IP spécifiques.",
"xpack.securitySolution.appLinks.hosts": "Hôtes",
"xpack.securitySolution.appLinks.hosts.allHosts": "Tous les hôtes",
"xpack.securitySolution.appLinks.hosts.anomalies": "Anomalies",
Expand All @@ -32651,7 +32648,6 @@
"xpack.securitySolution.appLinks.rulesDescription": "Créez et gérez les règles de détection pour la détection et le monitoring des menaces.",
"xpack.securitySolution.appLinks.timeline.templates": "Modèles",
"xpack.securitySolution.appLinks.timelines": "Chronologies",
"xpack.securitySolution.appLinks.trustedApplicationsDescription": "Améliorez les performances ou réduisez les conflits avec d'autres applications en cours d'exécution sur vos hôtes.",
"xpack.securitySolution.appLinks.users": "Utilisateurs",
"xpack.securitySolution.appLinks.users.allUsers": "Tous les utilisateurs",
"xpack.securitySolution.appLinks.users.anomalies": "Anomalies",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32655,7 +32655,6 @@
"xpack.securitySolution.appLinks.actionHistoryDescription": "ホストで実行された対応アクションの履歴を表示します。",
"xpack.securitySolution.appLinks.alerts": "アラート",
"xpack.securitySolution.appLinks.attackDiscovery": "Attack discovery",
"xpack.securitySolution.appLinks.blocklistDescription": "不要なアプリケーションがホストで実行されないようにします。",
"xpack.securitySolution.appLinks.category.cloudSecurity": "クラウドセキュリティ",
"xpack.securitySolution.appLinks.category.discover": "Discover",
"xpack.securitySolution.appLinks.category.endpoints": "エンドポイント",
Expand All @@ -32674,12 +32673,10 @@
"xpack.securitySolution.appLinks.ecsDataQualityDashboardDescription": "Elastic Common Schema(ECS)との互換性に関してインデックスマッピングと値を確認",
"xpack.securitySolution.appLinks.endpointsDescription": "Elastic Defendを実行しているホスト。",
"xpack.securitySolution.appLinks.entityAnalyticsDescription": "監視面の分野を絞り込むエンティティ分析、異常、脅威。",
"xpack.securitySolution.appLinks.eventFiltersDescription": "大量のイベントや不要なイベントがElasticsearchに書き込まれないようにします。",
"xpack.securitySolution.appLinks.exceptions": "例外リスト",
"xpack.securitySolution.appLinks.exceptionsDescription": "不要なアラートの生成を防止するために、共有例外リストを作成して管理します。",
"xpack.securitySolution.appLinks.explore": "探索",
"xpack.securitySolution.appLinks.getStarted": "はじめて使う",
"xpack.securitySolution.appLinks.hostIsolationDescription": "分離されたホストが特定のIPと通信することを許可します。",
"xpack.securitySolution.appLinks.hosts": "ホスト",
"xpack.securitySolution.appLinks.hosts.allHosts": "すべてのホスト",
"xpack.securitySolution.appLinks.hosts.anomalies": "異常",
Expand All @@ -32705,7 +32702,6 @@
"xpack.securitySolution.appLinks.rulesDescription": "脅威の検出と監視のための検出ルールの作成および管理します。",
"xpack.securitySolution.appLinks.timeline.templates": "テンプレート",
"xpack.securitySolution.appLinks.timelines": "タイムライン",
"xpack.securitySolution.appLinks.trustedApplicationsDescription": "パフォーマンスを改善したり、ホストで実行されている他のアプリケーションとの競合を解消したりします。",
"xpack.securitySolution.appLinks.users": "ユーザー",
"xpack.securitySolution.appLinks.users.allUsers": "すべてのユーザー",
"xpack.securitySolution.appLinks.users.anomalies": "異常",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32638,7 +32638,6 @@
"xpack.securitySolution.appLinks.actionHistoryDescription": "查看在主机上执行的响应操作的历史记录。",
"xpack.securitySolution.appLinks.alerts": "告警",
"xpack.securitySolution.appLinks.attackDiscovery": "Attack Discovery",
"xpack.securitySolution.appLinks.blocklistDescription": "阻止不需要的应用程序在您的主机上运行。",
"xpack.securitySolution.appLinks.category.cloudSecurity": "云安全",
"xpack.securitySolution.appLinks.category.discover": "发现",
"xpack.securitySolution.appLinks.category.endpoints": "终端",
Expand All @@ -32657,12 +32656,10 @@
"xpack.securitySolution.appLinks.ecsDataQualityDashboardDescription": "检查索引映射和值以了解与 Elastic Common Schema (ECS) 的兼容性",
"xpack.securitySolution.appLinks.endpointsDescription": "运行 Elastic Defend 的主机。",
"xpack.securitySolution.appLinks.entityAnalyticsDescription": "用于缩小监测表面积的实体分析、异常和威胁。",
"xpack.securitySolution.appLinks.eventFiltersDescription": "阻止将高数目或非预期事件写入到 Elasticsearch。",
"xpack.securitySolution.appLinks.exceptions": "例外列表",
"xpack.securitySolution.appLinks.exceptionsDescription": "创建并管理共享例外列表以避免创建非预期告警。",
"xpack.securitySolution.appLinks.explore": "浏览",
"xpack.securitySolution.appLinks.getStarted": "入门",
"xpack.securitySolution.appLinks.hostIsolationDescription": "允许隔离的主机与特定 IP 通信。",
"xpack.securitySolution.appLinks.hosts": "主机",
"xpack.securitySolution.appLinks.hosts.allHosts": "所有主机",
"xpack.securitySolution.appLinks.hosts.anomalies": "异常",
Expand All @@ -32688,7 +32685,6 @@
"xpack.securitySolution.appLinks.rulesDescription": "创建和管理检测规则以用于威胁检测和监测。",
"xpack.securitySolution.appLinks.timeline.templates": "模板",
"xpack.securitySolution.appLinks.timelines": "时间线",
"xpack.securitySolution.appLinks.trustedApplicationsDescription": "提高性能或缓解与主机上运行的其他应用程序的冲突。",
"xpack.securitySolution.appLinks.users": "用户",
"xpack.securitySolution.appLinks.users.allUsers": "所有用户",
"xpack.securitySolution.appLinks.users.anomalies": "异常",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ export const i18nStrings = {
defaultMessage: 'Endpoints',
}),
},
artifacts: {
title: i18n.translate('securitySolutionPackages.navLinks.assets.artifacts', {
defaultMessage: 'Artifacts',
}),
},
integrationsCallout: {
title: i18n.translate('securitySolutionPackages.navLinks.assets.integrationsCallout.title', {
defaultMessage: 'Integrations',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,83 +12,81 @@ import { SecurityLinkGroup } from '../link_groups';
import { securityLink } from '../links';
import { i18nStrings } from '../i18n_strings';

export const createAssetsNavigationTree = (core: CoreStart): NodeDefinition => ({
id: SecurityGroupName.assets,
icon: 'display',
title: SecurityLinkGroup[SecurityGroupName.assets].title,
renderAs: 'panelOpener',
children: [
{
link: 'fleet',
title: i18nStrings.assets.fleet.title,
children: [
{
link: 'fleet:agents',
},
{
link: 'fleet:policies',
title: i18nStrings.assets.fleet.policies,
},
{
link: 'fleet:enrollment_tokens',
},
{
link: 'fleet:uninstall_tokens',
},
{
link: 'fleet:data_streams',
},
{
link: 'fleet:settings',
},
],
},
{
id: SecurityPageName.endpoints,
title: i18nStrings.assets.endpoints.title,
children: [
{
id: SecurityPageName.endpoints,
link: securityLink(SecurityPageName.endpoints),
breadcrumbStatus: 'hidden',
},
{
id: SecurityPageName.policies,
link: securityLink(SecurityPageName.policies),
},
{
id: SecurityPageName.trustedApps,
link: securityLink(SecurityPageName.trustedApps),
},
{
id: SecurityPageName.trustedDevices,
link: securityLink(SecurityPageName.trustedDevices),
},
{
id: SecurityPageName.eventFilters,
link: securityLink(SecurityPageName.eventFilters),
},
{
id: SecurityPageName.hostIsolationExceptions,
link: securityLink(SecurityPageName.hostIsolationExceptions),
},
{
id: SecurityPageName.blocklist,
link: securityLink(SecurityPageName.blocklist),
},
{
id: SecurityPageName.endpointExceptions,
link: securityLink(SecurityPageName.endpointExceptions),
},
{
id: SecurityPageName.responseActionsHistory,
link: securityLink(SecurityPageName.responseActionsHistory),
},
{
id: SecurityPageName.scriptLibrary,
link: securityLink(SecurityPageName.scriptLibrary),
},
],
},
],
});
// All artifact tab paths under the security management section.
// Used to keep the Artifacts nav node active regardless of which tab is open,
// since the deep link only points to the first allowed tab path.
const SECURITY_MANAGEMENT_PATH = '/app/security/administration';
const ARTIFACT_TAB_PATHS = [
`${SECURITY_MANAGEMENT_PATH}/trusted_apps`,
`${SECURITY_MANAGEMENT_PATH}/trusted_devices`,
`${SECURITY_MANAGEMENT_PATH}/event_filters`,
`${SECURITY_MANAGEMENT_PATH}/host_isolation_exceptions`,
`${SECURITY_MANAGEMENT_PATH}/blocklist`,
`${SECURITY_MANAGEMENT_PATH}/endpoint_exceptions`,
] as const;

export const createAssetsNavigationTree = (_core: CoreStart): NodeDefinition => {
return {
id: SecurityGroupName.assets,
icon: 'display',
title: SecurityLinkGroup[SecurityGroupName.assets].title,
renderAs: 'panelOpener',
children: [
{
link: 'fleet',
title: i18nStrings.assets.fleet.title,
children: [
{
link: 'fleet:agents',
},
{
link: 'fleet:policies',
title: i18nStrings.assets.fleet.policies,
},
{
link: 'fleet:enrollment_tokens',
},
{
link: 'fleet:uninstall_tokens',
},
{
link: 'fleet:data_streams',
},
{
link: 'fleet:settings',
},
],
},
{
id: SecurityPageName.endpoints,
title: i18nStrings.assets.endpoints.title,
children: [
{
id: SecurityPageName.endpoints,
link: securityLink(SecurityPageName.endpoints),
breadcrumbStatus: 'hidden',
},
{
id: SecurityPageName.policies,
link: securityLink(SecurityPageName.policies),
},
{
id: SecurityPageName.artifacts,
title: i18nStrings.assets.artifacts.title,
link: securityLink(SecurityPageName.artifacts),
getIsActive: ({ pathNameSerialized, prepend }) =>
ARTIFACT_TAB_PATHS.some((path) => pathNameSerialized.startsWith(prepend(path))),
},
{
id: SecurityPageName.responseActionsHistory,
link: securityLink(SecurityPageName.responseActionsHistory),
},
{
id: SecurityPageName.scriptLibrary,
link: securityLink(SecurityPageName.scriptLibrary),
},
],
},
],
};
};
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { links as managementLinks, getManagementFilteredLinks } from '../../mana
import { exploreLinks } from '../../explore/links';
import { onboardingLinks } from '../../onboarding/links';
import { findingsLinks } from '../../cloud_security_posture/links';
import type { ExperimentalFeatures } from '../../../common/experimental_features';
import type { StartPlugins } from '../../types';
import { dashboardsLinks } from '../../dashboards/links';
import { entityAnalyticsLinks } from '../../entity_analytics/links';
Expand Down Expand Up @@ -53,9 +54,14 @@ export const appLinks: AppLinkItems = Object.freeze([

export const getFilteredLinks = async (
core: CoreStart,
plugins: StartPlugins
plugins: StartPlugins,
experimentalFeatures: ExperimentalFeatures
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want to coordinate with @ashokaditya , he's making very similar changes to this exact function for this same reason https://github.com/elastic/kibana/pull/260429/files#diff-d7b43749c559b9c4036c0e2cc6d922ea086a41ed1ea89097fb37b5372166b9e6R58 experimentalFeatures is an optional param in that branch, so whoever ends up merging 2nd should be careful.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just approved the PR! Thanks for pointing this out @kqualters-elastic I missed that

): Promise<AppLinkItems> => {
const managementFilteredLinks = await getManagementFilteredLinks(core, plugins);
const managementFilteredLinks = await getManagementFilteredLinks(
core,
plugins,
experimentalFeatures
);

const chatExperience$ = core.uiSettings.get$<AIChatExperience>(
AI_CHAT_EXPERIENCE_TYPE,
Expand Down
Loading
Loading