-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[EDR Workflows][Artifacts Regrouping] Re-organize all artifacts to a single page with separate tabs #257001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[EDR Workflows][Artifacts Regrouping] Re-organize all artifacts to a single page with separate tabs #257001
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
3c9bdbf
combine artifacts into one main page with separate tabs
parkiino f02eb23
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino 79684b6
move old pages into one artifacts navigation link
parkiino f3c8e89
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino dfd7e80
add artifacts light and dark icon
parkiino a4f4999
adjust artifact page to fit design
parkiino 28ab571
remove unnecessary files
parkiino f4a1501
remove unnecessary file, add breadcrumbs
parkiino 04423b0
add unit tests
parkiino 12b2b05
hide timeline for artifacts tabs
parkiino 26d69d3
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino c8ee881
remove docs folder
parkiino 13fbc0e
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 1ecf551
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino 90e3f4f
fix lint errors
parkiino 1bb64ad
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino 1996091
fix i18n
parkiino d0da48d
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino 8437523
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino 856e0d7
update cypress test for artifact regrouping
parkiino 77299ab
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino 58a40c2
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino 9d5707e
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino d5efafe
move artifact no data state vertically so it looks more centered
parkiino e17d0bc
Wrap artifact tabs in TrackApplicationView
parkiino c4ccc91
make ontabclick usecallback
parkiino fcbcbaf
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine d1ccec6
fix tests wip
parkiino 4f128dc
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino a7e33bc
bring back show host isolation exception logic
parkiino 66573ea
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino 1b2b5f5
remove one more translation
parkiino c954c33
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 1d0a1eb
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino 8556238
adjust artifact description text, add back individual artifact tab de…
parkiino 4f5309a
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino 3aa96f4
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino a701d14
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 024d834
make artifacts link dynamic everywhere
parkiino fab97c2
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino 7e31a31
make default path for tab more robust
parkiino 212be7c
checks for host isolation exception on artifacts page
parkiino 5baa80f
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino b5e78d0
fix nav test
parkiino c3be77f
fix merge errors
parkiino 52c7227
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 90929e4
fixing merge errors
parkiino b63f5fd
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino 51311c9
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 45f49e7
fix flashing assets side menu on artifacts page in serverless
parkiino bbb081d
restore missing back button
parkiino 6d1f36a
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino f702ad2
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino 540b50b
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino aa6bf12
make experimental features a direct parameter
parkiino 1007f2d
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 466bfee
make canReadAnyArtifact more robust with experimental features check
parkiino 7369be9
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino 854005e
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino 3ee83e2
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine 04d004e
incorporate konrads pr reviews
parkiino 1ca780c
Merge branch 'task/regroup-artifacts' of github.com:parkiino/kibana i…
parkiino 3b87f3c
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino b29ddd9
adjust test mock
parkiino 1dfd650
Merge remote-tracking branch 'upstream/main' into task/regroup-artifacts
parkiino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably want to coordinate with @ashokaditya , he's making very similar changes to this exact function for this same reason https://github.com/elastic/kibana/pull/260429/files#diff-d7b43749c559b9c4036c0e2cc6d922ea086a41ed1ea89097fb37b5372166b9e6R58 experimentalFeatures is an optional param in that branch, so whoever ends up merging 2nd should be careful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I just approved the PR! Thanks for pointing this out @kqualters-elastic I missed that