[I18n] Translate kibana - visualize#25638
Merged
LeanidShutau merged 14 commits intoelastic:masterfrom Dec 13, 2018
Merged
Conversation
LeanidShutau
force-pushed
the
feature/translations/kibana-visualize
branch
from
60cd46b to
1db116b
Compare
LeanidShutau
changed the title
LeanidShutau
added
the
Feature:Visualizations
LeanidShutau
requested review from
maryia-lapata,
pavel06081991 and
timroes
and removed request for
timroes
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
…ons/kibana-visualize
timroes
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💚 Build Succeeded |
pavel06081991
approved these changes
Nov 20, 2018
Contributor
pavel06081991
left a comment
pavel06081991
left a comment
There was a problem hiding this comment.
LGTM but please fix some small comments
src/core_plugins/kibana/public/visualize/listing/no_visualizations_prompt.js
Outdated
Show resolved
Hide resolved
src/core_plugins/kibana/public/visualize/listing/visualize_listing.html
Outdated
Show resolved
Hide resolved
src/core_plugins/kibana/public/visualize/listing/visualize_listing_table.js
Outdated
Show resolved
Hide resolved
…ons/kibana-visualize
Contributor
💚 Build Succeeded |
…ons/kibana-visualize
LeanidShutau
force-pushed
the
feature/translations/kibana-visualize
branch
from
1b133c9 to
d1933df
Compare
Contributor
💚 Build Succeeded |
Contributor
|
Please bring this up to date with master. |
…ons/kibana-visualize
Contributor
💚 Build Succeeded |
Contributor
|
Blocked by #26173 |
Contributor
💚 Build Succeeded |
Contributor
|
Removed the |
…ons/kibana-visualize
Contributor
💚 Build Succeeded |
…ons/kibana-visualize
Contributor
💚 Build Succeeded |
…ons/kibana-visualize
Contributor
💚 Build Succeeded |
timroes
reviewed
Dec 6, 2018
src/legacy/core_plugins/kibana/public/visualize/wizard/step_2.html
Outdated
Show resolved
Hide resolved
timroes
suggested changes
Dec 11, 2018
src/legacy/core_plugins/kibana/public/visualize/wizard/step_2.html
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
LeanidShutau
added a commit
to LeanidShutau/kibana
that referenced
this pull request
Dec 13, 2018
* [I18n] Add translations for kibana/visualize * Translate topNavMenu * Add missing translations * Use i18n-filter in angular directive
LeanidShutau
added a commit
that referenced
this pull request
Dec 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#23257