Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/scripts/steps/test/jest_parallel.sh
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ echo "--- Running combined jest_all for configs ($TEST_TYPE)"
echo "$configs"
echo "JEST_MAX_PARALLEL is set to: $JEST_MAX_PARALLEL"

node_opts="--max-old-space-size=${JEST_MAX_OLD_SPACE_MB} --trace-warnings --no-experimental-require-module"
node_opts="--max-old-space-size=${JEST_MAX_OLD_SPACE_MB} --trace-warnings"
if [[ "${TEST_ENABLE_FIPS_VERSION:-}" == "140-2" ]] || [[ "${TEST_ENABLE_FIPS_VERSION:-}" == "140-3" ]] ; then
node_opts="$node_opts --enable-fips --openssl-config=$HOME/nodejs.cnf"
fi
Expand Down
3 changes: 0 additions & 3 deletions config/node.options
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,3 @@

## restore < Node 16 default DNS lookup behavior
--dns-result-order=ipv4first

## disable ES modules until stable
--no-experimental-require-module
54 changes: 27 additions & 27 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,35 +39,35 @@
"author": "Rashid Khan <rashid.khan@elastic.co>",
"scripts": {
"backport-skip-ci": "backport --prDescription \"[skip-ci]\"",
"build": "node --no-experimental-require-module scripts/build --all-platforms",
"build:apidocs": "node --no-experimental-require-module scripts/build_api_docs",
"checkLicenses": "node --no-experimental-require-module scripts/check_licenses --dev",
"debug": "node --no-experimental-require-module --nolazy --inspect scripts/kibana --dev",
"debug-break": "node --no-experimental-require-module --nolazy --inspect-brk scripts/kibana --dev",
"build": "node scripts/build --all-platforms",
"build:apidocs": "node scripts/build_api_docs",
"checkLicenses": "node scripts/check_licenses --dev",
"debug": "node --nolazy --inspect scripts/kibana --dev",
"debug-break": "node --nolazy --inspect-brk scripts/kibana --dev",
"dev-docs": "scripts/dev_docs.sh",
"es": "node --no-experimental-require-module scripts/es",
"preinstall": "node --no-experimental-require-module ./preinstall_check",
"kbn": "node --no-experimental-require-module scripts/kbn",
"es": "node scripts/es",
"preinstall": "node ./preinstall_check",
"kbn": "node scripts/kbn",
"lint": "yarn run lint:es && yarn run lint:style",
"lint:es": "node --no-experimental-require-module scripts/eslint_all_files",
"lint:oxc": "node --no-experimental-require-module scripts/lint",
"lint:style": "node --no-experimental-require-module scripts/stylelint",
"makelogs": "node --no-experimental-require-module scripts/makelogs",
"quick-checks": "node --no-experimental-require-module scripts/quick_checks",
"serverless": "node --no-experimental-require-module scripts/kibana --dev --serverless",
"serverless-es": "node --no-experimental-require-module scripts/kibana --dev --serverless=es",
"serverless-oblt": "node --no-experimental-require-module scripts/kibana --dev --serverless=oblt",
"serverless-security": "node --no-experimental-require-module scripts/kibana --dev --serverless=security",
"serverless-workplace-ai": "node --no-experimental-require-module scripts/kibana --dev --serverless=workplaceai",
"spec_to_console": "node --no-experimental-require-module scripts/spec_to_console",
"start": "node --no-experimental-require-module scripts/kibana --dev",
"storybook": "node --no-experimental-require-module scripts/storybook",
"test:ftr": "node --no-experimental-require-module scripts/functional_tests",
"test:ftr:runner": "node --no-experimental-require-module scripts/functional_test_runner",
"test:ftr:server": "node --no-experimental-require-module scripts/functional_tests_server",
"test:jest": "node --no-experimental-require-module scripts/jest",
"test:jest_integration": "node --no-experimental-require-module scripts/jest_integration",
"test:type_check": "node --no-experimental-require-module scripts/type_check"
"lint:es": "node scripts/eslint_all_files",
"lint:oxc": "node scripts/lint",
"lint:style": "node scripts/stylelint",
"makelogs": "node scripts/makelogs",
"quick-checks": "node scripts/quick_checks",
"serverless": "node scripts/kibana --dev --serverless",
"serverless-es": "node scripts/kibana --dev --serverless=es",
"serverless-oblt": "node scripts/kibana --dev --serverless=oblt",
"serverless-security": "node scripts/kibana --dev --serverless=security",
"serverless-workplace-ai": "node scripts/kibana --dev --serverless=workplaceai",
"spec_to_console": "node scripts/spec_to_console",
"start": "node scripts/kibana --dev",
"storybook": "node scripts/storybook",
"test:ftr": "node scripts/functional_tests",
"test:ftr:runner": "node scripts/functional_test_runner",
"test:ftr:server": "node scripts/functional_tests_server",
"test:jest": "node scripts/jest",
"test:jest_integration": "node scripts/jest_integration",
"test:type_check": "node scripts/type_check"
},
"repository": {
"type": "git",
Expand Down
6 changes: 0 additions & 6 deletions src/cli/kibana/dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,6 @@ if (collectExtendedStackTrace) {
}
// More info in https://trace.js.org/

if (process.features.require_module) {
console.warn(
"Node.js's experimental support for native ES modules is enabled. This will not be enabled in production while the feature is experimental. It is recommended to add `--no-experimental-require-module` to NODE_OPTIONS."
);
}

require('@kbn/setup-node-env');

require('./apm')(process.env.ELASTIC_APM_SERVICE_NAME || 'kibana-proxy');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Add the following snippet to your settings for your AI Coding IDE so it will aut
"command": "bash",
"args": [
"-lc",
"source \"$NVM_DIR/nvm.sh\" && cd ${KIBANA_WORKSPACE} && nvm use --silent && node --no-experimental-require-module ./scripts/mcp_dev.js"
"source \"$NVM_DIR/nvm.sh\" && cd ${KIBANA_WORKSPACE} && nvm use --silent && node ./scripts/mcp_dev.js"
]
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ describe('runCiChecksTool', () => {
});

expect(mockedExeca.command).toHaveBeenCalledWith(
'node --no-experimental-require-module scripts/build_kibana_platform_plugins',
'node scripts/build_kibana_platform_plugins',
{
cwd: '/repo/root',
stdio: 'pipe',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ interface CiChecksResult {
const CI_CHECKS = {
build: {
name: 'Build Kibana Distribution',
command: 'node --no-experimental-require-module scripts/build_kibana_platform_plugins',
command: 'node scripts/build_kibana_platform_plugins',
description: 'Build Kibana platform plugins',
},
quick_checks: {
Expand All @@ -80,12 +80,12 @@ const CI_CHECKS = {
},
linting_with_types: {
name: 'Linting (with types)',
command: 'node --no-experimental-require-module scripts/eslint_with_types',
command: 'node scripts/eslint_with_types',
description: 'Run ESLint with type checking',
},
oas_snapshot: {
name: 'OAS Snapshot',
command: 'node --no-experimental-require-module scripts/validate_oas_docs',
command: 'node scripts/validate_oas_docs',
description: 'Validate OpenAPI documentation',
},
};
Expand Down
Loading