[Emotion] Use patched Emotion library to resolve Flyout System issue

[tsullivan]

Summary

Closes #255318

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

• [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• [ ] Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
• [ ] Flaky Test Runner was used on any tests changed
• [ ] The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
• [ ] Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

• Added a resolution field for @emotion/sheet to use an Elastic fork (see diff). We trust any issue this may add can be caught by functional tests, especially the new one added.

[tkajtoch]

@elasticmachine merge upstream

[github-actions]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[tkajtoch]

The snapshot failures come from isSpeedy defaulting to true in production environments. This is already the case in Kibana (see src), but old Enzyme tests that import directly from enzyme and don't wrap the JSX in necessary providers result in their snapshots being slightly different.

The real difference is that in the original package (1.2.2), Emotion checks process.env.NODE_ENV === 'production' (src), which results in false in Kibana test environment, while the latest version got refactored to use an import directive (src) that checks whether NODE_ENV is set to 'development' - pretty much the same thing, but better, because it keeps all non-development environments in sync.

Considering these are just a few snapshots, I'm tempted to just update them so that the tests reflect what's in production builds.

[tsullivan]

Considering these are just a few snapshots, I'm tempted to just update them so that the tests reflect what's in production builds.

Thanks @tkajtoch. I concluded the same thing I have updated the test snapshots.

Earlier this week I sent an email to Kibana contributors asking them to migrate away from tests that assert snapshots of rendered components as this type of this is low-value and brittle. Hopefully as people migrate away from Enzyme they can do so in a way that replaces snapshot tests with things that verify component behaviors with RTL.

[cauemarcondes]

Obs exploration changes LGTM

[davismcphee]

Ran through the Scout test scenario manually to verify. Data Discovery changes LGTM 👍 Thanks for all the investigation here and fixing this!

[tsullivan]

Flaky test run: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/10984

[kibanamachine]

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#10984

[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 15/15 tests passed.

see run history

[nreese]

kibana-presentation changes LGTM - jest snapshot update
code review only

[tsullivan]

/ci

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 06dffb5
• Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-256086-06dffb50612c

Failed CI Steps

• Check Types

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/scout	252	253	+1
@kbn/scout-oblt	258	259	+1
@kbn/scout-search	247	248	+1
@kbn/scout-security	262	263	+1
total			+4

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
@kbn/scout	34	35	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
kbnUiSharedDeps-npmDll	7.1MB	7.1MB	+69.0B

Unknown metric groups

API count

id	before	after	diff
@kbn/scout	658	659	+1
@kbn/scout-oblt	649	650	+1
@kbn/scout-search	638	639	+1
@kbn/scout-security	653	654	+1
total			+4

History

• 💛 Build #406152 was flaky 8a92aaf
• 💔 Build #406016 failed a85109d
• 💔 Build #405418 failed 26c07d5
• 💔 Build #405223 failed 32e3646
• 💔 Build #404708 failed faa0c50