-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ML] convert Less to Scss #25574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[ML] convert Less to Scss #25574
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
092d968
ml less to sass
snide 8128f0a
replace and reworks less file changes in the gap period between origi…
snide 7d3c937
remove jobs list old content
snide 5a21ff8
remove paginated table
snide fb6c7b0
feedback
snide 91c08fe
modal fix
snide File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // ML has app specific coloring for it's various warning levels. | ||
| // These are used almost everywhere. | ||
|
|
||
| .ml-icon-severity-critical, | ||
| .ml-icon-severity-major, | ||
| .ml-icon-severity-minor, | ||
| .ml-icon-severity-warning, | ||
| .ml-icon-severity-unknown { | ||
| text-shadow: 1px 1px 1px $euiColorLightShade; | ||
| } | ||
|
|
||
| .ml-icon-severity-critical { | ||
| color: $mchColorCriticalText; | ||
| } | ||
|
|
||
| .ml-icon-severity-major { | ||
| color: $mchColorMajorText; | ||
| } | ||
|
|
||
| .ml-icon-severity-minor { | ||
| color: $mchColorMinorText; | ||
| } | ||
|
|
||
| .ml-icon-severity-warning { | ||
| color: $mchColorWarningText; | ||
| } | ||
|
|
||
| .ml-icon-severity-unknown { | ||
| color: $mchColorUnknownText; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // These are hacks that were near ML's root. Unsure if they still need to be here. | ||
| .tab-jobs, | ||
| .edit-job-modal, | ||
| .create-watch-modal { | ||
| label { | ||
| display: inline-block; | ||
| } | ||
|
|
||
| .validation-error { | ||
| margin-top: $euiSizeXS; | ||
| } | ||
| } | ||
|
|
||
| // ML specific bootstrap hacks | ||
| .button-wrapper { | ||
| display: inline; | ||
| } | ||
|
|
||
| .button-wrapper.disabled .kuiButton[disabled] { | ||
| pointer-events: none; | ||
| } | ||
|
|
||
| .button-wrapper.disabled { | ||
| cursor: not-allowed; | ||
| } | ||
|
|
||
| // ML bootstrap-select hacks that sit on top of Kibana hacks that often fight with KUI | ||
| // Should go away when EUI is fully adopted | ||
| .ui-select-match { | ||
| .btn-default[disabled], | ||
| .btn-default[disabled]:hover, | ||
| .btn-default[disabled]:focus { | ||
| background-color: $euiColorLightShade; | ||
| border-color: $euiColorLightShade; | ||
| opacity: 1; | ||
|
|
||
| .ui-select-placeholder { | ||
| color: $euiColorDarkShade; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .ui-select-container input[type="search"]::placeholder { | ||
| color: $euiColorDarkShade; | ||
| } | ||
|
|
||
| .ui-select-container input[type="search"]:focus { | ||
| box-shadow: none; | ||
| } | ||
|
|
||
| .ui-select-multiple.ui-select-bootstrap input.ui-select-search { | ||
| font-size: $euiFontSizeS; | ||
| padding: 5px 10px; // Matches current padding hacks from other parts of Kibana | ||
| } | ||
|
|
||
|
|
||
| // SASSTODO: Remove all the floats | ||
| .clear, .clearfix { | ||
| clear: both; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| $mchColorCritical: #fe5050; | ||
walterra marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| $mchColorMajor: #fba740; | ||
| $mchColorMinor: #fdec25; | ||
| $mchColorWarning: #8bc8fb; | ||
| $mchColorUnknown: #c0c0c0; | ||
|
|
||
| $mchColorCriticalText: makeHighContrastColor($mchColorCritical, $euiColorEmptyShade); | ||
| $mchColorMajorText: makeHighContrastColor($mchColorMajor, $euiColorEmptyShade); | ||
| $mchColorMinorText: makeHighContrastColor($mchColorMinor, $euiColorEmptyShade); | ||
| $mchColorWarningText: makeHighContrastColor($mchColorWarning, $euiColorEmptyShade); | ||
| $mchColorUnknownText: $euiColorDarkShade; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
x-pack/plugins/ml/public/components/anomalies_table/_index.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| @import 'anomalies_table'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| @import 'chart_tooltip'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,5 +6,4 @@ | |
|
|
||
|
|
||
|
|
||
| import './chart_tooltip'; | ||
| import './styles/main.less'; | ||
| import './chart_tooltip'; | ||
25 changes: 25 additions & 0 deletions
25
x-pack/plugins/ml/public/components/confirm_modal/_confirm_modal.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| .confirm-modal { | ||
| padding: $euiSizeL; | ||
| cursor: auto; | ||
|
|
||
| // SASSTODO: Needs a proper selector | ||
| h3 { | ||
| margin-top: 0px; | ||
| } | ||
|
|
||
| .modal-title { | ||
| font-weight: $euiFontWeightBold; | ||
| padding-bottom: $euiSizeL; | ||
| } | ||
|
|
||
| .modal-body { | ||
| padding: 0px; | ||
| padding-bottom: $euiSizeL; | ||
| } | ||
|
|
||
| .modal-footer { | ||
| padding: 0px; | ||
| padding-top: $euiSizeL; | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| @import 'confirm_modal'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,4 +8,3 @@ | |
|
|
||
| import './confirm_modal_service'; | ||
| import './confirm_modal_controller'; | ||
| import './styles/main.less'; | ||
24 changes: 0 additions & 24 deletions
24
x-pack/plugins/ml/public/components/confirm_modal/styles/main.less
This file was deleted.
Oops, something went wrong.
8 changes: 4 additions & 4 deletions
8
...blic/components/controls/styles/main.less → ...public/components/controls/_controls.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,16 @@ | ||
| .ml-table-controls { | ||
| label { | ||
| font-size: 12px; | ||
| padding: 0px 0px 5px 5px; | ||
| font-size: $euiFontSizeXS; | ||
| padding: 0px 0px $euiSizeXS $euiSizeXS; | ||
| } | ||
|
|
||
| .ml-table-controls-element { | ||
| display: inline-block; | ||
| padding-left: 15px; | ||
| padding-left: $euiSize; | ||
| } | ||
|
|
||
| select { | ||
| font-size: 13px; | ||
| font-size: $euiFontSizeXS; | ||
| font-style: normal; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| @import 'controls'; | ||
| @import 'controls_select/index'; | ||
| @import 'select_severity/index'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
x-pack/plugins/ml/public/components/controls/controls_select/_index.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| @import 'controls_select'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,5 +6,4 @@ | |
|
|
||
|
|
||
|
|
||
| import './styles/main.less'; | ||
| import './controls_select_directive.js'; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.