Skip to content

Fix agent status lookup #25557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonrhodes merged 11 commits into from
Nov 17, 2018
Merged

Fix agent status lookup #25557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a563eb6
Updates service overview to only do agent status check once
jasonrhodes Nov 9, 2018
0581690
TS support added for EmptyMessage and those who import it
jasonrhodes Nov 9, 2018
0c94f3b
Fixed up tests
jasonrhodes Nov 9, 2018
2e80929
Finishes TS and test updates for agent check fix
jasonrhodes Nov 12, 2018
029f0ed
Fixing up tests
jasonrhodes Nov 13, 2018
64e7a7d
Fixed linting error
jasonrhodes Nov 14, 2018
2f1ffcd
Updated broken tests
jasonrhodes Nov 14, 2018
6e219a2
Re-typed the service list response, camelCase throughout
jasonrhodes Nov 15, 2018
e16b50f
Fixes broken test after data change
jasonrhodes Nov 15, 2018
71c888f
Makes initial data type more specific
jasonrhodes Nov 15, 2018
4081c32
Moves service list item TS interface back into server lib file
jasonrhodes Nov 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/public/components/app/ErrorGroupDetails/Distribution/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import React from 'react';
import Histogram from '../../../shared/charts/Histogram';
import EmptyMessage from '../../../shared/EmptyMessage';
import { EmptyMessage } from '../../../shared/EmptyMessage';
import { HeaderSmall } from '../../../shared/UIComponents';

export function getFormattedBuckets(buckets, bucketSize) {
Expand Down
50 changes: 26 additions & 24 deletions x-pack/plugins/apm/public/components/app/ServiceOverview/ServiceList/__test__/List.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,41 +5,43 @@
*/

import React from 'react';
import { mount } from 'enzyme';

import { MemoryRouter } from 'react-router-dom';
import { ServiceList } from '../index';
import { shallow } from 'enzyme';
import { ServiceList, SERVICE_COLUMNS } from '../index';
import props from './props.json';
import {
mountWithRouterAndStore,
mockMoment,
toJson
} from '../../../../../utils/testHelpers';
import { mockMoment } from '../../../../../utils/testHelpers';

describe('ErrorGroupOverview -> List', () => {
beforeAll(() => {
mockMoment();
});

it('should render empty state', () => {
const storeState = {};
const wrapper = mount(
<MemoryRouter>
<ServiceList items={[]} />
</MemoryRouter>,
storeState
);

expect(toJson(wrapper)).toMatchSnapshot();
const wrapper = shallow(<ServiceList items={[]} />);
expect(wrapper).toMatchSnapshot();
});

it('should render with data', () => {
const storeState = { location: {} };
const wrapper = mountWithRouterAndStore(
<ServiceList items={props.items} />,
storeState
);
const wrapper = shallow(<ServiceList items={props.items} />);
expect(wrapper).toMatchSnapshot();
});

expect(toJson(wrapper)).toMatchSnapshot();
it('should render columns correctly', () => {
const service = {
serviceName: 'opbeans-python',
agentName: 'python',
transactionsPerMinute: 86.93333333333334,
errorsPerMinute: 12.6,
avgResponseTime: 91535.42944785276
};
const renderedColumns = SERVICE_COLUMNS.map(c =>
c.render(service[c.field], service)
);
expect(renderedColumns[0]).toMatchSnapshot();
expect(renderedColumns.slice(1)).toEqual([
'python',
'92 ms',
'86.9 tpm',
'12.6 err.'
]);
});
});
Loading