[Alerting v2] Split condition #255425
Closed
dominiqueclarke wants to merge 36 commits into
Closed
Conversation
…feature/alerting-v2-dedicated-form
Add missing newline at the end of the tsconfig.json file
…iqueclarke/kibana into feature/alerting-v2-dedicated-form
…iqueclarke/kibana into feature/alerting-v2-dedicated-form
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
…iqueclarke/kibana into feature/alerting-v2-dedicated-form
…iqueclarke/kibana into feature/alerting-v2-condition
…iqueclarke/kibana into feature/alerting-v2-condition
…iqueclarke/kibana into feature/alerting-v2-dedicated-form
…iqueclarke/kibana into feature/alerting-v2-condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #251326 (sets up condition clause that will be required for recovery)
This PR introduces condition editing for ES|QL alerting rules, allowing users to define WHERE clause conditions that determine when alerts should trigger.
Discover.-.Elastic.2.webm
Key Features
1. WHERE Clause Editor
A specialized Monaco-based editor for defining alert trigger conditions:
| WHEREprefix for ES|QL syntax contextuseDebounceFnfrom@kbn/react-hooks2. Query Splitting
Automatically separates an ES|QL query into base query and condition when the form initializes:
This enables Discover to pass a full query, and the form will automatically extract the WHERE clause as the editable condition.
3. Condition Field Group
A new form section that displays:
DynamicRuleForm, editable when usingStandaloneRuleForm)New Components
WhereClauseEditorEvaluationQueryFieldConditionFieldGroupNew Hooks
useQueryBaseAndConditionuseEsqlCallbacksNew Utilities
splitQueryAndConditionSchema Changes
Files Changed
where_clause_editor.tsxesql_editor_field.tsx,evaluation_query_field.tsxcondition_field_group.tsxuse_query_base_and_condition.ts,use_esql_callbacks.tssplit_query_and_condition.tstypes.tsconditiontoEvaluationQueryrule_form.tsxConditionFieldGroupuse_form_defaults.tsget_create_rule.tsxHow It Works
FROM logs-* | STATS count() BY host | WHERE count > 100useQueryBaseAndConditionparses the query and extracts:FROM logs-* | STATS count() BY hostcount > 100WhereClauseEditor{ base: "FROM logs-*...", condition: "count > 100" }Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.
WhereClauseEditoruses Monaco directly. Mitigated by mocking@kbn/code-editorin tests and lazy loading in Discover.nullgracefully for unsupported patterns.