translate Machine Learning datavisualizer#25527
Merged
Nox911 merged 76 commits intoelastic:masterfrom Dec 20, 2018
Merged
Conversation
second merge
Contributor
💚 Build Succeeded |
maryia-lapata
suggested changes
Nov 13, 2018
Contributor
maryia-lapata
left a comment
maryia-lapata
left a comment
There was a problem hiding this comment.
Please update ids according to namespace xpack.ml. and use concatenation instead of eslint rule disabling.
x-pack/plugins/ml/public/datavisualizer/datavisualizer_controller.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/datavisualizer/datavisualizer_controller.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/datavisualizer/datavisualizer_controller.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/datavisualizer/selector/datavisualizer_selector.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/datavisualizer/selector/datavisualizer_selector.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/datavisualizer/selector/datavisualizer_selector.js
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
|
retest |
Contributor
💚 Build Succeeded |
peteharverson
approved these changes
Dec 19, 2018
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Latest changes LGTM
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Dec 21, 2018
* translate Machine Learning datavisualizer * change some ids, change some structures and dont translate unnesesary scripts * update i18nrc.json * update datavisualizer_selector.js - remove eslint-disable * add html_ prefix to values containing html * use i18n angular service. translate missed labels * Fix syntax in i18n-values * Replace FormatedMessage to intl.formatMessage for betaBadgeLabel * Fix issue
maryia-lapata
added a commit
that referenced
this pull request
Dec 21, 2018
* translate Machine Learning datavisualizer * change some ids, change some structures and dont translate unnesesary scripts * update i18nrc.json * update datavisualizer_selector.js - remove eslint-disable * add html_ prefix to values containing html * use i18n angular service. translate missed labels * Fix syntax in i18n-values * Replace FormatedMessage to intl.formatMessage for betaBadgeLabel * Fix issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
translate Machine Learning datavisualizer
#25454
Guidline
Readme