Skip to content

Add validation to block use of authorization headers with credentials in fleet download source config#255209

Merged
MichelLosier merged 3 commits intoelastic:mainfrom
MichelLosier:fleet/guard-against-auth-header-for-dl-source
Feb 27, 2026
Merged

Add validation to block use of authorization headers with credentials in fleet download source config#255209
MichelLosier merged 3 commits intoelastic:mainfrom
MichelLosier:fleet/guard-against-auth-header-for-dl-source

Conversation

@MichelLosier
Copy link
Copy Markdown
Contributor

Summary

Resolves: #254028

  • Adds validation in the UI form and API handler for download source configuration to prevent defining of an Authorization custom header in combination with username:password or api key definitions.
Screenshot 2026-02-26 at 3 16 01 PM

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@MichelLosier MichelLosier requested a review from a team as a code owner February 26, 2026 23:29
@botelastic botelastic Bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 26, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@MichelLosier MichelLosier added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Feb 26, 2026
Copy link
Copy Markdown
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM 🚀

@MichelLosier MichelLosier merged commit 177083e into elastic:main Feb 27, 2026
16 checks passed
qn895 pushed a commit to qn895/kibana that referenced this pull request Mar 11, 2026
… in fleet download source config (elastic#255209)

Resolves: elastic#254028

* Adds validation in the UI form and API handler for download source
configuration to prevent defining of an `Authorization` custom header in
combination with username:password or api key definitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet] Download source auth should disallow "Authorization" custom headers AND API key or username/password

4 participants