show drop partial buckets option#25520
Merged
ppisljar merged 3 commits intoelastic:masterfrom Nov 23, 2018
Merged
Conversation
ppisljar
added
review
v7.0.0
v6.5.0
v6.6.0
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app |
markov00
reviewed
Nov 12, 2018
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Code LGTM. Tested locally on chrome/OSX.
Can you add a simple functional test for this option?
markov00
reviewed
Nov 12, 2018
Contributor
There was a problem hiding this comment.
I think it's better to change this test as the following:
- create a bar chart with a different timestamp than the standard one (one that contains partial buckets)
- test the expected values before applying the
drop partial bucketoption - apply the
drop partial bucketoption - test and expect a smaller amount of values as expected data.
So we can test either the partial bucket option checkbox and the functionality
Contributor
💔 Build Failed |
ppisljar
force-pushed
the
fix/dropPartialBuckets
branch
from
b9c6c1e to
0e0d39f
Compare
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
|
seems a legit fail: |
ppisljar
force-pushed
the
fix/dropPartialBuckets
branch
from
0e0d39f to
3df64bd
Compare
Contributor
💚 Build Succeeded |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Nov 23, 2018
ppisljar
added a commit
that referenced
this pull request
Nov 26, 2018
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Dec 7, 2018
timroes
added a commit
that referenced
this pull request
Dec 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Check for showing 'show partial buckets' option was broken, this fixes it.
resolves #25521
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately